<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
I'd just like to second Berk's point.<br>
<br>
I'm going to commit new particle tracer code soon, and I've used maps,
lists, vectors extensively to handle the MPI communication matrices and
send/receive lists. No other classes include the header files for the
particle tracer, so whether they're included by the PT code, or in the
PT header makes no difference. Pimplification of the whole lot is just
a waste of time and makes the code messier.<br>
<br>
Please don't make it too difficult for people like me to commit stuff,
otherwise ...(Berk knows ...)<br>
<br>
JB<br>
<br>
<br>
<blockquote
cite="mid:45d654b0906051847l7c99e58fh6bb5ecd9d4773af6@mail.gmail.com"
type="cite">
<pre wrap="">Is there a way of by-passing this commit check? There are a rare
occasions where it may be necessary to commit code which include STL
headers in .h files.
To remind everyone why the decision to keep STL headers from include
files was made: performance. STL headers are bulky and may slow down
compilation significantly if they are included in header files that
are included by a lot of other files. Including STL headers in the
include files of leaf classes (such as concrete algorithm classes)
does not have any effect on compilation time. There are no other good
reasons why STL headers cannot be included in header files.
Here is the catch: we occasionally receive contributions that include
STL header in .h. These tend to be super big reader classes. Fixing
the whole darn thing to use PIMPL is a waste of time which we don't
have. So, if we do not provide a way of having exception to this rule,
those contributions would never make it into VTK.
So we should either provide a way of by-passing this commit check in
these rare occasions or we should enforce this through a header test
which can support such exceptions.
-berk
On Fri, Jun 5, 2009 at 5:13 PM, Francois
Bertel<a class="moz-txt-link-rfc2396E" href="mailto:francois.bertel@kitware.com"><francois.bertel@kitware.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Isn't already enforced by HeaderTesting-* tests ?
PS: I continue the discussion on vtk-developers only as this is the
canonic place to discuss about this topic.
On Fri, Jun 5, 2009 at 4:42 PM, Dave Partyka<a class="moz-txt-link-rfc2396E" href="mailto:dave.partyka@kitware.com"><dave.partyka@kitware.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi everyone,
A new CVS commit check has been added to prevent commits of VTK header files
that contain STL includes. Exceptions can be added by contacting myself or
Brad King.
I also want to give a friendly reminder that the VTK coding standards (VTK
has coding standards???) provide guidelines for using STL in VTK and require
that STL not be used in header files. See the following for more information
or feel free to ask me if you have any questions.
VTK Coding Standards:
<a class="moz-txt-link-freetext" href="http://www.vtk.org/Wiki/VTK_Coding_Standards">http://www.vtk.org/Wiki/VTK_Coding_Standards</a>
VTK FAQ regarding STL
<a class="moz-txt-link-freetext" href="http://www.vtk.org/Wiki/VTK_FAQ#Can_I_use_STL_with_VTK.3F">http://www.vtk.org/Wiki/VTK_FAQ#Can_I_use_STL_with_VTK.3F</a>
Also please report any problems/bugs with the new commit check to myself or
Brad King.
Thanks very much!
</pre>
</blockquote>
<pre wrap="">
--
François Bertel, PhD | Kitware Inc. Suite 204
1 (518) 371 3971 x113 | 28 Corporate Drive
| Clifton Park NY 12065, USA
_______________________________________________
Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
Visit other Kitware open-source projects at <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
Follow this link to subscribe/unsubscribe:
<a class="moz-txt-link-freetext" href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
</pre>
</blockquote>
<pre wrap=""><!---->_______________________________________________
Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
Visit other Kitware open-source projects at <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
Follow this link to subscribe/unsubscribe:
<a class="moz-txt-link-freetext" href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="78">--
John Biddiscombe, email:biddisco @ cscs.ch
<a class="moz-txt-link-freetext" href="http://www.cscs.ch/">http://www.cscs.ch/</a>
CSCS, Swiss National Supercomputing Centre | Tel: +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland | Fax: +41 (91) 610.82.82</pre>
</body>
</html>