<div dir="ltr">Fixed again:<div><br><div><div> /cvsroot/VTK/VTK/Rendering/vtkXRenderWindowTclInteractor.cxx,v <-- vtkXRenderWindowTclInteractor.cxx</div><div> new revision: 1.56; previous revision: 1.55</div><div>
/cvsroot/VTK/VTK/Rendering/vtkXRenderWindowTclInteractor.h,v <-- vtkXRenderWindowTclInteractor.h</div><div> new revision: 1.28; previous revision: 1.27</div><div><br></div><div>Bill, anything else you've noticed in the last 24 hours...?</div>
<div><br></div><div>Thanks,</div><div>David</div><div><br></div><br><div class="gmail_quote">On Tue, Aug 19, 2008 at 5:25 PM, David Cole <span dir="ltr"><<a href="mailto:david.cole@kitware.com">david.cole@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div dir="ltr">Thanks for the report... I'll put fixing that on my list for tomorrow.<div><div></div><div class="Wj3C7c">
<br><br><div><br><div class="gmail_quote">On Tue, Aug 19, 2008 at 5:16 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I just updated my vtk head. polyConn.tcl works fine now, even exits<br>
when I hit "e'. However, if I add an 'iren Start", it crashes...<br>
<div><div></div><div><br>
On Tue, Aug 19, 2008 at 3:49 PM, David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>> wrote:<br>
> OK.....<br>
> See the notes in the original issue<br>
> ( <a href="http://public.kitware.com/Bug/view.php?id=3164" target="_blank">http://public.kitware.com/Bug/view.php?id=3164</a> ) if you want all the gory<br>
> details, but I have committed a further refinement of the fix to CVS HEAD.<br>
> Try it and let me know if you have any problems.<br>
> I will be merging it to VTK-5-2 tomorrow assuming the dashboards do not<br>
> complain about too many things overnight. :-)<br>
> Thanks for your patience,<br>
> David Cole<br>
><br>
> On Tue, Aug 19, 2008 at 11:59 AM, David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>> wrote:<br>
>><br>
>> If you add "iren Start", you also have to add an "exit" following it....<br>
>> (It hangs because it leaves the Start method and there is nothing telling<br>
>> Tcl/Tk to exit and clean up all the referenced objects...)<br>
>> If you wait just a little bit longer, I think I am closing in on the real<br>
>> fix.<br>
>> Thanks,<br>
>> David<br>
>><br>
>> On Tue, Aug 19, 2008 at 11:04 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> David,<br>
>>><br>
>>> I just built VTK head. Now when I run a script like:<br>
>>> VTK/Graphics/Testing/Tcl/polyConn.tcl<br>
>>><br>
>>> I get no interaction unless I add an "iren Start". If I hit an 'e' in<br>
>>> the graphics windows, the window hangs. Other keys like 'w' or 's'<br>
>>> work as expected.<br>
>>><br>
>>> Bill<br>
>>><br>
>>> On Mon, Aug 18, 2008 at 1:45 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>>> wrote:<br>
>>> > I,m at the VTK-5-2 branch.<br>
>>> ><br>
>>> > On Mon, Aug 18, 2008 at 12:23 PM, David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>><br>
>>> > wrote:<br>
>>> >> Nope. Same problem. Do you still get that with CVS HEAD of VTK, or are<br>
>>> >> you<br>
>>> >> snapped to the VTK-5-2 branch...?<br>
>>> >><br>
>>> >> On Mon, Aug 18, 2008 at 12:21 PM, Bill Lorensen<br>
>>> >> <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>>> >> wrote:<br>
>>> >>><br>
>>> >>> Maybe my problem is different. When I try to interact with a tcl test<br>
>>> >>> like polyConn.tcl, I get:<br>
>>> >>><br>
>>> >>> ERROR: In<br>
>>> >>> /home/lorensen/Projects/VTK/Rendering/vtkInteractorStyle.cxx,<br>
>>> >>> line 392<br>
>>> >>> vtkInteractorStyleJoystickCamera (0xa0129e8): Timer start failed<br>
>>> >>><br>
>>> >>> This is a fedora core 9 system, gcc 4.3.<br>
>>> >>><br>
>>> >>> Bill<br>
>>> >>><br>
>>> >>><br>
>>> >>> On Mon, Aug 18, 2008 at 10:39 AM, David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>><br>
>>> >>> wrote:<br>
>>> >>> > There is interaction available if you call "iren Start" at the<br>
>>> >>> > bottom of<br>
>>> >>> > your tcl script to push an X event loop sponsored by the<br>
>>> >>> > vtkRenderWindowInteractor.<br>
>>> >>> > The remaining problem is that on other platforms (Windows with<br>
>>> >>> > ActiveState<br>
>>> >>> > Tcl, for example) the vtk.exe Tcl/Tk event loop is running and<br>
>>> >>> > enabling<br>
>>> >>> > interaction without any "iren Start" at the bottom of the tcl<br>
>>> >>> > script. So<br>
>>> >>> > ideally, it would be nice to get that behavior for free in X<br>
>>> >>> > implementations, too... seems to be what VTK devs expect.<br>
>>> >>> > So, I may have to put back some of the tcl-specific X code that<br>
>>> >>> > used to<br>
>>> >>> > be<br>
>>> >>> > there before my commit last Thursday. I spent Friday in a fruitless<br>
>>> >>> > attempt<br>
>>> >>> > at getting the interaction to work with just X stuff from our<br>
>>> >>> > tcl/tk<br>
>>> >>> > app.<br>
>>> >>> > Maybe somebody out there can give me a hint about whether this is<br>
>>> >>> > really<br>
>>> >>> > possible or not...? Maybe I'm just wasting my time trying to<br>
>>> >>> > minimize<br>
>>> >>> > the<br>
>>> >>> > code required.... going back to using Tk_DoOneEvent and tcl timers<br>
>>> >>> > may<br>
>>> >>> > be<br>
>>> >>> > the right way to go after all.<br>
>>> >>> > At least there is now one common implementation for handling the<br>
>>> >>> > actual<br>
>>> >>> > X<br>
>>> >>> > events, though. At least that part of my cleanup effort will<br>
>>> >>> > survive. I<br>
>>> >>> > will<br>
>>> >>> > reply again with final results when I have them.<br>
>>> >>> > Thanks for your patience, and feel free to send along any helpful<br>
>>> >>> > hints.<br>
>>> >>> ><br>
>>> >>> ><br>
>>> >>> > David Cole<br>
>>> >>> ><br>
>>> >>> > On Mon, Aug 18, 2008 at 1:56 AM, Andrew Maclean<br>
>>> >>> > <<a href="mailto:andrew.amaclean@gmail.com" target="_blank">andrew.amaclean@gmail.com</a>><br>
>>> >>> > wrote:<br>
>>> >>> >><br>
>>> >>> >> Hi Bill, I think David is looking further into it.<br>
>>> >>> >> I think it still needs some more work. I tried it in the weekend<br>
>>> >>> >> and<br>
>>> >>> >> there was no interaction at all (mouse and keyboard).<br>
>>> >>> >> Regards<br>
>>> >>> >> Andrew<br>
>>> >>> >><br>
>>> >>> >><br>
>>> >>> >> On Mon, Aug 18, 2008 at 3:12 AM, Bill Lorensen<br>
>>> >>> >> <<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>><br>
>>> >>> >> wrote:<br>
>>> >>> >> > David,<br>
>>> >>> >> ><br>
>>> >>> >> > Is this ready for the VTK-5-2 branch?<br>
>>> >>> >> ><br>
>>> >>> >> > Bill<br>
>>> >>> >> ><br>
>>> >>> >> > 2008/8/14 David Cole <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>>:<br>
>>> >>> >> >> Fixed in CVS HEAD by making vtkXRenderWindowTclInteractor a<br>
>>> >>> >> >> trivial<br>
>>> >>> >> >> subclass<br>
>>> >>> >> >> of vtkXRenderWindowInteractor:<br>
>>> >>> >> >><br>
>>> >>> >> >> /cvsroot/VTK/VTK/Graphics/Testing/Tcl/TestFillHolesFilter.tcl,v<br>
>>> >>> >> >> <--<br>
>>> >>> >> >> Graphics/Testing/Tcl/TestFillHolesFilter.tcl<br>
>>> >>> >> >> new revision: 1.3; previous revision: 1.2<br>
>>> >>> >> >> /cvsroot/VTK/VTK/Rendering/vtkXRenderWindowInteractor.cxx,v<br>
>>> >>> >> >> <--<br>
>>> >>> >> >> Rendering/vtkXRenderWindowInteractor.cxx<br>
>>> >>> >> >> new revision: 1.136; previous revision: 1.135<br>
>>> >>> >> >> /cvsroot/VTK/VTK/Rendering/vtkXRenderWindowInteractor.h,v<br>
>>> >>> >> >> <--<br>
>>> >>> >> >> Rendering/vtkXRenderWindowInteractor.h<br>
>>> >>> >> >> new revision: 1.75; previous revision: 1.74<br>
>>> >>> >> >><br>
>>> >>> >> >> /cvsroot/VTK/VTK/Rendering/vtkXRenderWindowTclInteractor.cxx,v<br>
>>> >>> >> >> <--<br>
>>> >>> >> >> Rendering/vtkXRenderWindowTclInteractor.cxx<br>
>>> >>> >> >> new revision: 1.54; previous revision: 1.53<br>
>>> >>> >> >><br>
>>> >>> >> >> /cvsroot/VTK/VTK/Rendering/vtkXRenderWindowTclInteractor.h,v <--<br>
>>> >>> >> >> Rendering/vtkXRenderWindowTclInteractor.h<br>
>>> >>> >> >> new revision: 1.26; previous revision: 1.25<br>
>>> >>> >> >> I will merge this to the VTK-5-2 branch after a clean night on<br>
>>> >>> >> >> the<br>
>>> >>> >> >> dashboards and then mark this issue as resolved...<br>
>>> >>> >> >><br>
>>> >>> >> >> Thanks,<br>
>>> >>> >> >> David Cole<br>
>>> >>> >> >><br>
>>> >>> >> >> On Tue, Aug 12, 2008 at 4:19 PM, David Cole<br>
>>> >>> >> >> <<a href="mailto:david.cole@kitware.com" target="_blank">david.cole@kitware.com</a>><br>
>>> >>> >> >> wrote:<br>
>>> >>> >> >>><br>
>>> >>> >> >>> I will try to get this one fixed tomorrow.<br>
>>> >>> >> >>><br>
>>> >>> >> >>> Would anybody object to re-factoring the<br>
>>> >>> >> >>> vtkXRenderWindowTclInteractor<br>
>>> >>> >> >>> class (re-parent it from vtkXRenderWindowInteractor) such that<br>
>>> >>> >> >>> it<br>
>>> >>> >> >>> inherits<br>
>>> >>> >> >>> its common functionality and then has just overrides that are<br>
>>> >>> >> >>> specific<br>
>>> >>> >> >>> to<br>
>>> >>> >> >>> Tcl/Tk...?<br>
>>> >>> >> >>> I don't think it should break backwards compatibility for most<br>
>>> >>> >> >>> people,<br>
>>> >>> >> >>> although I could certainly imagine a class derived from it<br>
>>> >>> >> >>> that may<br>
>>> >>> >> >>> squawk<br>
>>> >>> >> >>> for one reason or another by having its parent chain<br>
>>> >>> >> >>> changed...<br>
>>> >>> >> >>> I think the intent of both classes was to have the same code<br>
>>> >>> >> >>> except<br>
>>> >>> >> >>> for<br>
>>> >>> >> >>> the differences due to making tcl calls from the TclInteractor<br>
>>> >>> >> >>> method<br>
>>> >>> >> >>> implementations. However, over time, they have diverged and<br>
>>> >>> >> >>> had<br>
>>> >>> >> >>> different<br>
>>> >>> >> >>> bug fixes applied to one that should have been applied to<br>
>>> >>> >> >>> both.<br>
>>> >>> >> >>><br>
>>> >>> >> >>> Is the fix for this bug simply to re-inherit<br>
>>> >>> >> >>> vtkXRenderWindowTclInteractor<br>
>>> >>> >> >>> or would that upset any of you....??<br>
>>> >>> >> >>><br>
>>> >>> >> >>> Thanks for any feedback,<br>
>>> >>> >> >>> David Cole<br>
>>> >>> >> >>> Kitware, Inc.<br>
>>> >>> >> >>><br>
>>> >>> >> >>> On Sat, Aug 9, 2008 at 12:59 PM, Peter Wainwright<br>
>>> >>> >> >>> <<a href="mailto:prw@ceiriog.eclipse.co.uk" target="_blank">prw@ceiriog.eclipse.co.uk</a>> wrote:<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> On all recent CVS versions of VTK, I have been unable to run<br>
>>> >>> >> >>>> this<br>
>>> >>> >> >>>> example<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> <a href="http://www.ceiriog.eclipse.co.uk/vtktut6.tcl" target="_blank">http://www.ceiriog.eclipse.co.uk/vtktut6.tcl</a><br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> Its just a simple use of vtkRenderWindowInteractor. But when<br>
>>> >>> >> >>>> I<br>
>>> >>> >> >>>> click<br>
>>> >>> >> >>>> in<br>
>>> >>> >> >>>> the window I am unable to rotate the model and I get the<br>
>>> >>> >> >>>> error<br>
>>> >>> >> >>>> message:<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> ERROR: In<br>
>>> >>> >> >>>> /home/prw/src/VTK-20080806/Rendering/vtkInteractorStyle.cxx,<br>
>>> >>> >> >>>> line 392<br>
>>> >>> >> >>>> vtkInteractorStyleJoystickCamera (0x9543c0): Timer start<br>
>>> >>> >> >>>> failed<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> This seems to relate to the bug<br>
>>> >>> >> >>>> <a href="http://www.vtk.org/Bug/view.php?id=3164" target="_blank">http://www.vtk.org/Bug/view.php?id=3164</a>,<br>
>>> >>> >> >>>> which apparently has not been touched for almost 2 years. It<br>
>>> >>> >> >>>> seems<br>
>>> >>> >> >>>> to<br>
>>> >>> >> >>>> affect the X11 implementation only. Is anyone working on<br>
>>> >>> >> >>>> this?<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> Peter Wainwright<br>
>>> >>> >> >>>><br>
>>> >>> >> >>>> _______________________________________________<br>
>>> >>> >> >>>> vtk-developers mailing list<br>
>>> >>> >> >>>> <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>>> >>> >> >>>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>> >>> >> >>><br>
>>> >>> >> >><br>
>>> >>> >> >><br>
>>> >>> >> >> _______________________________________________<br>
>>> >>> >> >> vtk-developers mailing list<br>
>>> >>> >> >> <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>>> >>> >> >> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>> >>> >> >><br>
>>> >>> >> >><br>
>>> >>> >> > _______________________________________________<br>
>>> >>> >> > vtk-developers mailing list<br>
>>> >>> >> > <a href="mailto:vtk-developers@vtk.org" target="_blank">vtk-developers@vtk.org</a><br>
>>> >>> >> > <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>>> >>> >> ><br>
>>> >>> >><br>
>>> >>> >><br>
>>> >>> >><br>
>>> >>> >> --<br>
>>> >>> >> ___________________________________________<br>
>>> >>> >> Andrew J. P. Maclean<br>
>>> >>> >> Centre for Autonomous Systems<br>
>>> >>> >> The Rose Street Building J04<br>
>>> >>> >> The University of Sydney 2006 NSW<br>
>>> >>> >> AUSTRALIA<br>
>>> >>> >> Ph: +61 2 9351 3283<br>
>>> >>> >> Fax: +61 2 9351 7474<br>
>>> >>> >> URL: <a href="http://www.acfr.usyd.edu.au/" target="_blank">http://www.acfr.usyd.edu.au/</a><br>
>>> >>> >> ___________________________________________<br>
>>> >>> ><br>
>>> >>> ><br>
>>> >><br>
>>> >><br>
>>> ><br>
>><br>
><br>
><br>
</div></div></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div></div>