<div dir="ltr">Actually (and I know this is a really very late reply... sorry) this is not the sort of response I was looking for. However....... if you, or anybody, have time to make fixes for these issues in CVS HEAD, save the output of "cvs commit" when you make the changes and forward it to me.<div>
<br></div><div>I am quite happy to merge any bug fix type changes from CVS HEAD into the VTK-5-2 branch. It's very easy to do if the fix is isolated and independent and if I have the cvs commit output to start with....</div>
<div><br></div><div><br></div><div>Thanks,</div><div>David Cole</div><div><br><br><div class="gmail_quote">On Tue, Jun 17, 2008 at 3:06 PM, John Platt <<a href="mailto:jcplatt@dsl.pipex.com">jcplatt@dsl.pipex.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">Hi,</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">A couple of crashes I had in CVS version </span></font><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">14th Jan 2008</span></font><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">If you try to render the prop assembly
tree vtkActor > vtkPropAssembly > vtkPropAssembly (from leaf to root),
vtkProp3D::PokeMatrix() crashes because this->CachedProp3D is NULL. The tree
vtkActor > vtkPropAssembly renders OK.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">The same problem was reported some years
ago <a href="http://public.kitware.com/pipermail/vtkusers/2002-April/060530.html" target="_blank">http://public.kitware.com/pipermail/vtkusers/2002-April/060530.html</a></span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">In vtkPropAssembly::BuildPaths(), the line</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> path->AddNode(prop,NULL);</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">will always add a null matrix even if the
prop is a vtkProp3D. I have changed this to</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> path->AddNode( prop,
prop->GetMatrix() );</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">and my particular problem is resolved.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">Clipping an unstructured
grid containing (theoretically) more than 8 quadratic hex's with a plane
may fail with an access violation copying the cell data. In practice, at least
24 cells are needed on Win XP and probably many more for nix.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">I think the problem is in
vtkQuadraticHexahedron::Clip() with the call </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">
this->Hex->Clip( , , , , , , this->CellData, cellId, , );</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">this->CellData stores
8 identical copies of the quadratic hex's cell data for each subdivided
linear hex but cellId has a maximum value of the number of cells in the grid
– 1. The access violation occurs in vtkTetra::Clip() in the calls outCD->CopyData()
where an attempt is made to copy cell data for cellId.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">I think the call should
be </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">
this->Hex->Clip( , , , , , , this->CellData, i, , );</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">where 'i' is
the index of the linear hex.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">BUT …</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">I don't understand
why it is necessary to copy the cell data in the first place. I would have
thought that all subdivided cells have the same cell data as the parent. In
this case, dispense with this->CellData and just use</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">
this->Hex->Clip( , , , , , , inCd, cellId, , );</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy">A similar problem may
also exist in vtkQuadraticHexahedron::Contour().</span></font></p>
<p><font size="2" color="navy" face="Arial"><span lang="EN-GB" style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">My apologies if you were not soliciting
this type of response </span></font><font size="2" color="navy" face="Wingdings"><span style="font-size:10.0pt;font-family:Wingdings;color:navy">J</span></font><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">.</span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p><font color="#888888">
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy">John.</span></font></p></font><div><div></div><div class="Wj3C7c">
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p style="margin-left:36.0pt"><font size="2" face="Arial"><span style="font-size:10.0pt;font-family:Arial"> </span></font></p>
<p style="margin-left:36.0pt"><font size="2" face="Arial"><span style="font-size:10.0pt;font-family:Arial"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p><font size="2" color="navy" face="Arial"><span style="font-size:10.0pt;font-family:Arial;color:navy"> </span></font></p>
<p style="margin-left:36.0pt"><font size="2" face="Tahoma"><span style="font-size:10.0pt;font-family:Tahoma">-----Original Message-----<br>
<b><span style="font-weight:bold">From:</span></b> <a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">vtk-developers-bounces@vtk.org</a>
[mailto:<a href="mailto:vtk-developers-bounces@vtk.org" target="_blank">vtk-developers-bounces@vtk.org</a>] <b><span style="font-weight:bold">On
Behalf Of </span></b>David Cole<br>
<b><span style="font-weight:bold">Sent:</span></b> 17 June 2008 14:30<br>
<b><span style="font-weight:bold">To:</span></b> VTK Developers<br>
<b><span style="font-weight:bold">Subject:</span></b> [vtk-developers] VTK 5.2</span></font></p>
<p style="margin-left:36.0pt"><font size="3" face="Times New Roman"><span style="font-size:12.0pt"> </span></font></p>
<p style="margin-right:0cm;margin-bottom:12.0pt;margin-left:36.0pt"><font size="3" face="Times New Roman"><span style="font-size:12.0pt">Hello
VTK developers,<br>
<br>
Yesterday I merged in a handful of changes to the VTK-5-2 branch. Is there
anything else anybody knows about that should be merged to the VTK-5-2 branch
before we build a 5.2.0 release...? Any changes made to CVS HEAD since April 28
when the branch was created that should be merged over?<br>
<br>
Let me know in the next couple of days if there is anything else.<br>
<br>
Thanks,<br>
David Cole<br>
Kitware, Inc.</span></font></p>
</div></div></div>
</div>
</blockquote></div><br></div></div>