You are trying to eliminate warnings, so just change the constants to the correct type to match the methods. That is a no-op as far as everybody else is concerned.<br><br>If you change the signatures of methods unnecessarily, others may have to change their client code to keep pace. (For some clients and some methods this may be a *huge* amount of work.) If there were a "*better*" reason to change the signature, I'd say open it up for discussion, but not just to eliminate warnings.
<br><br>Change the constants unless some other people speak up and disagree with me....<br><br>:-)<br>David Cole<br><br><br><div><span class="gmail_quote">On 8/1/07, <b class="gmail_sendername">Sean McBride</b> <<a href="mailto:sean@rogue-research.com">
sean@rogue-research.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi all,<br><br>I'd like to fix a few compiler warnings related to implicit 64 to 32 bit
<br>conversion. For example in vtkRenderWindow.h:<br><br> vtkSetClampMacro(AnaglyphColorSaturation,float, 0.0, 1.0);<br> vtkGetMacro(AnaglyphColorSaturation,float);<br><br>the variable is float but the constants are double.
<br><br>I could: 1) change the float to double 2) change the consts to 0.0f,<br>1.0f. I seem to remember that in VTK 5 there was a big float->double<br>change. So is solution 1 preferred?<br><br>Thanks,<br><br>--<br>
____________________________________________________________<br>Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>Rogue Research <a href="http://www.rogue-research.com">
www.rogue-research.com</a><br>Mac Software Developer Montréal, Québec, Canada<br><br><br>_______________________________________________<br>vtk-developers mailing list<br><a href="mailto:vtk-developers@vtk.org">
vtk-developers@vtk.org</a><br><a href="http://www.vtk.org/mailman/listinfo/vtk-developers">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br></blockquote></div><br>