[vtk-developers] What is vtkFloatingPointType?

[David Gobbi]

On Wed, Nov 7, 2012 at 2:35 PM, David Cole <david.cole at kitware.com> wrote:
> On Wed, Nov 7, 2012 at 4:28 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>
>> As for the "#define vtkFloatingPointType vtkFloatingPointType", it
>> serves the purpose of allowing people to do this:
>>
>> #ifdef vtkFloatingPointType
>>
>> I'd imagine that there are a few (old) third-party packages that use
>> this ifdef.
>
> If it needs to be kept, we could at least just:
>
>   #define vtkFloatingPointType double
>
> and remove the typedef, couldn't we?
>
> That would get rid of the clang warning. It's a little surprising (to
> me, at least) to see a symbol name that is both a typedef and a
> #define...

That seems like a reasonable solution.   I'd also make it legacy:

#if !defined(VTK_LEGACY_REMOVE)
#define vtkFloatingPointType double
#endif

 - David