[vtk-developers] No new checkins - Dashboards

Bill Hoffman bill.hoffman at kitware.com
Thu Apr 25 10:18:23 EDT 2002


Before checking in code, you should run ctest or an Experimental Dart dashboard.
The Set/Get test calls Set and Get for everything blindly if the functions are on
the class.   This often causes crashes because the object has not been initialized
like the author was expecting.

-Bill Hoffman



At 09:29 AM 4/25/2002 -0700, Dean Inglis wrote:
>Bill,
>
>could you explain to me what was going wrong in vtkImagePlaneWidget.cxx so
>that I won't make the same mistake in future?  I just looked at
>TestSetGet.tcl and not being overly familiar with tcl it appears that for
>every Set... there must be a Get... ?  If so what is the correct way to deal
>with Set Get (pairs) especially if one only wants to offer a Get or one
>needs to implement a Set that has residual effects?  I ahven't come across
>anything about this in the vtk coding standards - perhaps the standards
>could be revised to address this and possibly what a developer should expect
>to encounter with the dashboard/cmake testing process?
>
>regards,
>Dean
>
>> -----Original Message-----
>> From: vtk-developers-admin at public.kitware.com
>> [mailto:vtk-developers-admin at public.kitware.com]On Behalf Of Lorensen,
>> William E (Research)
>> Sent: Thursday, April 25, 2002 5:42 AM
>> To: 'Ken Martin'; Vtk-Developers at Public. Kitware. Com
>> Subject: RE: [vtk-developers] No new checkins - Dashboards
>>
>>
>> I found the TestSetGet culprit and fixed it. It was
>> vtkImagePlaneWidget.cxx
>>
>> Shall I check in my fixes?
>>
>> Bill
>>
>> -----Original Message-----
>> From: Ken Martin [mailto:ken.martin at kitware.com]
>> Sent: Thursday, April 25, 2002 8:35 AM
>> To: Vtk-Developers at Public. Kitware. Com
>> Subject: [vtk-developers] No new checkins - Dashboards
>>
>>
>> Hey folks,
>>
>> The dashboard has slowly degenerated into worse and worse shape. I am
>> asking that people only check in fixes to dashboard problems for the
>> next few days until the dashboard clears up. Each day more and more
>> problems are being introduced many of which running ctest or an
>> experimental dashboard would catch. Either way it has been so long
>> since we have had a green dashboard we need to stop developing and fix
>> things. At the same time please look at the dashboard and see if you
>> have any problems.
>>
>> Thanks
>> Ken
>>
>> --------------------------
>> Ken Martin, PhD
>> Kitware Inc.
>> 518 371-3971 x101
>> 469 Clifton Corporate Pkwy.
>> Clifton Park, NY 12065
>>
>> _______________________________________________
>> vtk-developers mailing list
>> vtk-developers at public.kitware.com
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>> _______________________________________________
>> vtk-developers mailing list
>> vtk-developers at public.kitware.com
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>
>_______________________________________________
>vtk-developers mailing list
>vtk-developers at public.kitware.com
>http://public.kitware.com/mailman/listinfo/vtk-developers 




More information about the vtk-developers mailing list