<div dir="ltr">Hi, looks like I put that line there :) I think I did it in support of the KiwiViewer iOS 2.0 app, where unsigned int indices are guaranteed to be supported. So this line forces unsigned int to be used always, even for small meshes. Additionally, there are a few functions in vesKiwiDataConversionTools that assume unsigned int indices, and will crash otherwise (RemoveSharedTriangleVertices, ComputeWireframeVertexArrays). Those functions were added to support the wireframe shader, a new addition to KiwiViewer 2.0. If you change the variable back to 65536, then you'll get unsigned short indices for small meshes, which would crash if those functions are called. I can't remember why I wrote those functions to use unsigned int instead of writing templated versions (maybe laziness...)<br>
<br>Pat<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 13, 2014 at 8:46 AM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="">On Fri, Jun 13, 2014 at 3:27 AM, Mansoo Kim <span dir="ltr"><<a href="mailto:to.mansoo@gmail.com" target="_blank">to.mansoo@gmail.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi, <span style="font-family:Calibri,sans-serif;font-size:15px">Aashish Chaudhary</span><div>
<font face="Calibri, sans-serif"><span style="font-size:15px"><br></span></font></div><div><font face="Calibri, sans-serif"><span style="font-size:15px">I found what's wrong.</span></font></div>
<div><span style="font-family:Calibri,sans-serif;font-size:15px">The below code have the bug related to this error.</span></div><div><font face="Calibri, sans-serif"><span style="font-size:15px"><br></span></font></div><div>
<font face="Calibri, sans-serif"><span style="font-size:15px"><div>//-----------------------------------------------------------------------------</div><div>vesSharedPtr<vesGeometryData> vesKiwiDataConversionTools::Convert(</div>
<div> vtkPolyData* input)</div><div>{</div><div> const vtkIdType maximumNumberOfPoints = -1;</div><div><br></div><div> if (input->GetNumberOfPoints() > maximumNumberOfPoints) {</div>
<div> return vesKiwiDataConversionTools::GenericConvert<unsigned int>(input);</div><div> }</div><div> else {</div><div> return vesKiwiDataConversionTools::GenericConvert<unsigned short>(input);</div>
<div> }</div><div>}</div><div><br></div><div>maximumNumberOfPoints is set by -1. </div><div>This code always convert indices into "unsigned int" type.</div><div><br></div><div>
Samsung Galaxy S2 may not support unsigned-int-typed indices. So the below function could not draw any triangles.</div><div><br></div><div><div>void vesMapper::drawTriangles(const vesRenderState &renderState,</div>
<div> vesSharedPtr<vesPrimitive> triangles)</div><div>{</div></div><div>......</div><div><div> glDrawElements(triangles->primitiveType(), numberOfIndicesToDraw,</div>
<div> triangles->indicesValueType(), (void*)offset);</div><div>......</div><div>}</div><div><br></div><div>I think you should rewrite maximumNumberOfPoints = -1; into maximumNumberOfPoints = 65536; Then, all vtp data which the number of vertices is smaller than 65K works well on the devices such as S2 which support only short-type index.</div>
</div></span></font></div></div></blockquote><div><br></div></div><div>That is indeed a bug!! Actually I am not sure when it got changed because it was <span style="font-family:Calibri,sans-serif;font-size:15px">maximumNumberOfPoints = 65536. I will fix it. </span></div>
<div><span style="font-family:Calibri,sans-serif;font-size:15px"><br></span></div><div><font face="Calibri, sans-serif"><span style="font-size:15px">Thanks again for this info. Very helpful. </span></font></div><span class="HOEnZb"><font color="#888888"><div>
<font face="Calibri, sans-serif"><span style="font-size:15px"><br>
</span></font></div><div><font face="Calibri, sans-serif"><span style="font-size:15px">- Aashish</span></font></div></font></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><font face="Calibri, sans-serif"><span style="font-size:15px"><div>
<div><br></div><div>Best regards.</div></div></span></font></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-06-06 20:31 GMT+09:00 Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div>On Thu, Jun 5, 2014 at 6:43 PM, Mansoo Kim <span dir="ltr"><<a href="mailto:to.mansoo@gmail.com" target="_blank">to.mansoo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span style="font-size:10pt;font-family:맑은고딕;color:rgb(31,73,125)" lang="EN-US">Hi, </span><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Aashish Chaudhary.</span><br>
<div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><br>
</span></div><div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Is there some progress on this problem?</span></div><div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Please tell me the Git sha of the version of kiwiviewer released at Google Play, which works well on Galaxy S2.</span></div>
</div></blockquote><div><br></div></div><div>We are looking into it. </div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">And, I will try to find the differences between the market-released version and the recent master version.</span></div></div></blockquote><div>
<br></div></div><div> I will see if I can find that out and send it to you. </div><span><font color="#888888"><div><br></div><div>- Aashish</div></font></span><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><br>
</span></div><div><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Thanks in advance,</span></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-05-30 11:59 GMT+09:00 Mansoo Kim <span dir="ltr"><<a href="mailto:to.mansoo@gmail.com" target="_blank">to.mansoo@gmail.com</a>></span>:<div>
<div><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div link="blue" vlink="purple" lang="KO"><div><p class="MsoNormal" style="word-break:break-hangul">
<span style="font-size:10pt;font-family:맑은고딕;color:rgb(31,73,125)" lang="EN-US">Hi, </span><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Aashish Chaudhary.<u></u><u></u></span></p>
<p class="MsoNormal" style="word-break:break-hangul"><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal" style="word-break:break-hangul">
<span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Did you find something wrong with the trace file I sent?<u></u><u></u></span></p><p class="MsoNormal" style="word-break:break-hangul">
<span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">There is a strange thing that the kiwiviewer app which Kitware Inc. distributed through Google Play works well on my Galaxy S2 phone.<u></u><u></u></span></p>
<p class="MsoNormal" style="word-break:break-hangul"><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Do you know what is the difference between two apks?<u></u><u></u></span></p>
<p class="MsoNormal" style="word-break:break-hangul"><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal" style="word-break:break-hangul">
<span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Best Regards,<u></u><u></u></span></p><p class="MsoNormal" style="word-break:break-hangul"><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">Mansoo Kim.<u></u><u></u></span></p>
<p class="MsoNormal" style="word-break:break-hangul"><span style="font-size:10pt;font-family:맑은고딕;color:rgb(31,73,125)" lang="EN-US"><u></u> <u></u></span></p><p class="MsoNormal"><b><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US">From:</span></b><span style="font-size:11pt;font-family:Calibri,sans-serif" lang="EN-US"> Aashish Chaudhary [mailto:<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>] <br>
<b>Sent:</b> Thursday, May 29, 2014 2:18 PM<br><b>To:</b> Mansoo Kim<br><b>Cc:</b> <a href="mailto:ves@public.kitware.com" target="_blank">ves@public.kitware.com</a><br><b>Subject:</b> Re: [Ves] Not displayed all data but cturtle.vtp<u></u><u></u></span></p>
<div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p><div><p class="MsoNormal"><span lang="EN-US">It may be something specific to Galaxy? Is it possible for you to send me the opengl trace for VES? Also, one thing you could possibly do is set the final color in the shader <u></u><u></u></span></p>
<div><p class="MsoNormal"><span lang="EN-US">to something vec4(1.0, 1.0, 1.0, 1.0) and see if something shows up. <u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div>
<div><p class="MsoNormal"><span lang="EN-US">I am running it in Samsung 10 inch without any issues. <u></u><u></u></span></p></div></div><div><p class="MsoNormal" style="margin-bottom:12pt"><span lang="EN-US"><u></u> <u></u></span></p>
<div><p class="MsoNormal"><span lang="EN-US">On Wed, May 28, 2014 at 10:30 PM, Mansoo Kim <<a href="mailto:to.mansoo@gmail.com" target="_blank">to.mansoo@gmail.com</a>> wrote:<u></u><u></u></span></p><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div><div><p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US">I got the clone by doing "git clone git://<a href="http://vtk.org/stage/VES.git" target="_blank">vtk.org/stage/VES.git</a>" and checked by doing "git checkout master"<u></u><u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US">Git Sha will be d1506467aa3c63adceb04ec434868f4c4005ed24<u></u><u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US"><u></u> <u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US">The list of other datasets is like :<u></u><u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US">teapot.vtp, bunny.vtp, visible-woman-hand.vtp, and so on.<u></u><u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US"><u></u> <u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;text-align:justify;line-height:12.6pt;background-color:rgb(250,250,250)"><span style="font-size:9pt;font-family:Arial,sans-serif;color:rgb(51,51,51)" lang="EN-US">- Mason Kim<u></u><u></u></span></p>
</div></div><div><p class="MsoNormal" style="margin-bottom:12pt"><span lang="EN-US"><u></u> <u></u></span></p><div><div><p class="MsoNormal"><span lang="EN-US">2014-05-28 22:22 GMT+09:00 Aashish Chaudhary <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>>:<u></u><u></u></span></p>
</div><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><p class="MsoNormal"><span lang="EN-US">This is odd. what is your GIT sha of VES? Do you see the list of other datasets? <u></u><u></u></span></p>
<div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">- Aashish<u></u><u></u></span></p></div></div><div><div><div><p class="MsoNormal" style="margin-bottom:12pt">
<span lang="EN-US"><u></u> <u></u></span></p><div><div><div><p class="MsoNormal"><span lang="EN-US">On Wed, May 28, 2014 at 4:15 AM, Mansoo Kim <<a href="mailto:to.mansoo@gmail.com" target="_blank">to.mansoo@gmail.com</a>> wrote:<u></u><u></u></span></p>
</div></div><blockquote style="border-style:none none none solid;border-left-color:rgb(204,204,204);border-left-width:1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm"><div><div><div><p class="MsoNormal"><span lang="EN-US">I have just built ves & kiwiviewer on Android as following instructions on <a href="http://www.kitware.com/blog/home/post/642" target="_blank">http://www.kitware.com/blog/home/post/642</a> and <a href="http://www.kitware.com/blog/home/post/546" target="_blank">http://www.kitware.com/blog/home/post/546</a><u></u><u></u></span></p>
<div><p class="MsoNormal"><span lang="EN-US">I successed to generate Kiwiviewer-debug.apk.<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">But, I can see only cturtle.vtp, which have only vertices, and no triangles, no lines. The other data, which have triangles, aren't displayed at all.<u></u><u></u></span></p>
</div><div><p class="MsoNormal"><span lang="EN-US">I can confirm the geometry information by clicking "information" button in the target device.<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div><div><p class="MsoNormal"><span lang="EN-US">My target device is like :<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">- Samsung Galaxy S2<u></u><u></u></span></p></div><div><p class="MsoNormal">
<span lang="EN-US">- Android OS 4.1.2 (SDK level 16)<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">- NDKr9 (Native Level 8)<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div><div><p class="MsoNormal"><span lang="EN-US">How can i fix it?<u></u><u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US">Thanks in advance<u></u><u></u></span></p>
</div><div><p class="MsoNormal"><span lang="EN-US">(P.S. I found similar question "<a href="http://public.kitware.com/pipermail/ves/2014-January/000747.html" target="_blank">http://public.kitware.com/pipermail/ves/2014-January/000747.html</a>" in mail archives. But, there is no information about the result.)<u></u><u></u></span></p>
</div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div><div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div></div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div></div><p class="MsoNormal" style="margin-bottom:12pt"><span lang="EN-US">_______________________________________________<br>Ves mailing list<br><a href="mailto:Ves@public.kitware.com" target="_blank">Ves@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ves" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ves</a><u></u><u></u></span></p></blockquote></div><p class="MsoNormal"><span style="color:rgb(136,136,136)" lang="EN-US"><br>
<br clear="all"><u></u><u></u></span></p><div><p class="MsoNormal"><span style="color:rgb(136,136,136)" lang="EN-US"><u></u> <u></u></span></p></div><p class="MsoNormal"><span style="color:rgb(136,136,136)" lang="EN-US">-- <u></u><u></u></span></p>
<div><p class="MsoNormal"><i><span style="font-family:'Trebuchet MS',sans-serif;color:rgb(136,136,136)" lang="EN-US">| Aashish Chaudhary <br>| Technical Leader <br>| Kitware Inc. </span></i><span style="color:rgb(136,136,136)" lang="EN-US"><u></u><u></u></span></p>
<div><p class="MsoNormal"><i><span style="font-family:'Trebuchet MS',sans-serif;color:rgb(136,136,136)" lang="EN-US">| </span><span style="color:rgb(136,136,136)" lang="EN-US"><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></span></i><span style="color:rgb(136,136,136)" lang="EN-US"><u></u><u></u></span></p>
</div></div></div></div></div></blockquote></div><p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p></div></blockquote></div><p class="MsoNormal"><span lang="EN-US"><br><br clear="all"><u></u><u></u></span></p>
<div><p class="MsoNormal"><span lang="EN-US"><u></u> <span><font color="#888888"><u></u></font></span></span></p></div><span><font color="#888888"><p class="MsoNormal"><span lang="EN-US">-- <u></u><u></u></span></p>
<div><p class="MsoNormal"><i><span style="font-family:'Trebuchet MS',sans-serif" lang="EN-US">| Aashish Chaudhary <br>
| Technical Leader <br>| Kitware Inc. </span></i><span lang="EN-US"><u></u><u></u></span></p><div><p class="MsoNormal"><i><span style="font-family:'Trebuchet MS',sans-serif" lang="EN-US">| </span><span lang="EN-US"><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></span></i><span lang="EN-US"><u></u><u></u></span></p>
</div></div></font></span></div></div></div></div></div></blockquote></div></div></div><span><font color="#888888"><br></font></span></div><span><font color="#888888">
</font></span></blockquote></div></div></div><span><font color="#888888"><div><div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="trebuchet ms, sans-serif"><i>| Aashish Chaudhary <br>| Technical Leader <br>
| Kitware Inc. <br>
</i></font><div><i><font face="trebuchet ms, sans-serif">| </font><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></i></div>
</div>
</div></div></font></span></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div></div></div><div><div class="h5"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="trebuchet ms, sans-serif"><i>| Aashish Chaudhary <br>| Technical Leader <br>| Kitware Inc. <br>
</i></font><div><i><font face="trebuchet ms, sans-serif">| </font><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></i></div>
</div>
</div></div></div></div>
<br>_______________________________________________<br>
Ves mailing list<br>
<a href="mailto:Ves@public.kitware.com">Ves@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ves" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ves</a><br>
<br></blockquote></div><br></div>