<div dir="ltr">Thanks for catching the bug! I suppose it should escape everything, do you agree? All those characters are going into a url.<br><div class="gmail_extra"><br></div><div class="gmail_extra">Pat<br></div><div class="gmail_extra">
<br><div class="gmail_quote">On Thu, Apr 4, 2013 at 8:36 AM, David Thompson <span dir="ltr"><<a href="mailto:david.thompson@kitware.com" target="_blank">david.thompson@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I've run into an issue with some code I stole from vesMidasClient... it appears that vesMidasClient::renewToken() does not escape the API key (or any other parameters sent to request()). So, if you are unlucky, your Midas API key contains a plus sign ('+') and the server will unescape it into a space. That will prevent MIDAS from authenticating.<br>
<br>
I'm happy to push a fix, but am curious whether vesMidasClient::request() should just escape all of the parameters it is given or whether to manually escape only some parameters like the API key... Any opinions?<br>
<br>
Thanks,<br>
David<br>
_______________________________________________<br>
Ves mailing list<br>
<a href="mailto:Ves@public.kitware.com">Ves@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ves" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ves</a><br>
</blockquote></div><br></div></div>