[Ves] vesMidasClient not escaping form data

David Thompson david.thompson at kitware.com
Thu Apr 4 01:34:18 EDT 2013


> Thanks for catching the bug!  I suppose it should escape everything, do you agree?  All those characters are going into a url.

I've looked into it a little more and agree; POSTed form data should be encoded as "application/x-www-form-urlencoded" just like GET requests:
	http://www.w3.org/MarkUp/html-spec/html-spec_8.html
I was worried about accidentally encoding binary data, but the CURLOPT_COPYPOSTFIELDS option will never POST using "multipart/formdata" encodings.

I'll push a fix tomorrow to next (or do we have Gerrit set up yet?).

	David


More information about the Ves mailing list