<div dir="ltr">Results are now significantly better! Thank you!<div><br></div><div>I am committing now.</div><div><br></div><div>Stephen</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 26, 2013 at 8:10 AM, Stephen Aylward <span dir="ltr"><<a href="mailto:stephen.aylward@kitware.com" target="_blank">stephen.aylward@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Again you have found a bug.<br>
<br>
I am testing and then will commit the fix you suggested.<br>
<br>
Thank you!<br>
Stephen<br>
<br>
<br>
On Mon, Nov 25, 2013 at 6:33 PM, kenichiro yoshimi<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:rccm.kyoshimi@gmail.com">rccm.kyoshimi@gmail.com</a>> wrote:<br>
> Hi Stephen,<br>
><br>
> Probably In my case, HDCS enhancing might work well with the modification to<br>
> itktubeAnisotropicHybridDiffusionImageFilter.hxx as described below. But, I<br>
> don't know whether this change is valid or not.<br>
><br>
> l. 327<br>
> EigenVectorMatrixType eigenVectorMatrix;<br>
> ==><br>
> EigenVectorMatrixType eigenVectorMatrix = eigenVectorImageIterator.Get();<br>
><br>
> Thanks a lot,<br>
> yoshimi<br>
><br>
><br>
> 2013/11/25 kenichiro yoshimi <<a href="mailto:rccm.kyoshimi@gmail.com">rccm.kyoshimi@gmail.com</a>><br>
>><br>
>> Hi Stephen,<br>
>><br>
>> Today, I could confirm that HDCS enhancing works, by setting the<br>
>> particular parameters (EED Contrast (1.0), CED Contrast (1.0) and Hybrid<br>
>> Contrast(1.0)) to testing case. Now I'm trying in my cases. Then I meet the<br>
>> failure to sort eigenvalues in<br>
>> "itktubeAnisotropicHybridDiffusionImageFilter.hxx". The following codes may<br>
>> be wrong:<br>
>><br>
>> l. 216:<br>
>> if( vnl_math_abs( eigenValue[i] > largest ) )<br>
>> ==> if( vnl_math_abs( eigenValue[i] ) > largest )<br>
>><br>
>> l.226:<br>
>> if( eigenValue[i] != smallest && eigenValue[i] != largest )<br>
>> ==> if( vnl_math_abs( eigenValue[i] ) != smallest &&<br>
>> vnl_math_abs( eigenValue[i] ) != largest )<br>
>><br>
>> Could you please confirm this?<br>
>><br>
>> Thanks,<br>
>> yoshimi<br>
>><br>
>><br>
>> 2013/11/21 kenichiro yoshimi <<a href="mailto:rccm.kyoshimi@gmail.com">rccm.kyoshimi@gmail.com</a>><br>
>>><br>
>>> Hi Stephen,<br>
>>><br>
>>> Thank you for your kind advice.<br>
>>><br>
>>> Following your instructions, I build a "Experimental" project, but the<br>
>>> tests may not run. Then I obtain the build log as:<br>
>>><br>
>>> 1>------ Build : Project: Experimental, Release x64 ------<br>
>>> 1> Site: YOSHIMI<br>
>>> 1> Build name: Win32-vs9<br>
>>> 1>Create new tag: 20131120-2346 - Experimental<br>
>>> 1>Configure project<br>
>>> 1> Each . represents 1024 bytes of output<br>
>>> 1> . Size of output: 0K<br>
>>> 1>Build project<br>
>>> 1> Each symbol represents 1024 bytes of output.<br>
>>> 1> '!' represents an error and '*' a warning.<br>
>>> 1> ......... Size of output: 8K<br>
>>> 1> 0 Compiler errors<br>
>>> 1> 0 Compiler warnings<br>
>>> 1>Test project G:/work/kitware/build/TubeTK<br>
>>> 1>No tests were found!!!<br>
>>> 1>Performing coverage<br>
>>> 1> Cannot find any coverage files. Ignoring Coverage request.<br>
>>> 1>Submit files (using http)<br>
>>> 1> Using HTTP submit method<br>
>>> 1> Drop site:<a href="http://open.cdash.org/submit.php?project=TubeTK" target="_blank">http://open.cdash.org/submit.php?project=TubeTK</a><br>
>>> 1> Uploaded:<br>
>>> G:/work/kitware/build/TubeTK/Testing/20131120-2346/Build.xml<br>
>>> 1> Uploaded:<br>
>>> G:/work/kitware/build/TubeTK/Testing/20131120-2346/Configure.xml<br>
>>> 1> Uploaded:<br>
>>> G:/work/kitware/build/TubeTK/Testing/20131120-2346/Test.xml<br>
>>> 1> Submission successful<br>
>>><br>
>>> I am attaching the CMakeCache.txt file for the building TubeTK. I<br>
>>> appreciate if you would point out what I was doing wrong.<br>
>>><br>
>>> Thanks,<br>
>>> yoshimi<br>
>>><br>
>>><br>
>>> 2013/11/20 Stephen Aylward <<a href="mailto:stephen.aylward@kitware.com">stephen.aylward@kitware.com</a>><br>
>>>><br>
>>>> Hi,<br>
>>>><br>
>>>> Sorry that you are having troubles.<br>
>>>><br>
>>>> When you build using windows, there should be a build target/project<br>
>>>> called "Experimental" that you can build from within Visual Studio<br>
>>>> 2008. Please try building that project. It should cause all of the<br>
>>>> tests to run. Please let me know if there are failures.<br>
>>>><br>
>>>> Thanks,<br>
>>>> Stephen<br>
>>>><br>
>>>><br>
>>>> On Wed, Nov 20, 2013 at 6:36 AM, kenichiro yoshimi<br>
>>>> <<a href="mailto:rccm.kyoshimi@gmail.com">rccm.kyoshimi@gmail.com</a>> wrote:<br>
>>>> > Hi Stephen,<br>
>>>> ><br>
>>>> > Thanks for your reply.<br>
>>>> > I build TubeTK with Visual Studio 2008, but I don't know the way to<br>
>>>> > run the<br>
>>>> > tests. So, I write the program that is the same as<br>
>>>> > "itktubeAnisotropicHybridDiffusionImageFilterTest.cxx" and run with<br>
>>>> > the<br>
>>>> > testing data. The result has no error, but the output image data is<br>
>>>> > the same<br>
>>>> > as input data just like using Slicer plugin.<br>
>>>> ><br>
>>>> > My Slicer versioin is 4.3.1-2013-11-07 r22692 64 bit. My system is<br>
>>>> > Windows 8<br>
>>>> > 64bit.<br>
>>>> ><br>
>>>> > Best regards,<br>
>>>> > yoshimi<br>
>>>> ><br>
>>>> ><br>
>>>> > 2013/11/19 Stephen Aylward <<a href="mailto:stephen.aylward@kitware.com">stephen.aylward@kitware.com</a>><br>
>>>> >><br>
>>>> >> Hi Kenichiro,<br>
>>>> >><br>
>>>> >> Thank you for trying TubeTK.<br>
>>>> >><br>
>>>> >> How did you install the TubeTK extensions? If you compiled them,<br>
>>>> >> then<br>
>>>> >> I would like you to run the tests on your local build, and see if<br>
>>>> >> they<br>
>>>> >> pass. As you said, we use that data in testing, and so if the tests<br>
>>>> >> pass, then the integration into Slicer is the problem. If the tests<br>
>>>> >> fail, then the build of TubeTK is the problem.<br>
>>>> >><br>
>>>> >> Also, what version of Slicer are you using?<br>
>>>> >><br>
>>>> >> Thanks,<br>
>>>> >> Stephen<br>
>>>> >><br>
>>>> >><br>
>>>> >> On Mon, Nov 11, 2013 at 6:31 AM, kenichiro yoshimi<br>
>>>> >> <<a href="mailto:rccm.kyoshimi@gmail.com">rccm.kyoshimi@gmail.com</a>> wrote:<br>
>>>> >> > Dear all,<br>
>>>> >> ><br>
>>>> >> > I'm trying to use the Slicer plugin filter named "Hybrid Enhancing<br>
>>>> >> > Anisotropic Diffusion with Continuous Switch (TubeTK)". But it does<br>
>>>> >> > not<br>
>>>> >> > reflect even if I specify various parameters. I try to apply it to<br>
>>>> >> > CroppedWholeLungCTScan.mhd which is used for testing framework.<br>
>>>> >> ><br>
>>>> >> > Can someone help me in getting this to work?<br>
>>>> >> ><br>
>>>> >> > Cheers,<br>
>>>> >> > yoshimi<br>
>>>> >> ><br>
>>>> >> > _______________________________________________<br>
>>>> >> > Tubetk-developers mailing list<br>
>>>> >> > <a href="mailto:Tubetk-developers@tubetk.org">Tubetk-developers@tubetk.org</a><br>
>>>> >> ><br>
>>>> >> > <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/tubetk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/tubetk-developers</a><br>
>>>> >> ><br>
>>>> >><br>
>>>> >><br>
>>>> >><br>
>>>> >> --<br>
>>>> >><br>
>>>> >> ====================================================<br>
>>>> >> Stephen R. Aylward, Ph.D.<br>
>>>> >> Senior Director of Operations, North Carolina, Kitware, Inc.<br>
>>>> >> <a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>
>>>> >> <a href="http://www.aylward.org" target="_blank">http://www.aylward.org</a><br>
>>>> >> <a href="tel:%28919%29%20969-6990%20x300" value="+19199696990">(919) 969-6990 x300</a><br>
>>>> >> ====================================================<br>
>>>> ><br>
>>>> ><br>
>>>><br>
>>>><br>
>>>><br>
>>>> --<br>
>>>><br>
>>>> ====================================================<br>
>>>> Stephen R. Aylward, Ph.D.<br>
>>>> Senior Director of Operations, North Carolina, Kitware, Inc.<br>
>>>> <a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>
>>>> <a href="http://www.aylward.org" target="_blank">http://www.aylward.org</a><br>
>>>> <a href="tel:%28919%29%20969-6990%20x300" value="+19199696990">(919) 969-6990 x300</a><br>
>>>> ====================================================<br>
>>><br>
>>><br>
>><br>
><br>
<br>
<br>
<br>
--<br>
<br>
====================================================<br>
Stephen R. Aylward, Ph.D.<br>
Senior Director of Operations, North Carolina, Kitware, Inc.<br>
<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br>
<a href="http://www.aylward.org" target="_blank">http://www.aylward.org</a><br>
<a href="tel:%28919%29%20969-6990%20x300" value="+19199696990">(919) 969-6990 x300</a><br>
====================================================<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><br>====================================================<br>Stephen R. Aylward, Ph.D.<br>Senior Director of Operations, North Carolina, Kitware, Inc.<br>
<a href="http://www.kitware.com" target="_blank">http://www.kitware.com</a><br><a href="http://www.aylward.org" target="_blank">http://www.aylward.org</a><br>(919) 969-6990 x300<br>====================================================
</div>