<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I think we should just move both pugiXML and this into the superbuild - SMTK will need a find pugiXML and find nlohmann_JSON methods but since both of these are simple header only projects I don’t this will cause non-superbuild developers any headaches in terms of “installing” them. This solves the external issues, doesn’t require any macros, simplifies the SMTK’s third party directory, and no issue with clang-format. <div class=""><br class=""></div><div class="">Bob</div><div class=""><br class=""><div class="">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Robert M. O'Bara, MEng.<br class="">Assistant Director of Scientific Computing<br class=""><br class="">Kitware Inc.<br class="">28 Corporate Drive<br class="">Suite 101<br class="">Clifton Park, NY 12065<br class=""><br class="">Phone: (518) 881- 4931</div><div class=""><br class=""></div></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Sep 14, 2017, at 11:19 AMEDT, Haocheng Liu <<a href="mailto:haocheng.liu@kitware.com" class="">haocheng.liu@kitware.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Thu, Sep 14, 2017 at 10:52 AM, David Thompson<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:david.thompson@kitware.com" target="_blank" class="">david.thompson@kitware.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="auto" class=""><div class=""></div><div class="">I think since it is header-only that we would not need to mangle it, but rather install it inside the smtk include tree (e.g., include/smtk/thirdparty/<wbr class="">nlohmann_json) so that others can use exactly the version SMTK is compiled with. We can define a macro (yes!) for nlohmann's include path so that it is possible to use an external version or third party version:</div><div class=""><br class=""></div></div></blockquote><div class="">Not a lover for MACRO:( I vote for a tarball in superbuild or a submodule of SMTK.</div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="auto" class=""><div class=""></div><div class="">#include "smtk/Options.h"</div><div class="">#include SMTK_NLOHMANN_JSON_H</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class=""> <span class="Apple-converted-space"> </span>David</div></font></span><div class=""><div class="h5"><div class=""><br class="">On Sep 14, 2017, at 10:44, Bob Obara <<a href="mailto:bob.obara@kitware.com" target="_blank" class="">bob.obara@kitware.com</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class="">I definitely like the nlohmann version better - did we determine if we need to mangle it? <div class=""><br class=""></div><div class="">So should it and pugiXML be moved into the superbuild in the near future as external projects?</div><div class=""><br class=""></div><div class="">Bob</div><div class=""><br class=""><div class=""><span style="text-align: -webkit-auto;" class=""><br class=""></span></div><div class=""><span style="text-align: -webkit-auto;" class="">Robert M. O'Bara, MEng.</span><div class=""><div style="font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-variant-east-asian: normal; font-variant-position: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; word-wrap: break-word;" class=""><div class="">Assistant Director of Scientific Computing<br class=""><br class="">Kitware Inc.<br class="">28 Corporate Drive<br class="">Suite 101<br class="">Clifton Park, NY 12065<br class=""><br class="">Phone:<span class="Apple-converted-space"> </span><a href="tel:(518)%20881-4931" value="+15188814931" target="_blank" class="">(518) 881- 4931</a></div><div class=""><br class=""></div></div><br class="m_1346144913264093536Apple-interchange-newline"><br class="m_1346144913264093536Apple-interchange-newline"></div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Sep 13, 2017, at 5:37 PMEDT, David Thompson <<a href="mailto:david.thompson@kitware.com" target="_blank" class="">david.thompson@kitware.com</a>> wrote:</div><br class="m_1346144913264093536Apple-interchange-newline"><div class=""><div class="">Hi all,<br class=""><br class="">I've looked a little more into jsoncpp and nlohmann_json. Attached is my experiment with syntax and getting UUIDs and arrays of UUIDs serialized. nlohmann does not require calls to converter functions nor does it even require a converter... UUIDs just worked (however, we probably want a converter as its default behavior writes UUIDs as JSON arrays of unsigned integers).<br class=""><br class="">I continue to like nlohmann and dislike jsoncpp in terms of terseness and legibility of the resulting code. The one thing I dislike about nlohmann is that the repo seems to contain super-huge test files, making it slow to clone.<br class=""><br class="">Attached are example programs for each library that do the same thing (create JSON data including UUIDs). I have not tried parsing/dumping large objects.<br class=""><br class=""><span class="m_1346144913264093536Apple-tab-span" style="white-space: pre-wrap;"> </span>David<br class=""><br class=""><br class=""><span id="m_1346144913264093536cid:C08336A6-5EC2-4137-A093-B373CA5683FC@kitware.com" class=""><json.tar.gz></span></div></div></blockquote></div><br class=""></div></div></div></blockquote></div></div></div><br class="">______________________________<wbr class="">_________________<br class="">Smtk-developers mailing list<br class=""><a href="mailto:Smtk-developers@smtk.org" class="">Smtk-developers@smtk.org</a><br class=""><a href="http://public.kitware.com/mailman/listinfo/smtk-developers" rel="noreferrer" target="_blank" class="">http://public.kitware.com/<wbr class="">mailman/listinfo/smtk-<wbr class="">developers</a><br class=""><br class=""></blockquote></div><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br clear="all" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_signature" data-smartmail="gmail_signature" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr" class=""><div class=""><div dir="ltr" class="">Best regards<div class="">Haocheng</div><div class=""><br class=""></div><div class="">Haocheng LIU</div><div class=""><span style="font-size: 12.8px;" class="">Kitware, Inc.</span><br style="font-size: 12.8px;" class=""><span style="font-size: 12.8px;" class="">R&D Engineer</span><br style="font-size: 12.8px;" class=""><span style="font-size: 12.8px;" class="">21 Corporate Drive</span><br style="font-size: 12.8px;" class=""><span style="font-size: 12.8px;" class="">Clifton Park, NY 12065-8662</span><br style="font-size: 12.8px;" class=""><span style="font-size: 12.8px;" class="">Phone: </span><a href="tel:(518)%20881-4421" value="+15188814443" target="_blank" style="color: rgb(17, 85, 204); font-size: 12.8px;" class="">518-881-4421</a></div></div></div></div></div></div></blockquote></div><br class=""></div></body></html>