<div dir="ltr"><div>We found the bug :) a strcmp != 0 was replaced by a std::string == std::string!!! Ben will be chasten for this! ;)<br></div><br><div class="gmail_extra"><br><div class="gmail_quote">2015-11-25 10:24 GMT+01:00 Mathieu Westphal <span dir="ltr"><<a href="mailto:mathieu.westphal@kitware.com" target="_blank">mathieu.westphal@kitware.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Ben<br><br></div>I'e bissecting the commit and found the cullprint, looks like this one breaks it :<br><a href="https://gitlab.kitware.com/vtk/vtk/commit/68c3cc53e47c30e7ef8a74fa2b40ced0f234834c" target="_blank">https://gitlab.kitware.com/vtk/vtk/commit/68c3cc53e47c30e7ef8a74fa2b40ced0f234834c</a><span class="HOEnZb"><font color="#888888"><br><br></font></span></div><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div><div><div dir="ltr">Mathieu Westphal<br></div></div></div></font></span><div><div class="h5">
<br><div class="gmail_quote">On Tue, Nov 24, 2015 at 7:13 PM, David Gobbi <span dir="ltr"><<a href="mailto:david.gobbi@gmail.com" target="_blank">david.gobbi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Mathieu,</div><div><br></div><div>The errors look similar to ones that were fixed by this commit:</div><a href="https://gitlab.kitware.com/paraview/paraview/commit/8a6e6fe9" target="_blank">https://gitlab.kitware.com/paraview/paraview/commit/8a6e6fe9</a><div><br></div><div>At the very root, bugs such as the ones fixed by the above commit</div><div>are caused by type checks of the form "type{x) == y". Such type</div><div>checks should almost always be replaced by calls to "isinstance()"</div><div>or "issubclass()".</div><div><br></div><div>I did a quick grep through the ParaView source code to find places</div><div>where type() is being used to do type checks, and I found several.</div><div>I'm pretty sure that at least some of these are bugs:</div><div><br></div><div><div>Wrapping/Python/paraview/coprocessing.py:54: if type(frequencies) != dict:</div><div>Wrapping/Python/paraview/data_exploration.py:204: if type(value) == type("String"):</div><div>Wrapping/Python/paraview/extract_selection.py:88: (query, type(maskArray))</div><div>Wrapping/Python/paraview/servermanager.py:654: if not type(self) is Property:</div><div>Wrapping/Python/paraview/servermanager.py:671: if type(self) is Property:</div><div>Wrapping/Python/paraview/servermanager.py:888: if type(value) == str:</div><div>Wrapping/Python/paraview/servermanager.py:2295: elif type(arg1) is types.IntType:</div><div>Wrapping/Python/paraview/servermanager.py:3038: if not type(val) == int:</div><div>Wrapping/Python/paraview/simple.py:740: if type(filename) == list:</div><div>Wrapping/Python/paraview/smtrace.py:397: if not type(prop) == sm.Property:</div><div>Wrapping/Python/paraview/smtrace.py:490: assert type(propertyname) == str</div><div>Wrapping/Python/paraview/smtrace.py:1112: return "'%s'" % x if type(x) == str else x</div><div>Web/Applications/FileViewer/server/pv_web_file_loader.py:136: if type(files) == list:</div><div>Web/Python/paraview/web/helper.py:249: if type(data) in allowedTypes:</div><div>Web/Python/paraview/web/helper.py:272: elif type(prop) == ProxyProperty:</div><div>Web/Python/paraview/web/helper.py:297: if property.GetDomain('proxy_list') and len(value) == 1 and type(value[0]) == str:</div><div>Web/Python/paraview/web/helper.py:315: if type(value) == unicode:</div><div>Web/Python/paraview/web/helper.py:317: if type(value) == list:</div><div>Web/Python/paraview/web/helper.py:349: if type(proxy.GetProperty(property)) == ProxyProperty:</div><div>Web/Python/paraview/web/protocols.py:1192: if type(prop) == ProxyProperty or type(prop) == InputProperty:</div><div>Web/Python/paraview/web/protocols.py:1590: if type(relativePath) == list:</div><div>Web/Python/paraview/web/protocols.py:1933: if type(relativePath) == list:</div><div>Web/Python/paraview/web/protocols.py:1962: if type(lut['name']) == unicode:</div><div>Web/Python/paraview/web/pv_web_catalyst.py:202: if type(files) == list:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:54: elif type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:74: if type(array1) == dsa.VTKCompositeDataArray and type(val2) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:83: elif type(array1) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:112: if type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:132: if type(ds) == dsa.CompositeDataSet:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:176: if type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:341: t = type(array)</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:700: if type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:727: if type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:753: if type(array) == dsa.VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/algorithms.py:776: if type(arrayx) == dsa.VTKCompositeDataArray and type(arrayy) == dsa.VTKCompositeDataArray and (type(arrayz) == dsa.VTKCompositeDataArray or arrayz is None):</div><div>VTK/Wrapping/Python/vtk/numpy_interface/dataset_adapter.py:515: if type(index) == VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/dataset_adapter.py:534: if type(other) == VTKCompositeDataArray:</div><div>VTK/Wrapping/Python/vtk/numpy_interface/dataset_adapter.py:555: if type(other) == VTKCompositeDataArray:</div></div><div><br></div><div> - David</div><div><div><div><br></div><div><br></div><div><br></div><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 24, 2015 at 4:04 AM, Mathieu Westphal <span dir="ltr"><<a href="mailto:mathieu.westphal@kitware.com" target="_blank">mathieu.westphal@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hello<div><br></div><div>I am trying to update VTK in ParaView in order to integrate my GIL ensured changes, but a lot of python Tests are failing with paraview, with the following error :</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:monospace;font-size:14px;white-space:pre-wrap">Traceback (most recent call last):
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/source/ParaViewCore/ServerManager/Default/Testing/Python/MultiView.py", line 9, in <module>
Show()
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/build/lib/site-packages/paraview/simple.py", line 400, in Show
rep = controller.Show(proxy, proxy.Port, view)
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/build/lib/site-packages/paraview/servermanager.py", line 158, in __getattr__
return getattr(self.SMController, name)
AttributeError: 'vtkPVServerManagerCorePython.vtkSMParaViewPipeline' object has no attribute 'Show'
Traceback (most recent call last):
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/source/ParaViewCore/ServerManager/Default/Testing/Python/MultiView.py", line 9, in <module>
Show()
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/build/lib/site-packages/paraview/simple.py", line 400, in Show
rep = controller.Show(proxy, proxy.Port, view)
File "/home/kitware/Dashboards/buildslave/paraview-amber8-linux-static-release_mpi_osmesa_python/build/lib/site-packages/paraview/servermanager.py", line 158, in __getattr__
return getattr(self.SMController, name)
AttributeError: 'vtkPVServerManagerCorePython.vtkSMParaViewPipeline' object has no attribute 'Show'
</span></div><div><span style="color:rgb(0,0,0);font-family:monospace;font-size:14px;white-space:pre-wrap"><br></span></div><div><br></div><div><a href="https://open.cdash.org/index.php?compare1=63&filtercount=2&field1=buildname%2Fstring&project=ParaView&field2=buildstarttime%2Fdate&showfilters=0&limit=100&compare2=83&value1=dbdbee7a&showfeed=0&value2=20151124T043202" target="_blank">https://open.cdash.org/index.php?compare1=63&filtercount=2&field1=buildname%2Fstring&project=ParaView&field2=buildstarttime%2Fdate&showfilters=0&limit=100&compare2=83&value1=dbdbee7a&showfeed=0&value2=20151124T043202</a><br></div><div><br></div><div><a href="https://gitlab.kitware.com/paraview/paraview/merge_requests/329#note_47210" target="_blank">https://gitlab.kitware.com/paraview/paraview/merge_requests/329#note_47210</a><br></div><div><br></div><div><br></div><div>I Suspect it is because of a VTK commit, and i will try to recreate it locally by only updating VTK and bisecting the commits.</div><div><br></div><div>But if anyone has an idea about it, that would be nice.</div><span><font color="#888888"><div><br></div><div>Mathieu Westphal</div></font></span></div></blockquote></div><br></div></div></div></div></div>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=Paraview-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=Paraview-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/paraview-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/paraview-developers</a><br>
<br></blockquote></div><br></div></div>