<div dir="ltr">Ahhhh! If a filter has RequestData(), which does not call another method such as Execute() or ExecuteData(), it is 100% safe to remove those. Only RequestData() would be called by the superclass and any other method that were there for legacy reasons will never get called. Sorry for being dense :-)<div><br></div><div>-berk</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 1, 2015 at 2:23 AM, Schlottke, Michael <span dir="ltr"><<a href="mailto:M.Schlottke@aia.rwth-aachen.de" target="_blank">M.Schlottke@aia.rwth-aachen.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
The filter *does* something in RequestData, but the Execute() method is a stub (probably implemented back when it still carried some purpose and never removed).
<div><br>
</div>
<div>I was asking because I’ve already encountered the situation once before that the removal of a (trivial) virtual method caused the parent class method to change the observable behavior in unexpected ways. A quick search of the current VTK sources,
however, seems to indicate that the Execute() method is not used anywhere anymore, so I guess I should be safe.</div><span class="HOEnZb"><font color="#888888">
<div><br>
</div>
<div>Michael</div></font></span><div><div class="h5">
<div><br>
<div>
<blockquote type="cite">
<div>On 30 Apr 2015, at 22:58 , Berk Geveci <<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">Hi Michael,
<div><br>
</div>
<div>If it is no-op, by all means remove it. What is the purpose of this filter, if it pretty much does nothing? :-)</div>
<div><br>
</div>
<div>-berk</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Apr 30, 2015 at 1:12 AM, Schlottke, Michael <span dir="ltr">
<<a href="mailto:M.Schlottke@aia.rwth-aachen.de" target="_blank">M.Schlottke@aia.rwth-aachen.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hi Berk,
<div><br>
</div>
<div>Thank you for your answer. What do you mean by “minor changes” (other than that I somehow have to obtain the correct output pointer)? And do I really need to pass data to Execute()? As far as I can tell, the particular filter I’m looking at does
nothing in Execute() (really a no-op), so it seems like a good candidate to be removed completely.</div>
<div><br>
</div>
<div>Michale</div>
<div>
<div>
<div><br>
<div>
<blockquote type="cite">
<div>On 28 Apr 2015, at 15:52 , Berk Geveci <<a href="mailto:berk.geveci@kitware.com" target="_blank">berk.geveci@kitware.com</a>> wrote:</div>
<br>
<div>
<div dir="ltr">Hi Michael,
<div><br>
</div>
<div>You will need some minor changes but yes you can move that to RequestData(). You will have to pass the input and output to Execute() somehow.</div>
<div><br>
</div>
<div>Best,</div>
<div>-berk</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Apr 28, 2015 at 5:37 AM, Schlottke, Michael <span dir="ltr">
<<a href="mailto:M.Schlottke@aia.rwth-aachen.de" target="_blank">M.Schlottke@aia.rwth-aachen.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div>Hi again,</div>
<div><br>
</div>
<div>I am trying to follow the VTK guide (<a href="http://www.vtk.org/Wiki/VTK/VTK_6_Migration/Removal_of_Execute" target="_blank">http://www.vtk.org/Wiki/VTK/VTK_6_Migration/Removal_of_Execute</a>) on migrating a set of ParaView plugins from
VTK 5 to VTK 6.</div>
<div><br>
</div>
<div>Just to be sure, what would be the correct way to replace the following implementation:</div>
<div><br>
</div>
<div>/////////////////////////////////////////////////////////////////////////</div>
<div>
<div>void vtkMyAlgorithmSubclass::ExecuteData(vtkDataObject *output) </div>
<div>{ </div>
<div> if (output && this->UpdateExtentIsEmpty(output)) </div>
<div> { </div>
<div> output->Initialize(); </div>
<div> return; </div>
<div> } </div>
<div> </div>
<div> this->Execute(); </div>
<div>}</div>
</div>
<div>/////////////////////////////////////////////////////////////////////////</div>
<div><br>
</div>
<div>Can I just move this whole code into RequestData (and use the vtkDataObject* output as a downcast from my output info object)? Is the call to Execute() still needed in this case?</div>
<div><br>
</div>
<div>Thanks!</div>
<div><br>
</div>
<div>Michael</div>
<br>
<br>
<div><span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<div style="word-wrap:break-word">--<br>
Michael Schlottke<br>
<br>
Chair of Fluid Mechanics and Institute of Aerodynamics<br>
RWTH Aachen University<br>
Wüllnerstraße 5a<br>
52062 Aachen<br>
Germany<br>
<br>
Phone: <a href="tel:%2B49%20%28241%29%2080%2095188" value="+492418095188" target="_blank">
+49 (241) 80 95188</a><br>
Fax: <a href="tel:%2B49%20%28241%29%2080%2092257" value="+492418092257" target="_blank">
+49 (241) 80 92257</a><br>
Mail: <a href="mailto:m.schlottke@aia.rwth-aachen.de" target="_blank">m.schlottke@aia.rwth-aachen.de</a><br>
Web: <a href="http://www.aia.rwth-aachen.de/" target="_blank">http://www.aia.rwth-aachen.de</a></div>
</span></div>
<br>
</div>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com/" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=Paraview-developers" target="_blank">
http://markmail.org/search/?q=Paraview-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/paraview-developers" target="_blank">http://public.kitware.com/mailman/listinfo/paraview-developers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div></div></div>
</blockquote></div><br></div>