We definitely are enforcing 78 character or less as I have had to rebase --amend several commits from others that I cherry-picked onto the release branch and then tried to push to origin.<br><br><div class="gmail_quote">On Fri, Apr 23, 2010 at 2:17 PM, Berk Geveci <span dir="ltr"><<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I was just describing the conversation I had with Brad. The idea was<br>
to have checks only for things that screwed up the history (like<br>
merging from next to master) or possibly things that could corrupt<br>
people's repositories (I believe an example for that was screwed up<br>
line feed). We were not supposed to have commit checks for anything<br>
you listed. I somehow don't believe that we are enforcing 79 character<br>
or less. If we are, we should stop. Same with trailing white spaces.<br>
<br>
Brad, can you chime in here please.<br>
<font color="#888888"><br>
-berk<br>
</font><div><div></div><div class="h5"><br>
On Fri, Apr 23, 2010 at 1:42 PM, Moreland, Kenneth <<a href="mailto:kmorel@sandia.gov">kmorel@sandia.gov</a>> wrote:<br>
> That doesn’t make any sense Berk. As it is, there already exists several<br>
> hooks that restrict the commits that you can place, so the problem you<br>
> describe can already happen as it is. This is why the advice is to install<br>
> the hooks in your local repository.<br>
><br>
> None of the current checks I found in these hooks are fatal or close to<br>
> fatal. On checks to make sure that there is no whitespace at the end of a<br>
> line. How is that close to fatal? Another makes sure that the first line<br>
> of your commit message is 79 characters or less. Will my web browser die if<br>
> it encounters an 80 character commit message?<br>
><br>
> I consider tab removal more important than those other hooks. It’s also a<br>
> lot easier to comply with than trailing whitespace.<br>
><br>
> -Ken<br>
><br>
><br>
> On 4/23/10 6:07 AM, "Berk Geveci" <<a href="mailto:berk.geveci@kitware.com">berk.geveci@kitware.com</a>> wrote:<br>
><br>
> I am sure Brad will chime in but here is the reasoning behind not<br>
> having these hooks:<br>
><br>
> Consider the case where you have a branch with 10 commits. Say the 2nd<br>
> one has a tab in it. When you try to push this, your whole push would<br>
> get rejected. Now you have to figure out how to fix the 2nd commt<br>
> while keeping all the commits after that the same. Note that you<br>
> cannot simply fix the problem by making a new commit or a revert<br>
> commit because the hook checks every single commit for problems. Of<br>
> course, fixing the 2nd commit is doable by rewriting history but it is<br>
> not the most straightforward thing to do.<br>
><br>
> So we decided that commit checks would for fatal or close to fatal<br>
> problems and that the other problems would be caught on the dashboard<br>
> so that they can be fixed by later commits.<br>
><br>
> (I disagree with the trailing space check btw. I think it is too<br>
> aggressive. There are many developers that use editors that are not<br>
> very good at not leaving trailing spaces. Forcing everyone to change<br>
> is to invasive)<br>
><br>
> -berk<br>
><br>
><br>
><br>
> On Fri, Apr 23, 2010 at 2:24 AM, Mark Olesen <<a href="mailto:Mark.Olesen@faurecia.com">Mark.Olesen@faurecia.com</a>><br>
> wrote:<br>
>> On Fri, 2010-04-23 at 10:34 +1000, Andrew Maclean wrote:<br>
>>> I agree with you, I think that there also should be a commit check<br>
>>> for tabs, otherwise layout gets really messy.<br>
>><br>
>> What about checking/stripping trailing whitespace as well?<br>
>> This is something else that tends to look messy and result in lots of<br>
>> noisy commits.<br>
>><br>
>> /mark<br>
>><br>
>><br>
>> DISCLAIMER:<br>
>> This electronic transmission (and any attachments thereto) is intended<br>
>> solely for the use of the addressee(s). It may contain confidential or<br>
>> legally privileged information. If you are not the intended recipient of<br>
>> this message, you must delete it immediately and notify the sender. Any<br>
>> unauthorized use or disclosure of this message is strictly prohibited.<br>
>> Faurecia does not guarantee the integrity of this transmission and shall<br>
>> therefore never be liable if the message is altered or falsified nor for any<br>
>> virus, interception or damage to your system.<br>
>><br>
>> _______________________________________________<br>
>> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
>><br>
>><br>
><br>
><br>
><br>
><br>
> **** Kenneth Moreland<br>
> *** Sandia National Laboratories<br>
> ***********<br>
> *** *** *** email: <a href="mailto:kmorel@sandia.gov">kmorel@sandia.gov</a><br>
> ** *** ** phone: (505) 844-8919<br>
> *** web: <a href="http://www.cs.unm.edu/~kmorel" target="_blank">http://www.cs.unm.edu/~kmorel</a><br>
><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br>