<div dir="ltr">Ben, <div><br></div><div style>There is lot of code form old-workflow. I am thinking that it may be better if you take it out from this branch before it goes to master. </div><div style><br></div><div style>
Do you any strong objections to this? Let me know so that I can merge this in master asap. </div><div style><br></div><div style>Thanks</div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Jul 22, 2013 at 2:47 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Just to be clear, Chris gave the earlier feedback -:) </div><div class="gmail_quote"><br></div><div class="gmail_quote"><div><div class="h5">On Fri, Jul 12, 2013 at 5:49 PM, Ben Burnett <span dir="ltr"><<a href="mailto:benjam.arlyn@gmail.com" target="_blank">benjam.arlyn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">@Aashish: Yes this is just the front end, but there are some backend WIP code on this branch as well from the past.</div>
<div class="gmail_extra"><br><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>- It seems there are some streaming changes as well, such as streamwork.py and archive.js has some websocket stuff added? Should this stuff be added on this branch?</div></blockquote></div><div>I think it came from merging in another branch a while ago, possibly to bring in fixes, but I can't remember exactly. I started adding websocket stuff to archive to try and get the streaming demo working there, but none of it's actually being used, so it should be harmless.</div>
<div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>- What is the license of utils/xml2json.py and web/apps/oldworkflow/hint-textbox.js? Need to be careful about adding non BSD stuff.</div></blockquote></div><div>It has a custom license <a href="https://github.com/hay/xml2json/blob/master/LICENSE" target="_blank">https://github.com/hay/xml2json/blob/master/LICENSE</a>, with the primary piece being "<span style="color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Courier,monospace;font-size:12px;line-height:18px;white-space:pre-wrap">The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." </span></div>
<div>Will this cause problems?</div><div><div></div></div></div></div></div></blockquote><div><br></div></div></div><div>I don;t think so. Its actually a MIT license (<span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px">xml2json is released under the terms of the </span><a href="http://opensource.org/licenses/MIT" style="color:rgb(65,131,196);text-decoration:none;font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px" target="_blank">MIT license</a><span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px">.)</span></div>
<div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div><div> </div></div></div></div></div></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>- Do we need the old workflow code?</div>
</blockquote></div><div>No we shouldn't need it anymore.</div></div></div></div></blockquote><div><br></div></div><div>Ok, I will merge the code and then you can remove it later. Would that be Ok? </div><span class="HOEnZb"><font color="#888888"><div>
<br>
</div><div>- Aashish</div></font></span><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>_______________________________________________<br>
Opengeoscience-developers mailing list<br>
<a href="mailto:Opengeoscience-developers@public.kitware.com" target="_blank">Opengeoscience-developers@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers</a><br>
<br></blockquote></div></div><br><br clear="all"><div class="im"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com">www.kitware.com</a>
</div>