<div dir="ltr">Chris, <div><br></div><div>I was able to find a simple fix and pushed on both repositories. Make sure you update your local copy before you try it. </div><div><br></div><div>Thanks, </div><div><br></div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 8, 2013 at 3:58 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry forgot to answer one question:<div><br></div><div>I will have a look to see if there is a simple fix but that may not happen until 4-4:30. </div>
<div><br></div><div>Thanks</div><span class="HOEnZb"><font color="#888888"><div>
<br></div><div>- Aashish</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 8, 2013 at 3:55 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Mon, Jul 8, 2013 at 3:49 PM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I am just working on chemistry dashboard issue and then I will get back to the review. However, I'm not sure it should go in with the zoom as it is? Is it simple to fix?</blockquote>
<div><br></div></div><div>The zoom itself is not related to this (the branch didn't do anything for it). I am not sure if I would like to fix the zoom going past the layer as part of this branch primarily because</div>
<div><br></div><div>1. The branch has lots of changes and I would like to get it in</div><div>2. More importantly we should not allow interactions to go past the map layer (what does that even mean?) So I am not too much worry about handling that case for OSM (unless you have strong objections to it) </div>
<span><font color="#888888">
<div><br></div><div>- Aashish</div></font></span><div><div><div> </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><font color="#888888"><div>
<br></div></font></span><div><span><font color="#888888">Chris</font></span><div><div><br><br><div class="gmail_quote">
On Mon, Jul 8, 2013 at 3:46 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Cool. So I guess you will get back to me on this in next hour or so? (basically +1, -1 approval ratings)? <span><font color="#888888"><div><br></div><div>- Aashish</div></font></span></div><div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Jul 8, 2013 at 3:07 PM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Excellent!<div><div><br><br><div class="gmail_quote">On Mon, Jul 8, 2013 at 3:02 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Brad increased the size to 2MB. I pushed the branch on origin as well. <div><div class="gmail_extra"><br>
<br><div class="gmail_quote"><div>On Mon, Jul 8, 2013 at 2:26 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div dir="ltr">Currently, if you go behind the map when zoom-in (which I will fix in a separate branch where you won't be able to do that), then the code may break. <div>
<br></div><div>Make sure that you don't go past the map layer (which could be tricky sometimes as it zoomin quite fast). </div><span><font color="#888888">
<div><br></div><div>- Aashish</div><div><br></div></font></span></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Mon, Jul 8, 2013 at 2:23 PM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br><br>On Mon, Jul 8, 2013 at 12:01 PM, Aashish Chaudhary <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
</div><div>> Thanks Chris. Couple of points to remember: <br>><br>> 1. I kept the boundary lines (would be nice to turn it off when zoomed in<br>
> close as these are low res) for now . <br>> 2. The zoom computation could be tweaked. <br><br></div>Yep, It looks like you can zoom through the map and then the tiling stops working? And you end up with something like this?<br>
<br></div><div><div><br><br><div><div>> 3. After you +1 the branch, I would like to fix the coding style for newly<br>> added files (most of them are good)<br>
><br>> Thanks<br>><br>
><br>><br>> On Mon, Jul 8, 2013 at 11:51 AM, Chris Harris <<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>><br>> wrote:<br>>><br>>> I will be happy to test is out for you.<br>
>><br>>> Chris<br>>><br>>> On Mon, Jul 8, 2013 at 11:48 AM, Aashish Chaudhary<br>>> <<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>> wrote:<br>
>> > This branch has quite a few of changes and I would like someone else<br>
>> > (Chris<br>>> > or Dave probably) to run a quick test on it.<br>>> ><br>>> > Summary:<br>>> > - Adds ability to get tiles from OSM<br>>> > - Updated and cleaned API<br>
>> > - Basic work for projection<br>>> > - Added code for bin based sorting<br>>> ><br>>> > Some of the things are not perfect (like projection when I am not<br>>> > multiplying mecator with scaling) but that could be taken care later.<br>
>> ><br>>> > @Dave do you have sometime this afternoon? I have a question on colop<br>>> > map.<br>>> ><br>>> > --<br>>> > | Aashish Chaudhary<br>>> > | R&D Engineer<br>
>> > | Kitware Inc.<br>>> > | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>>> ><br>>> > _______________________________________________<br>>> > Opengeoscience-developers mailing list<br>
>> > <a href="mailto:Opengeoscience-developers@public.kitware.com" target="_blank">Opengeoscience-developers@public.kitware.com</a><br>>> ><br>>> > <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers</a><br>
>> ><br>><br>><br>><br>><br>> --<br>> | Aashish Chaudhary<br>> | R&D Engineer <br>> | Kitware Inc. <br>> | <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <br>
<br>
</div></div></div></div></blockquote></div><div><div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div></div></div>
</div></div></blockquote></div><div><div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div></div></div></div></div>
</blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div></div></div><div><div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com">www.kitware.com</a>
</div>