<div dir="ltr">Hi Aashish,<div><br></div><div style>I wasn't aware we were doing 2 spaces on python as well. The standard seems to be 4, and it looks like a majority of the python code in our project is already 4 spaces, not just mine. It will be easier to convert the few 2-spaced files to 4 spaces rather than the other way around at this point, so I think we should switch to 4 spaces for python.</div>
<div style><br></div><div style>What do you think?</div><div style><br></div><div style>Ben </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 3, 2013 at 8:03 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ben, <div><br></div><div>The code looks reasonable but you would have to walk me through the code so that I completely understand it. Some minor things </div>
<div><br></div><div>- Please use spacing (not tabs) of size 2 (for python and JS)</div>
<div>- Based on the feedback from Mansa/Keval combine variable into single statement </div><div><br></div><div>Thanks,</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, May 1, 2013 at 1:44 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Great. Thanks for pushing it upstream. Looking forward to it. <span><font color="#888888"><div><br></div><div>- Aashish</div><div><br></div></font></span></div><div><div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 1, 2013 at 1:43 PM, Ben Burnett <span dir="ltr"><<a href="mailto:benjam.arlyn@gmail.com" target="_blank">benjam.arlyn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">sure, thanks</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, May 1, 2013 at 1:43 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure but probably it won't happen until Friday (as I will need some time to review it). Would that be OK? <div>
<br><div><br></div></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Wed, May 1, 2013 at 1:26 PM, Ben Burnett <span dir="ltr"><<a href="mailto:benjam.arlyn@gmail.com" target="_blank">benjam.arlyn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13px">Aashish,</span><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px">Branch services_modules_nodes should be ready to go into master. Can you review and merge it?</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">Thanks,</div><div style="font-family:arial,sans-serif;font-size:13px">Ben</div></div><div>
<div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, May 1, 2013 at 1:20 PM, Ben Burnett <span dir="ltr"><<a href="mailto:bburnett@poly.edu" target="_blank">bburnett@poly.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is an automated email from the git hooks/post-receive script. It was<br>
generated because a ref change was pushed to the repository containing<br>
the project "OpenGeoscience".<br>
<br>
The branch, next has been updated<br>
via 4afffb0eab83710e4cfe130ad7eaf8e93c4290df (commit)<br>
via 5b0c250e44258cd62ff3b8f05ef1b9a6f7d6d655 (commit)<br>
via be8a8a2c5942cd42a50cd41834472fe21e5e3456 (commit)<br>
via d8355cb5b7a84026d7fbe1db121b700d1ed638d8 (commit)<br>
via 27704500eeb7b214b200e48d3217e6ba2d67596b (commit)<br>
via f4c8fa87aa1e7b19bff96f7470f8a0c9cfbd1fd2 (commit)<br>
from 96c9b158580bd5d9e9ff64af3a9a547ad839934b (commit)<br>
<br>
Those revisions listed above that are new to this repository have<br>
not appeared on any other notification email; so we list those<br>
revisions in full, below.<br>
<br>
- Log -----------------------------------------------------------------<br>
<a href="http://public.kitware.com/gitweb?p=OpenGeoscience/geoweb.git;a=commitdiff;h=4afffb0eab83710e4cfe130ad7eaf8e93c4290df" target="_blank">http://public.kitware.com/gitweb?p=OpenGeoscience/geoweb.git;a=commitdiff;h=4afffb0eab83710e4cfe130ad7eaf8e93c4290df</a><br>
commit 4afffb0eab83710e4cfe130ad7eaf8e93c4290df<br>
Merge: 96c9b15 5b0c250<br>
Author: Ben Burnett <<a href="mailto:bburnett@poly.edu" target="_blank">bburnett@poly.edu</a>><br>
Date: Wed May 1 13:19:32 2013 -0400<br>
<br>
Merge branch 'services_modules_nodes' into next<br>
<br>
Conflicts:<br>
geoweb.py<br>
<br>
geoweb.py | 77 +++++++++++++++++++++++++++++++++++++++++--------<br>
services/__init__.py | 54 -----------------------------------<br>
temp/testService.py | 2 +<br>
3 files changed, 66 insertions(+), 67 deletions(-)<br>
<br>
-----------------------------------------------------------------------<br>
<br>
Summary of changes:<br>
geoweb.py | 77 +++++++++++++++++++++++++++++++++++++++++--------<br>
services/__init__.py | 54 -----------------------------------<br>
temp/testService.py | 2 +<br>
3 files changed, 66 insertions(+), 67 deletions(-)<br>
delete mode 100644 services/__init__.py<br>
create mode 100644 temp/testService.py<br>
<br>
<br>
hooks/post-receive<br>
<span><font color="#888888">--<br>
OpenGeoscience<br>
_______________________________________________<br>
Opengeoscience-developers mailing list<br>
<a href="mailto:Opengeoscience-developers@public.kitware.com" target="_blank">Opengeoscience-developers@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers</a><br>
</font></span></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
Opengeoscience-developers mailing list<br>
<a href="mailto:Opengeoscience-developers@public.kitware.com" target="_blank">Opengeoscience-developers@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</div>
</div></div></blockquote></div><br></div>