<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle">P {margin-top:0;margin-bottom:0;}</style><style type="text/css">
<!--
--><!--
--></style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hello Aashish,<br>
<br>
I have made changes in Geo library files( 'fix-jslint-errors' branch), you can check it if the files in Geo directory is passed or not. Also in 'map.js' and 'layer.js' files i am getting below errors:<br>
<br>
<cite>Strict violation.</cite>
<pre> currentElement = this;</pre>
<cite>Unexpected 'this'.</cite>
<pre> this.activeLayer = function() {<br><br>Could you please assist us why are we getting this error. When i searched for it i found that we need to add <code><span class="com">/*jslint validthis: true */, but it didn't resolved the error. Could you please assist us with the above two errors?<br><br>Regards,<br>Keval <br></span></code></pre>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF841076"><font color="#000000" face="Tahoma" size="2"><b>From:</b> opengeoscience-developers-bounces@public.kitware.com [opengeoscience-developers-bounces@public.kitware.com] on behalf of Keval Sheth [krs435@students.poly.edu]<br>
<b>Sent:</b> Thursday, April 25, 2013 4:57 AM<br>
<b>To:</b> Aashish Chaudhary<br>
<b>Cc:</b> opengeoscience-developers<br>
<b>Subject:</b> Re: [Opengeoscience-developers] js-lint branch<br>
</font><br>
</div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hello Aashish,
<div><br>
<div>Thanks a lot. Ya sure, we will handle the geo library once and will be pushing it so that we can find out whether it has been passed it or not.</div>
<div><br>
</div>
<div>Regards,</div>
<div>Keval<br>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr tabindex="-1">
<div id="divRpF338096" style="direction:ltr"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Aashish Chaudhary [aashish.chaudhary@kitware.com]<br>
<b>Sent:</b> Thursday, April 25, 2013 4:53 AM<br>
<b>To:</b> Keval Sheth<br>
<b>Cc:</b> opengeoscience-developers<br>
<b>Subject:</b> Re: [Opengeoscience-developers] js-lint branch<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Hi Keval,
<div><br>
</div>
<div style="">before that, I tried the branch and found that it broke the code. Actually I am thinking that if you and Manas can handle the geo library first (since hopefully no one is touching that code at this moment). And lets have those files passed. If
we run into some issues with those files then we can look into it further. I think if we go module by module or files by files, it will make it easy for us to get it done. </div>
<div style=""><br>
</div>
<div style="">Does it make sense? </div>
<div style=""><br>
</div>
<div style="">Thanks,</div>
<div style="">Aashish</div>
<div style=""><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Apr 25, 2013 at 12:25 AM, Keval Sheth <span dir="ltr">
<<a href="mailto:krs435@students.poly.edu" target="_blank">krs435@students.poly.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-size:10pt; font-family:Tahoma">Hello Aashish,
<div><br>
</div>
<div>There are few files in which there were no errors while we reviewed using Jslint tool, but still it didn't passed the test and showed as 'failed' in dashboard. Could you please let us know what are the requirements that specific file should pass the test
on dashboard apart from removing the errors through Jslint tool.</div>
<div>Below are few files among them from 'geo' folder:</div>
<div>'command.js', 'feature.js', 'latlng.js'</div>
<div><br>
</div>
<div>Regards,</div>
<div>Keval<br>
<div style="font-size:16px; font-family:Times New Roman">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> <a href="mailto:opengeoscience-developers-bounces@public.kitware.com" target="_blank">
opengeoscience-developers-bounces@public.kitware.com</a> [<a href="mailto:opengeoscience-developers-bounces@public.kitware.com" target="_blank">opengeoscience-developers-bounces@public.kitware.com</a>] on behalf of Aashish Chaudhary [<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>]<br>
<b>Sent:</b> Thursday, April 25, 2013 3:47 AM<br>
<b>To:</b> opengeoscience-developers<br>
<b>Subject:</b> [Opengeoscience-developers] js-lint branch<br>
</font><br>
</div>
<div>
<div class="h5">
<div></div>
<div>
<div dir="ltr">Manas, Keval,
<div><br>
</div>
<div>What's the current status? Should I go ahead and review it? </div>
<div><br>
</div>
<div>- Aashish</div>
<div><br>
</div>
<div>
<div><br>
</div>
-- <br>
| Aashish Chaudhary <br>
| R&D Engineer <br>
| Kitware Inc. <br>
| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> </div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
| Aashish Chaudhary <br>
| R&D Engineer <br>
| Kitware Inc. <br>
| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> </div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>