<div dir="ltr">Umm, yes, there's no "Grid" in the config (all commented out), but I misspoke about it failing somewhere else. It fails in the same place. Looks like the OCV plugin is asking CV for a "SURF" FeatureDetector, the implementation in CV is the "different" error I mentioned. Sorry for the confusion.<div><br></div><div>Sounds like to get a Windows Port we need to either fix the obscure bug in CV2 or migrate MapTK to CV3.<br><div><br></div><div>I downloaded the VM you mentioned and was able to walk through the tutorial ... thanks for taking the effort to do that. </div><div><br></div><div>Is there a way to use the existing MapTK tools or SDK to create a rectified image from the overlapping collection?</div><div><br></div><div>msr</div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 14, 2015 at 7:49 PM, Matthew Leotta <span dir="ltr"><<a href="mailto:matt.leotta@kitware.com" target="_blank">matt.leotta@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Michael,<div><br></div><div>Can you confirm that “Grid” no longer appears anywhere in your config? I’m not sure how this code path would be reached if you are no longer configured to use the GridAdaptedFeatureDetector.<br><div><br></div><div>The most relevant OpenCV ticket is this one:</div><div><br></div><div><a href="http://code.opencv.org/issues/2700" target="_blank">http://code.opencv.org/issues/2700</a></div><div><br></div><div>You can see the solution is “ok, we removed this feature from 3.0”, so they no longer need to address the problem. Another related ticket is here:</div><div><br></div><div><a href="http://code.opencv.org/issues/4129" target="_blank">http://code.opencv.org/issues/4129</a></div><div><br></div><div>This one suggests that going forward (starting in OpenCV 3.0) one needs to explicitly call create functions on the class instance, instead of creating by name. This means that when we update MAP-Tk to use OpenCV 3.0 we will also need reproduce this lookup by name on the MAP-Tk side.</div><div><br></div><div>Also, it seems that the GridAdaptiveFeatureDetector itself (and all the other adaptive feature detector modifiers) have gone missing in OpenCV 3.0 as noted here:</div><div><br></div><div><a href="http://answers.opencv.org/question/42490/gridadaptedfeaturedetector-missing-in-opencv-30/" target="_blank">http://answers.opencv.org/question/42490/gridadaptedfeaturedetector-missing-in-opencv-30/</a></div><div><br></div><div>I started a branch to upgrade to OpenCV 3.0, but got stuck with these issues. In summary, there doesn’t appear to be a simple fix here. I’d be happy to have someone volunteer to tackle this issue.</div><div><br></div><div>—Matt</div><div><div class="h5"><div><br></div><div><br></div><div><br><div><blockquote type="cite"><div>On Oct 14, 2015, at 6:42 PM, Michael Rosen <<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Ah. I missed the change. Did that ... and it did help but then it does the same thing somewhere else:<div><br></div><div><div> <span style="white-space:pre-wrap"> </span>msvcr120.dll!memchr(unsigned char * buf, unsigned char chr, unsigned long cnt) Line 101<span style="white-space:pre-wrap"> </span>Unknown</div><div> <span style="white-space:pre-wrap"> </span>opencv_features2d249.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char> >::find(const char * _Ptr, unsigned int _Off, unsigned int _Count) Line 1908<span style="white-space:pre-wrap"> </span>C++</div><div>><span style="white-space:pre-wrap"> </span>opencv_features2d249.dll!cv::FeatureDetector::create(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & detectorType) Line 93<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::priv::default_detector() Line 76<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::priv::priv() Line 63<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::detect_features() Line 94<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::algo::algorithm_impl<maptk::ocv::detect_features,maptk::algo::detect_features>::register_self(maptk::registrar & reg) Line 370<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::register_algorithms(maptk::registrar & reg) Line 70<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv_plugin.dll!register_algo_impls(maptk::registrar & reg) Line 44<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv_plugin.dll!private_register_algo_impls(maptk::registrar & reg) Line 59<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::register_from_module(boost::filesystem::path module_path) Line 293<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::load_modules_in_directory(boost::filesystem::path dir_path, std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 198<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::load_from_search_paths(std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 146<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::register_plugins(std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 409<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!maptk_main(int argc, const char * * argv) Line 236<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!main(int argc, const char * * argv) Line 489<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!__tmainCRTStartup() Line 626<span style="white-space:pre-wrap"> </span>C</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!mainCRTStartup() Line 466<span style="white-space:pre-wrap"> </span>C</div></div><div><br></div><div><div>Ptr<FeatureDetector> FeatureDetector::create( const string& detectorType )</div><div>{</div><div> if( detectorType.find("Grid") == 0 ) /// AV here.</div><div> {</div><div> return new GridAdaptedFeatureDetector(FeatureDetector::create(</div><div> detectorType.substr(strlen("Grid"))));</div><div> }</div></div><div><br></div><div><br></div><div>Thanks very much for the Linux pointers. I'll try those.</div><div><br></div><div>At some point, I'll need to speak to the prospects for making this work on Windows. Can you point me to a ticket for the "<span style="font-size:12.8px">OpenCV’s algorithm factory code on Windows" issue you mentioned or otherwise comment on the prospects for a fix?</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">msr</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 14, 2015 at 7:09 AM, Matthew Leotta <span dir="ltr"><<a href="mailto:matt.leotta@kitware.com" target="_blank">matt.leotta@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">It’s not just commenting out lines that is needed. You also have to modify the other lines to remove the Features2D.Grid wrapper around the Features2D.SURF. I’ve illustrated what needs to change in my previous e-mail. That said, if you can use Linux that’s a better solution.<div><br></div><div>There are a few options for the Linux route:</div><div><br></div><div>1) Keith or someone else can provide guidance on using Kwiver to build boost and other dependencies. I think a lot of that has been cleaned up in the last couple of weeks.</div><div><br></div><div>2) You can use the pre-built VM that comes with the CVPR tutorial. That has MAP-Tk pre-built and ready to run. You can either download the VM image or use Vagrant to reproduce it yourself.</div><div><br></div><div>3) Depending on your Linux distro, you may be able to install system packages for boost and other dependencies. For example, the VM mentioned above does this using Ubuntu 14.04. If you happen to be using Ubuntu, you can look through the Vagrant setup scripts to see exactly how to install all dependencies and build MAP-Tk.</div><div><br></div><div>—Matt<div><div><br><div><br></div><div><br><div><blockquote type="cite"><div>On Oct 14, 2015, at 9:58 AM, Michael Rosen <<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>> wrote:</div><br><div><div dir="ltr">I commented out lines from clif_track.conf as follows but it failed as before:<div><div># The OpenCV cv::Algorithm type to use for 'detector'.</div><div>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:type = Feature2D.SURF</div><div><br></div><div>#feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:gridCols = 4</div><div>#feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:gridRows = 6</div><div>#feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:maxTotalKeypoints = 1000</div></div><div><br></div><div>I had previously tried building Kwiver on Linux but it failed to build Boost. Can you recommend a way forward for me?</div><div><br></div><div>Thanks.</div><div><br></div><div>msr</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 14, 2015 at 6:42 AM, Matthew Leotta <span dir="ltr"><<a href="mailto:matt.leotta@kitware.com" target="_blank">matt.leotta@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Michael,<div><br></div><div>This is likely related persistent issues with OpenCV’s algorithm factory code on Windows. For whatever reason, the OpenCV team could never seem to work the kinks out of this on Windows, but it works fine on other platforms. I was really hoping they were going to fix it once and for all in OpenCV 3.0, but instead they decided it was too much hassle and they just removed algorithm factories altogether. So OpenCV no longer supports creating algorithms at run-time from string names. This makes me sad, because we had a nice system in MAP-Tk of allowing OpenCV algorithms to be created and configured on the fly using the MAP-Tk configuration file. If we upgrade MAP-Tk to use OpenCV 3.0 we will have to hard code a fixed set of algorithm choices and configuration parameters.</div><div><br></div><div>The problem seems to mostly manifest itself when you use nested OpenCV algorithm on Windows. In this case, the example config file contains:</div><div><br></div><div>-----------------------<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:Feature2D.SURF:extended = false<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:Feature2D.SURF:hessianThreshold = 100<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:Feature2D.SURF:nOctaveLayers = 3<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:Feature2D.SURF:nOctaves = 4<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:Feature2D.SURF:upright = true<br><br># The OpenCV cv::Algorithm type to use for 'detector'.<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:detector:type = Feature2D.SURF<br><br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:gridCols = 4<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:gridRows = 6<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.Grid:maxTotalKeypoints = 1000<br><br># The OpenCV cv::Algorithm type to use for 'detector'.<br>feature_tracker:core:feature_detector:ocv:detector:type = Feature2D.Grid</div><div>----------------------- </div><div><br></div><div>This might run if you remove the OpenCV grid adaptive detector layer like this:</div><div><br></div><div><div>----------------------- <br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.SURF:extended = false<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.SURF:hessianThreshold = 100<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.SURF:nOctaveLayers = 3<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.SURF:nOctaves = 4<br>feature_tracker:core:feature_detector:ocv:detector:Feature2D.SURF:upright = true<br><br># The OpenCV cv::Algorithm type to use for 'detector'.<br>feature_tracker:core:feature_detector:ocv:detector:type = Feature2D.SURF</div><div>----------------------- </div></div><div><br></div><div>I would expect this to run (hopefully), but it is likely that it may not produce ideal results.</div><div><br></div><div>—Matt</div><div><div><div><br></div><div><br><div><blockquote type="cite"><div>On Oct 14, 2015, at 9:13 AM, Michael Rosen <<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Presentation and test data look great. Sadly, it's not working for me on Windows. maptk_track_features posts an AV. Can you provide some insight into what's wrong?<div><br></div><div>Attempting to follow along with the example, I ran this:</div><div><br></div><div><div> C:\dev\cvpr2015-opensfm-master\Exercises\maptk>C:\dev\maptk\bin\maptk_track_features.exe -c clif_track.conf</div><div><br></div><div>I think the debug spew below looks ok:</div><div><br></div><div>[DEBUG][maptk::algorithm_plugin_manager::register_plugins] Dynamically loading plugin impls</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::load_from_search_paths] Loading plugins in search paths</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::load_modules_in_directory] Loading modules in directory: "C:/dev/maptk/lib/maptk"</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Starting plug-in interfacing for module file: "C:/dev/maptk/lib</div><div>/maptk\maptk_core_plugin.dll"</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Loaded module: 73EE0000</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Looking for algorithm impl registration function: private_regis</div><div>ter_algo_impls</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] -> returned function address: 73EE1163</div><div>[DEBUG][maptk::Implementation Registration] Registering algorithm implementations from module 'maptk_core'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'close_loops:bad_frames_only' for def type 'close_loops'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'bad_frames_only' for def type 'close_loops'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'close_loops:multi_method' for def type 'close_loops'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'multi_method' for def type 'close_loops'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'compute_ref_homography:core' for def type 'compute_ref_homography'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'core' for def type 'compute_ref_homography'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'convert_image:bypass' for def type 'convert_image'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'bypass' for def type 'convert_image'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'filter_features:magnitude' for def type 'filter_features'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'magnitude' for def type 'filter_features'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'bundle_adjust:hierarchical' for def type 'bundle_adjust'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'hierarchical' for def type 'bundle_adjust'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'match_features:homography_guided' for def type 'match_features'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'homography_guided' for def type 'match_features'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'track_features:core' for def type 'track_features'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'core' for def type 'track_features'</div><div>[DEBUG][maptk::algorithm_plugin_interface_macros::REGISTRATION_SUMMARY] Registered 8 of 8 algorithms</div><div> (@C:\dev\maptk\maptk\plugins\core\register_algorithms.cxx)</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] -> Successfully called registration func</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Starting plug-in interfacing for module file: "C:/dev/maptk/lib</div><div>/maptk\maptk_ocv_plugin.dll"</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Loaded module: 73EA0000</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] Looking for algorithm impl registration function: private_regis</div><div>ter_algo_impls</div><div>[DEBUG][maptk::algorithm_plugin_manager::impl::register_from_module] -> returned function address: 73EA1163</div><div>[DEBUG][maptk::Implementation Registration] Registering algorithm implementations from module 'maptk_ocv'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'analyze_tracks:ocv' for def type 'analyze_tracks'</div><div>[DEBUG][maptk::registrar] Registering algo implementation 'ocv' for def type 'analyze_tracks'</div></div><div><br></div><div>But then right after that, I get an Access Violation with this call stack. What's happening?</div><div><br></div><div><div> <span style="white-space:pre-wrap"> </span>msvcr120.dll!memchr(unsigned char * buf, unsigned char chr, unsigned long cnt) Line 101<span style="white-space:pre-wrap"> </span>Unknown</div><div>><span style="white-space:pre-wrap"> </span>opencv_features2d249.dll!std::basic_string<char,std::char_traits<char>,std::allocator<char> >::find(const char * _Ptr, unsigned int _Off, unsigned int _Count) Line 1908<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>opencv_features2d249.dll!cv::FeatureDetector::create(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & detectorType) Line 93<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::priv::default_detector() Line 76<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::priv::priv() Line 63<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::detect_features::detect_features() Line 94<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::algo::algorithm_impl<maptk::ocv::detect_features,maptk::algo::detect_features>::register_self(maptk::registrar & reg) Line 370<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv.dll!maptk::ocv::register_algorithms(maptk::registrar & reg) Line 70<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv_plugin.dll!register_algo_impls(maptk::registrar & reg) Line 44<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_ocv_plugin.dll!private_register_algo_impls(maptk::registrar & reg) Line 59<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::register_from_module(boost::filesystem::path module_path) Line 293<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::load_modules_in_directory(boost::filesystem::path dir_path, std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 198<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::impl::load_from_search_paths(std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 146<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_apm.dll!maptk::algorithm_plugin_manager::register_plugins(std::basic_string<char,std::char_traits<char>,std::allocator<char> > name) Line 409<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!maptk_main(int argc, const char * * argv) Line 236<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!main(int argc, const char * * argv) Line 489<span style="white-space:pre-wrap"> </span>C++</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!__tmainCRTStartup() Line 626<span style="white-space:pre-wrap"> </span>C</div><div> <span style="white-space:pre-wrap"> </span>maptk_track_features.exe!mainCRTStartup() Line 466<span style="white-space:pre-wrap"> </span>C</div></div><div><br></div><div><br></div><div>The offending code seems to be this:</div><div><div>/// create the default feature detector</div><div> static cv::Ptr<cv::FeatureDetector> default_detector()</div><div> {</div><div> cv::Ptr<cv::FeatureDetector> det;</div><div> // try the SURF detector first</div><div> det = cv::FeatureDetector::create("SURF"); //////// Access Violation here.</div><div> if( !det )</div><div> {</div><div> // if SURF is not available (nonfree not built) use ORB</div><div> det = cv::FeatureDetector::create("ORB");</div><div> }</div><div> return det;</div><div> }</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 6, 2015 at 2:47 PM, Michael Rosen <span dir="ltr"><<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks very much. This looks really helpful. I'll give it a spin and let you know how it goes.<div><br></div><div>msr</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 6, 2015 at 2:01 PM, Matthew Leotta <span dir="ltr"><<a href="mailto:matt.leotta@kitware.com" target="_blank">matt.leotta@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Oct 6, 2015, at 3:38 PM, Michael Rosen <<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Thanks for this. It compiles and the assert is gone. <div><br></div><div>To be clear, here's what I did:</div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>git clone <a href="https://github.com/Kitware/maptk.git" target="_blank">https://github.com/Kitware/maptk.git</a></div><div><div>cd .\maptk</div></div><div><div>git fetch origin pull/88/head:dev/camera-pass-by-reference</div></div><div><div>git checkout dev/camera-pass-by-reference</div></div><div><div>cmake -G "NMake Makefiles" -DBOOST_ROOT=C:\dev\fletch\install -DEIGEN3_INCLUDE_DIR="C:\Program Files (x86)\Eigen\include\eigen3"</div></div><div><div>nmake</div></div><div><div>nmake install</div></div></blockquote></div></div></blockquote><div><br></div><div><br></div></span><div>Interesting, so you didn’t need to do any of the defines to disable byte alignment for Eigen? Were you building master or release before?</div><div><br></div><div>By the way, I have now merged that dev/camera-pass-by-reference branch into both the release and master branches of MAP-Tk, so you should be able to use one of the primary branches again.</div><span><div><br></div><br><blockquote type="cite"><div><div dir="ltr"><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><br></div></blockquote><div><div>Is there a simple workflow you can pass that will demonstrate use of some of the utilities. For example, suppose I have a collection of overlapping images, what can I do with them?</div></div></div></div></blockquote><div><br></div></span><div>I’ve been meaning to write up a tutorial on this, but haven’t gotten to it yet. Part of this is because there are big API changes coming soon as well as improvements in algorithms. There is a bunch of stuff building up that I can’t release yet until I get approval from AFRL. A preview of those changes is on the kwiver-integration branch. We are pulling a lot of core guts of MAP-Tk out into a new repository named VITAL (<a href="https://github.com/kitware/vital" target="_blank">https://github.com/kitware/vital</a>) that is shared across KWIVER projects. I don’t recommend building that on Windows just yet. But Keith Fieldhouse is working on a KWIVER “super build” that will use CMake to make the various projects build together easily.</div><div><br></div><div>Anyway, the best I can do at this point is to point you to a tutorial I gave back in June at the CVPR conference:</div><div><br></div><div><a href="http://www.kitware.com/cvpr2015-tutorial.html" target="_blank">http://www.kitware.com/cvpr2015-tutorial.html</a></div><div><br></div><div>This used a version of MAP-Tk similar to the current release branch. There are examples for applying MAP-Tk to a sample dataset. A Linux VM image is provided with all the software and data pre-installed, but you can also get the config files here:</div><div><br></div><div><a href="https://github.com/mleotta/cvpr2015-opensfm/tree/master/Exercises/maptk" target="_blank">https://github.com/mleotta/cvpr2015-opensfm/tree/master/Exercises/maptk</a></div><div><br></div><div>and the sample data here:</div><div><br></div><div><a href="https://github.com/mleotta/cvpr2015-opensfm/tree/master/Data/CLIF_2007" target="_blank">https://github.com/mleotta/cvpr2015-opensfm/tree/master/Data/CLIF_2007</a></div><div><br></div><div>and slides explaining what to do here:</div><div><br></div><div><a href="http://midas3.kitware.com/midas/download/item/317119/Hands_on_with_MAP-Tk.pdf" target="_blank">http://midas3.kitware.com/midas/download/item/317119/Hands_on_with_MAP-Tk.pdf</a></div><div><br></div><div>FYI, MAP-Tk is (for the moment) a bit specialized to aerial imagery, so it might not work well out of the box on arbitrary images.</div><div><br></div><div>Good Luck,</div><div>Matt</div><div><div><div><br></div><div><br></div><br><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>msr</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 6, 2015 at 10:36 AM, Matthew Leotta <span dir="ltr"><<a href="mailto:matt.leotta@kitware.com" target="_blank">matt.leotta@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Michael,<div><br></div><div>Thank you for reporting this issue. I’ll be upfront and warn you that I’m not a Windows developer and MAP-Tk is currently better tested on Linux and Mac. That said, we are working toward getting things better running on Windows more reliably.</div><div><br></div><div>In this case, the issues are related to Eigen byte-alignment issues as explained on the Eigen website linked from your error message:</div><div><br></div><div><a href="http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html" target="_blank">http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html</a></div><div><br></div><div>I have read this page before, and expected I would need to make changes at some point to work around these issues, but until now I had not come across a compiler that exhibited these symptoms. We should probably try to get a VisualStudio 2012 build up on our dashboard so I can work through those issues properly. I expect that will take some time. A shorter term solution is to try to disable alignment in your build. Can you try the solutions described at the bottom of the page at the above URL? In the "I don't care about vectorization, how do I get rid of that stuff?” section it suggests defining some macros to disable alignment. Let me know if that works.</div><div><br></div><div>In the meantime, I can at least work around that pass-by-value build issue. That function is pass-by-value because we intentionally want to make a local copy of the camera object to modify. However, I can explicitly make that copy inside the function instead. I’ve done this on the release branch of MAP-Tk and made a pull request (<a href="https://github.com/Kitware/maptk/pull/88" target="_blank">https://github.com/Kitware/maptk/pull/88</a>). Can you try to build this branch and verify that it at least builds for you?</div><div><br></div><div>git fetch origin pull/88/head:dev/camera-pass-by-reference</div><div>git checkout dev/camera-pass-by-reference</div><div><br></div><div>If that works, I’ll merge this change into the release and master branches. Also let me know if the solution on the Eigen page helps.</div><div><br></div><div>—Matt</div><div><br></div><div><br><div><blockquote type="cite"><div><div><div>On Oct 5, 2015, at 1:24 PM, Michael Rosen <<a href="mailto:michael.rosen@gmail.com" target="_blank">michael.rosen@gmail.com</a>> wrote:</div><br></div></div><div><div><div><div dir="ltr"><div>Hello Kwiver-folk,</div><div><br></div>I'm building MapTK on Windows 7/64 using VStudio 12 and having two immediate difficulties: a compilation problem and a runtime assert.<div><br></div><div>MapTK is version 0.6.0, Eigen is 3.2.6<br><div><br></div><div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">I've worked through getting Boost and Eigen built. When I compile maptk, the first problem is this:</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> [ 98%] Building CXX object tools/CMakeFiles/maptk_pos2krtd.dir/pos2krtd.cxx.obj</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> pos2krtd.cxx</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> C:\dev\maptk\tools\pos2krtd.cxx(220) : error C2719: 'base_camera': formal parameter with __declspec(align('16')) won't</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> be aligned</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> C:\dev\maptk\tools\pos2krtd.cxx(238) : error C2719: 'base_camera': formal parameter with __declspec(align('16')) won't</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> …</span></p><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">I fixed these compilation errors by changing the signature of the offending function from pass-by-value to pass-by-reference:</span></p><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> /// Convert a POS file to a KRTD file</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> bool convert_pos2krtd(const maptk::path_t& pos_filename,</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> const maptk::path_t& krtd_filename,</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> maptk::local_geo_cs& cs,</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> maptk::camera_d& base_camera, // msr. was pass-by-value</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> maptk::rotation_d const& ins_rot_offset = maptk::rotation_d())</span></p><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">That allows everything to compile and link. The next problem was that I got an Eigen Assert when I run any of the executables:</span></p><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">C:\Program Files (x86)\MAPTK\bin>maptk_analyze_tracks.exe</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">...</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">Assertion failed: (reinterpret_cast<size_t>(array) & 0xf) == 0 && "this assertion is explained here: " "<a href="http://eigen.tuxfamily.org/d" target="_blank"><span style="color:purple">http://eigen.tuxfamily.org/d</span></a></span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">ox-devel/group__TopicUnalignedArrayAssert.html" " **** READ THIS WEB PAGE !!! ****", file c:\program files (x86)\eigen\include\eigen</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">3\eigen\src/Core/DenseStorage.h, line 86</span></p><div><span style="font-size:11pt;font-family:Calibri,sans-serif"> </span><br></div><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">The web page says that classes which contain certain Eigen data structures as members need to use the</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"> EIGEN_MAKE_ALIGNED_OPERATOR_NEW macro to override the "new" operator so that those members will be 16-byte aligned. I've done that but am still seeing the assert.</span></p><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"><br></span></p><p class="MsoNormal"><font face="Calibri, sans-serif"><span style="font-size:14.6667px">Can anyone offer insight into any of this?</span></font></p><p class="MsoNormal"><font face="Calibri, sans-serif"><span style="font-size:14.6667px"><br></span></font></p><p class="MsoNormal"><font face="Calibri, sans-serif"><span style="font-size:14.6667px">msr</span></font></p><p class="MsoNormal"><font face="Calibri, sans-serif"><span style="font-size:14.6667px"><br></span></font></p></div></div></div></div></div>
_______________________________________________<br>Kwiver-users mailing list<br><a href="mailto:Kwiver-users@public.kitware.com" target="_blank">Kwiver-users@public.kitware.com</a><br><a href="http://public.kitware.com/mailman/listinfo/kwiver-users" target="_blank">http://public.kitware.com/mailman/listinfo/kwiver-users</a><br></div></blockquote></div><br></div></div></blockquote></div><br></div>
</div></blockquote></div></div></div><br></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div>
</div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div>