<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=utf-8">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p>And now the copy for the ML</p>
    <p>Christina<br>
    </p>
    <div class="moz-forward-container"><br>
      <br>
      -------- Forwarded Message --------
      <table class="moz-email-headers-table" cellpadding="0"
        cellspacing="0" border="0">
        <tbody>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
            </th>
            <td>Re: [ITK-users] Documentation:
              itk::AttributeSelectionLabelMapFilter</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
            <td>Wed, 19 Oct 2016 16:33:44 +0200</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
            <td>Chr. Rossmanith <a class="moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de"><cr@neuro.ma.uni-heidelberg.de></a></td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
            <td>Matt McCormick <a class="moz-txt-link-rfc2396E" href="mailto:matt.mccormick@kitware.com"><matt.mccormick@kitware.com></a></td>
          </tr>
        </tbody>
      </table>
      <br>
      <br>
      <pre>Hi Matt,

login is working now for reviews.source.kitware.com, but authentication 
on the command line fails, maybe because I'm behind a firewall. Now I'm 
sending the patch to the mailing list as recommended on 
<a class="moz-txt-link-freetext" href="https://itk.org/Wiki/ITK/Git/Account#Gerrit">https://itk.org/Wiki/ITK/Git/Account#Gerrit</a>

Christina

On 14.10.2016 18:55, Matt McCormick wrote:
> Hi Christina,
>
> Could you please try logging into to review.source.kitware.com again?
>
> Thanks,
> Matt
>
> On Fri, Oct 14, 2016 at 9:21 AM, Chr. Rossmanith
> <a class="moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de"><cr@neuro.ma.uni-heidelberg.de></a> wrote:
>> When visiting review.source.kitware.com -> sign in -> provide github
>> credentials  I find myself on a page telling me "forbidden". But without a
>> gerrit user I'm stuck...Any hints? I've double checked the credentials by
>> signing in into github.
>>
>> Christina
>>
>>
>> On 14.10.2016 15:00, Dženan Zukić wrote:
>>
>> Hi Christina,
>>
>> gerrit is the only way to merge patches. Can you submit it as a patch to
>> gerrit?
>>
>> Thanks,
>> Dženan
>>
>> On Fri, Oct 14, 2016 at 8:52 AM, Chr. Rossmanith
>> <a class="moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de"><cr@neuro.ma.uni-heidelberg.de></a> wrote:
>>> Hi Matt,
>>>
>>> I've forked on github, extended the documentation and created a pull
>>> request. Or is gerrit the only way to get a patch merged?
>>>
>>> Christina
>>>
>>>
>>>
>>> On 12.10.2016 18:03, Matt McCormick wrote:
>>>> Hello Christina,
>>>>
>>>> Good idea.
>>>>
>>>> To update the documentation, the class Doxygen documentation can be
>>>> editted:
>>>>
>>>>
>>>> <a class="moz-txt-link-freetext" href="https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Filtering/LabelMap/include/itkAttributeSelectionLabelMapFilter.h#L27-L46">https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Filtering/LabelMap/include/itkAttributeSelectionLabelMapFilter.h#L27-L46</a>
>>>>
>>>> and after a patch is submitted:
>>>>
>>>>     <a class="moz-txt-link-freetext" href="https://itk.org/Wiki/ITK/Git/Develop">https://itk.org/Wiki/ITK/Git/Develop</a>
>>>>
>>>> it will show up on the Doxygen web pages.
>>>>
>>>> Please let us know if you have any questions.
>>>>
>>>> Thanks,
>>>> Matt
>>>>
>>>> On Wed, Oct 12, 2016 at 11:57 AM, Chr. Rossmanith
>>>> <a class="moz-txt-link-rfc2396E" href="mailto:cr@neuro.ma.uni-heidelberg.de"><cr@neuro.ma.uni-heidelberg.de></a> wrote:
>>>>> Hi,
>>>>>
>>>>> I think it would be helpful if the documentation of the filter would
>>>>> mention
>>>>> that there are two outputs, one with the surviving labels and the second
>>>>> with the removed labels (the input image is the union of these images).
>>>>> What
>>>>> is the workflow to achieve this?
>>>>>
>>>>> Christina
>>>>>
>>>>> _____________________________________
>>>>> Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
>>>>>
>>>>> Visit other Kitware open-source projects at
>>>>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
>>>>>
>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php">http://www.kitware.com/products/protraining.php</a>
>>>>>
>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>> <a class="moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ">http://www.itk.org/Wiki/ITK_FAQ</a>
>>>>>
>>>>> Follow this link to subscribe/unsubscribe:
>>>>> <a class="moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users">http://public.kitware.com/mailman/listinfo/insight-users</a>
>>>
>>>
>>> _____________________________________
>>> Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
>>>
>>> Visit other Kitware open-source projects at
>>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php">http://www.kitware.com/products/protraining.php</a>
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> <a class="moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ">http://www.itk.org/Wiki/ITK_FAQ</a>
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> <a class="moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users">http://public.kitware.com/mailman/listinfo/insight-users</a>
>>
>>
>>
>> _____________________________________
>> Powered by <a class="moz-txt-link-abbreviated" href="http://www.kitware.com">www.kitware.com</a>
>>
>> Visit other Kitware open-source projects at
>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/opensource/opensource.html">http://www.kitware.com/opensource/opensource.html</a>
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> <a class="moz-txt-link-freetext" href="http://www.kitware.com/products/protraining.php">http://www.kitware.com/products/protraining.php</a>
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> <a class="moz-txt-link-freetext" href="http://www.itk.org/Wiki/ITK_FAQ">http://www.itk.org/Wiki/ITK_FAQ</a>
>>
>> Follow this link to subscribe/unsubscribe:
>> <a class="moz-txt-link-freetext" href="http://public.kitware.com/mailman/listinfo/insight-users">http://public.kitware.com/mailman/listinfo/insight-users</a>
>>


</pre>
    </div>
  </body>
</html>