<div dir="ltr">I've sent a patch set to gerrit, managed to screw it up somehow and generated 4 reviews instead of 1, whups. Matt, you're on them not sure who else should be.<div><br></div><div>One of them is just a script modification so that my bash port likes your utilities script, just a proposal.</div><div><br></div><div>The other three address each error. Two are a loop fusion issue where mixed type comparison is being generated incorrectly, changing the bound type fixes this.</div><div><br></div><div>More concerning: the third change is an expansion issue with itk::Size<3> where it doesn't get the bound right for a .Fill call and never initializes the last element.</div><div><br></div><div>Apologies for the delay, i'm hesitant to blame things on the compiler until I've convinced myself I know what is going on. TODO generate simplified versions to file with VS team.</div><div><br></div><div>cheers,</div><div>Simon</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, 7 Dec 2015 at 13:53 Simon Alexander <<a href="mailto:skalexander@gmail.com">skalexander@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Matt,<div><br></div><div>Quick update: <span style="line-height:1.5">I've found two compiler bugs so far - not great. On hopefully better news, I've also found that update 1 has shipped. So I will configure that and run it against your RC2 to see if these things are resolved. If not I have workarounds, unsure of the wisdom of adding them.</span></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, 4 Dec 2015 at 17:34 Matt McCormick <<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Simon.<div><br></div><div><div class="gmail_extra"><div class="gmail_quote"></div></div></div></div><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>Apologies I haven't been able to put much time into this, ran into some interesting challenges with VS2015 itself (at least in my configuration) hanging permanently when changing from debug to release mode, or vice versa. It seems the generated project files are a bit of a challenge for it.</div></div></blockquote><div><br></div></div></div></div></div><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div>Yes, Visual Studio has difficulty with large projects that have many build targets. With the 4.9 release, we addressed the behavior a bit by reducing the number of header tests and by turning BUILD_EXAMPLES OFF by default.</div><div><br></div><div>By setting ITK_BUILD_DEFAULT_MODULES to OFF, responsiveness can be improved when focusing on development of a subset of modules.</div></div></div></div></div><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div></div><div>At any rate, I have narrowed down part of the issue at least to being not in the interpolate filter itself, but rather in the test driver code ... somewhere in the nested loops incrementing the underlying array elements is behaving incorrectly in release mode. I'll try and have a closer look this weekend.</div></div></blockquote><div><br></div></div></div></div></div><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div> Thanks for taking a look at this! </div><div><br></div><div>In the past, we ran into some issues with Visual Studio in Release mode where adding const or using a reference for the returned type avoided a faulty optimization. Bug reports to upstream Visual Studio have also helped resolve the issue in some cases, too.</div><div><br></div><div>Thanks,</div><div>Matt</div><div><br></div><div><br></div><div> </div></div><br></div></div></div>
</blockquote></div></blockquote></div>