<div dir="ltr">Matt--<div><br></div><div>The changes I had were actually for the WalkInTriangulation example [1].  Did you mean to fork that instead of itkVoroniQuadEdgeMeshFilter?  In that fork, the OrientationTest function missing from the IJ submission seems to have been refactored as the Orientation2DFunction class [2].  (Please let me know if I've misunderstood what you intended.)</div><div><br></div><div>Best, and thanks!</div><div><br></div><div>--Davis</div><div><br></div><div>[1] <a href="https://github.com/midas-journal/midas-journal-851">https://github.com/midas-journal/midas-journal-851</a></div><div>[2] <a href="https://github.com/ComplexSystemsModeling/itkVoronoiQuadEdgeMeshFilter/blob/master/Modules/Predicates/include/itkOrientation2DFunction.h">https://github.com/ComplexSystemsModeling/itkVoronoiQuadEdgeMeshFilter/blob/master/Modules/Predicates/include/itkOrientation2DFunction.h</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 12, 2015 at 1:37 PM, Matt McCormick <span dir="ltr"><<a href="mailto:matt.mccormick@kitware.com" target="_blank">matt.mccormick@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Davis, Arnaud,<br>
<br>
I have forked the repositories to:<br>
<br>
  <a href="https://github.com/InsightSoftwareConsortium/itkVoronoiQuadEdgeMeshFilter" rel="noreferrer" target="_blank">https://github.com/InsightSoftwareConsortium/itkVoronoiQuadEdgeMeshFilter</a><br>
  <a href="https://github.com/InsightSoftwareConsortium/ITKPointInCircle" rel="noreferrer" target="_blank">https://github.com/InsightSoftwareConsortium/ITKPointInCircle</a><br>
<br>
if you want to develop there.<br>
<br>
HTH,<br>
Matt<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Jun 12, 2015 at 7:54 AM, Arnaud Gelas <<a href="mailto:arnaudgelas@gmail.com">arnaudgelas@gmail.com</a>> wrote:<br>
> Hi Davis,<br>
><br>
> Could you make pull requests to fix this code, please?<br>
><br>
> Not sure who can accept pull request for midas-journal account though :-/…<br>
> If that’s not easily doable, we could import these contributions in the InsightSoftwareConsortium’s organization.<br>
><br>
> Best<br>
> Arnaud<br>
><br>
>> On 10 Jun 2015, at 15:05, DVigneault <<a href="mailto:davis.vigneault@gmail.com">davis.vigneault@gmail.com</a>> wrote:<br>
>><br>
>> Arnaud--<br>
>><br>
>> Thank you for your help, and for the link to the Insight article!  I was<br>
>> able to compile and use the Point In Circle [1] example without difficulty.<br>
>> I had a little more trouble with the Straight Walk [2] example.  I've<br>
>> written reviews for both on IJ.  I've reproduced below the part of the<br>
>> review describing the steps I needed to take to get the Straight Walk<br>
>> example working.<br>
>><br>
>> 1.  It appears that the submodule is not linked correctly in github.  I<br>
>> needed to remove the .gitmodules file and add the submodule manually.  Here<br>
>> is my StackOverflow question [3] which solved the problem.<br>
>> 2.  I had to change WalkInTriangulation/CMakeLists.txt:6:<br>
>> include( ${USE_ITK_FILE}) ==> include( ${ITK_USE_FILE})<br>
>> 3.  At this point, CMake runs without errors; but when building I'm told<br>
>> that OrientationTest is missing.  I assumed that OrientationTest is a<br>
>> wrapper for orient2d, and added the following function to<br>
>> itkWalkInTriangulationFunction.h:<br>
>><br>
>> template< typename TPoint ><br>
>> double<br>
>> OrientationTest( TPoint a, TPoint b, TPoint c )<br>
>> {<br>
>>  double pa[2];<br>
>>  double pb[2];<br>
>>  double pc[2];<br>
>><br>
>>  pa[0] = a[0];<br>
>>  pa[1] = a[1];<br>
>><br>
>>  pb[0] = b[0];<br>
>>  pb[1] = b[1];<br>
>><br>
>>  pc[0] = c[0];<br>
>>  pc[1] = c[1];<br>
>><br>
>>  return orient2d(pa, pb, pc);<br>
>><br>
>> }<br>
>><br>
>> With those changes, the example seems to work correctly, though I haven't<br>
>> done thorough testing yet.<br>
>><br>
>> Best, and thanks again,<br>
>><br>
>> --Davis<br>
>><br>
>> [1] <a href="https://github.com/midas-journal/midas-journal-843" rel="noreferrer" target="_blank">https://github.com/midas-journal/midas-journal-843</a><br>
>> [2] <a href="https://github.com/midas-journal/midas-journal-851" rel="noreferrer" target="_blank">https://github.com/midas-journal/midas-journal-851</a><br>
>> [3]<br>
>> <a href="http://stackoverflow.com/questions/30754878/recursively-cloning-a-git-repo-doesnt-pull-submodules/30756107#30756107" rel="noreferrer" target="_blank">http://stackoverflow.com/questions/30754878/recursively-cloning-a-git-repo-doesnt-pull-submodules/30756107#30756107</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> View this message in context: <a href="http://itk-insight-users.2283740.n2.nabble.com/ITK-users-Segfault-in-Wiki-Example-QuadEdgeMeshParameterizationFilter-tp7587442p7587463.html" rel="noreferrer" target="_blank">http://itk-insight-users.2283740.n2.nabble.com/ITK-users-Segfault-in-Wiki-Example-QuadEdgeMeshParameterizationFilter-tp7587442p7587463.html</a><br>
>> Sent from the ITK Insight Users mailing list archive at Nabble.com.<br>
>> _____________________________________<br>
>> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
>><br>
>> Visit other Kitware open-source projects at<br>
>> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>><br>
>> Kitware offers ITK Training Courses, for more information visit:<br>
>> <a href="http://www.kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://www.kitware.com/products/protraining.php</a><br>
>><br>
>> Please keep messages on-topic and check the ITK FAQ at:<br>
>> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>><br>
>> Follow this link to subscribe/unsubscribe:<br>
>> <a href="http://public.kitware.com/mailman/listinfo/insight-users" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-users</a><br>
><br>
> _____________________________________<br>
> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://www.kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://www.kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/insight-users" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-users</a><br>
</div></div></blockquote></div><br></div>