<html>
<body>
<font size=3>Hi Luis,<br><br>
Thanks for the changes!<br><br>
<blockquote type=cite class=cite cite>As a general practice it doesn't
seem right to overpopulate the<br>
Resample filter all the transforms available in ITK. We probably<br>
can add a "Trait" to the transform for defining when they
are<br>
"Linear", and allowing the ResampleImageFilter to decide
what</blockquote><br>
I agree with this. Adding a method "bool IsLinear(void) {return
true/false;}" to every transform would do the trick,
right?<br><br>
Regards,<br>
Stefan.<br><br>
<br>
At 16:56 02/05/06, Luis Ibanez wrote:<br>
<blockquote type=cite class=cite cite>Hi Marius,<br><br>
Thanks for pointing this out.<br><br>
Actually the if/else-if style is discouraged in the coding style of
ITK,<br>
so I replaced with full "if" statements and each one with its
respective<br>
return.<br><br>
Note that there are other transforms that will qualify as
"linear" and<br>
are not included here yet. In particular the Scale transform and
the<br>
VersorTransform. They are less commonly used...though.<br><br>
As a general practice it doesn't seem right to overpopulate the<br>
Resample filter all the transforms available in ITK. We probably<br>
can add a "Trait" to the transform for defining when they
are<br>
"Linear", and allowing the ResampleImageFilter to decide
what<br>
method to use for the invocation of the transform.<br><br>
<br><br>
Regards,<br><br>
<br>
Luis<br><br>
<br>
------------------<br>
Marius Staring wrote:<br>
<blockquote type=cite class=cite cite>hi Luis,<br>
you might want to change the<br>
if (dynamic_cast<const TranslationTransformType
*>(m_Transform.GetPointer()))<br>
to<br>
else if (dynamic_cast<const TranslationTransformType
*>(m_Transform.GetPointer()))<br><br>
for the sake of consistency.<br>
And then you can get rid of all the return's.<br>
Regards,<br>
Marius<br><br>
Luis Ibanez wrote:<br><br>
<blockquote type=cite class=cite cite><br>
Hi Stefan,<br><br>
The TranslationTransform has now been added to the code of the<br>
ResampleImageFilter, in order to make it use the fast cycle of<br>
point coordinates mapping.<br><br>
You may want to update your CVS checkout of ITK:<br>
<a href="http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkResampleImageFilter.txx?root=Insight&sortby=date&r2=1.53&r1=1.52" eudora="autourl">http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkResampleImageFilter.txx?root=Insight&sortby=date&r2=1.53&r1=1.52</a>
<br><br>
Please let us know if you find any problems,<br><br>
<br>
Thanks<br><br>
<br>
Luis<br><br>
<br><br>
=====================<br>
Stefan Klein wrote:<br><br>
<blockquote type=cite class=cite cite><br>
Hi,<br><br>
The itkResampleImageFilter takes smart advantage of linear transforms. >From line 187-206 in the .txx file it seems that the TranslationTransform is not considered a linear transform. Is this done on purpose, or is it a mistake?<br><br>
Best regards,<br>
Stefan.<br><br>
<br><br>
<br><br>
------------------------------------------------------------------------<br><br>
_______________________________________________<br>
Insight-users mailing list<br>
Insight-users@itk.org<br>
<a href="http://www.itk.org/mailman/listinfo/insight-users" eudora="autourl">http://www.itk.org/mailman/listinfo/insight-users</a></blockquote><br><br>
<br>
_______________________________________________<br>
Insight-users mailing list<br>
Insight-users@itk.org<br>
<a href="http://www.itk.org/mailman/listinfo/insight-users" eudora="autourl">http://www.itk.org/mailman/listinfo/insight-users</a><br>
</blockquote></blockquote><br><br>
_______________________________________________<br>
Insight-users mailing list<br>
Insight-users@itk.org<br>
<a href="http://www.itk.org/mailman/listinfo/insight-users" eudora="autourl">http://www.itk.org/mailman/listinfo/insight-users</a></font></blockquote></body>
<br>
</html>