<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I noticed that our valgrind build of elastix has reports like this:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Courier New"">UMR</span></b><span style="font-size:10.0pt;font-family:"Courier New""> ==5253== Invalid read of size 2<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== at 0x552241: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateOptimized(itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::Dispatch<2u>
const&, itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:173)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x54976C: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::EvaluateAtContinuousIndex(itk::ContinuousIndex<double, 2u> const&) const (itkLinearInterpolateImageFunction.h:99)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x54397B: bool TestInterpolators<2u>() (itkAdvancedLinearInterpolatorTest.cxx:171)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x53E232: main (itkAdvancedLinearInterpolatorTest.cxx:279)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== Address 0x6822b94 is 52 bytes inside a block of size 83 free'd<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== at 0x4C2C2BC: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x5ED884: itk::ObjectFactoryBase::CreateObject(char const*) (in /home/marius/nightly-builds/elastix/bin_debug/bin/itkAdvancedLinearInterpolatorTest)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x5EF91B: itk::ObjectFactoryBase::CreateInstance(char const*) (in /home/marius/nightly-builds/elastix/bin_debug/bin/itkAdvancedLinearInterpolatorTest)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x550335: itk::ObjectFactory<itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double> >::Create() (itkObjectFactory.h:60)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x548A90: itk::LinearInterpolateImageFunction<itk::Image<short, 2u>, double>::New() (in /home/marius/nightly-builds/elastix/bin_debug/bin/itkAdvancedLinearInterpolatorTest)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x543540: bool TestInterpolators<2u>() (itkAdvancedLinearInterpolatorTest.cxx:114)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253== by 0x53E232: main (itkAdvancedLinearInterpolatorTest.cxx:279)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier New"">==5253==
<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">On inspection these lines in itk LinearInterpolateImageFunction.h seem troublesome:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">const RealType & val000 = inputImagePtr->GetPixel(basei);<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Note that a real type is obtained by reference from a function that often does not return a real type. Is this allowed?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best, Marius<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Marius Staring, PhD<o:p></o:p></p>
<p class="MsoNormal">Division of Image Processing (LKEB)<o:p></o:p></p>
<p class="MsoNormal">Department of Radiology<o:p></o:p></p>
<p class="MsoNormal">Leiden University Medical Center<o:p></o:p></p>
<p class="MsoNormal">PO Box 9600, 2300 RC Leiden, The Netherlands<o:p></o:p></p>
<p class="MsoNormal">phone: +31 (0)71 52 62137, fax: +31 (0)71 524 8256 m.staring@lumc.nl<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>