<div dir="ltr"><div><div><div><div>HI Bill,<br></div>that commit solved the linker issues with the duplicate symbols in itk::NumericTraits that were introduced [1] by some other commit in early or mid March.<br><br></div>I acknowledge that VS10 (2010) and VS11 (2012) are some years old, and I have not personally looked deeply into the mentioned linker issue, but was rather affected by them, like other builds [1]; I would dare to say that it was some commit around March, 17th that started producing the linker errors addressed by Brad's patch.<br><br>IMHO; the solution is not to revert the commit, but to look for some solution that makes both VS10, VS11 and Mac happy (besides the pre-merge machines). But I guess that requires some time, and having the ability to test on at least those additional platforms before merging, since it looks like a clean dashboard for a given branch is not enough in this case.<br></div><br></div>I am available to test any patch and submit Experimental builds for VS10.<br><div><br>JON HAITZ<br><br><br>[1] <a href="https://open.cdash.org/viewBuildError.php?buildid=4283661">https://open.cdash.org/viewBuildError.php?buildid=4283661</a><br><br><div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><table style="color:rgb(0,0,0);font-family:'Times New Roman';font-size:medium" align="center" border="0" cellpadding="0" cellspacing="0"><tbody><tr><td><table align="center" border="0" cellpadding="0"><tbody><tr><td><span style="font-size:10px;color:gray;font-family:Verdana,Arial,Helvetica,sans-serif"></span><br></td></tr></tbody></table></td></tr></tbody></table></div></div></div></div></div><div class="gmail_quote">On 31 March 2016 at 17:27, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Folks,<br>
<br>
The same error appears on the Continuous builds. Should we revert the<br>
commit that introduced these compiler errors?<br>
<br>
Bill<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Mar 30, 2016 at 1:56 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>> wrote:<br>
> This commit:<br>
> [e1a7be21102463c7b91c456c3fbbb020f4a00cf7] BUG: Addressing VS10 and<br>
> VS11 NumericTraits linkage issue<br>
><br>
> causes link errors on my Mac clang++ compiler:<br>
> Apple clang version 3.0 (tags/Apple/clang-211.12) (based on LLVM 3.0svn)<br>
><br>
> [ 62%] Building CXX object<br>
> Modules/Core/Common/src/CMakeFiles/ITKCommon.dir/itkNumericTraits.cxx.o<br>
> Linking CXX shared library<br>
> ../../../ThirdParty/VNL/src/vxl/lib/libITKCommon-4.10.dylib<br>
> Undefined symbols for architecture x86_64:<br>
> "itk::NumericTraits<char>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<char>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<signed char>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned char>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned char>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned short>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned short>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<short>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<short>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<signed char>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<int>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<int>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned int>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned int>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<long>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<long>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned long>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned long>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<long long>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<long long>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned long long>::Zero", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> "itk::NumericTraits<unsigned long long>::One", referenced from:<br>
> __GLOBAL__I_a in itkNumericTraitsVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsTensorPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsFixedArrayPixel2.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsPointPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBAPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsCovariantVectorPixel.cxx.o<br>
> __GLOBAL__I_a in itkNumericTraitsRGBPixel.cxx.o<br>
> ...<br>
> ld: symbol(s) not found for architecture x86_64<br>
> clang: error: linker command failed with exit code 1 (use -v to see invocation)<br>
> make[2]: *** [Modules/ThirdParty/VNL/src/vxl/lib/libITKCommon-4.10.1.dylib]<br>
> Error 1<br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br></div></div></div>