<div dir="ltr">This is during authentication to Gerrit; the application asks for repo-level access:<div><a href="https://gist.github.com/ihnorton/76642485ff40eac0aa46">https://gist.github.com/ihnorton/76642485ff40eac0aa46</a><br></div><div><br></div><div>Which GitHub describes as:</div><div>> This is one of the most expansive configurations you can permit, so accept it with caution!<br></div><div><br></div><div><a href="https://help.github.com/articles/connecting-with-third-party-applications/#repositories">https://help.github.com/articles/connecting-with-third-party-applications/#repositories</a></div><div><br></div><div>It's not really clear why KWRobot requires this level of access, given the other OAuth scopes available:</div><div><a href="https://developer.github.com/v3/oauth/#scopes">https://developer.github.com/v3/oauth/#scopes</a><br></div><div><br></div><div>Some clarification would be useful (I've read <a href="http://www.itk.org/Wiki/ITK/Git/Account">http://www.itk.org/Wiki/ITK/Git/Account</a>, and looked around elsewhere, but didn't find any prior discussion).</div><div><br></div><div>Isaiah</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 13, 2016 at 9:01 PM, Johnson, Hans J <span dir="ltr"><<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>
<div>
<div>Isaiah,</div>
<div><br>
</div>
<div>There is no need for R/W. I don’t think you have configured your ITK development evnironment correctly. Are you running “SetupForDevelopment.sh” script?</div>
<div><br>
</div>
<div>Hans</div>
<div>
<div></div>
</div>
</div>
</div>
<div><br>
</div>
<span>
<div style="font-family:Calibri;font-size:12pt;text-align:left;color:black;BORDER-BOTTOM:medium none;BORDER-LEFT:medium none;PADDING-BOTTOM:0in;PADDING-LEFT:0in;PADDING-RIGHT:0in;BORDER-TOP:#b5c4df 1pt solid;BORDER-RIGHT:medium none;PADDING-TOP:3pt">
<span style="font-weight:bold">From: </span>Isaiah Norton <<a href="mailto:isaiah.norton@gmail.com" target="_blank">isaiah.norton@gmail.com</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, January 13, 2016 at 7:59 PM<br>
<span style="font-weight:bold">To: </span>Hans Johnson <<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>><br>
<span style="font-weight:bold">Cc: </span>Bradley Lowekamp <<a href="mailto:brad@lowekamp.net" target="_blank">brad@lowekamp.net</a>>, SPL Slicer Devel <<a href="mailto:slicer-devel@bwh.harvard.edu" target="_blank">slicer-devel@bwh.harvard.edu</a>>, Insight Developers <<a href="mailto:insight-developers@itk.org" target="_blank">insight-developers@itk.org</a>><div><div class="h5"><br>
<span style="font-weight:bold">Subject: </span>Re: [ITK-dev] [slicer-devel] build error in simpleitk<br>
</div></div></div><div><div class="h5">
<div><br>
</div>
<div>
<div>
<div dir="ltr">Brad, Hans: great, thanks!
<div><br>
</div>
<div>(as an aside: I would be happy to submit patches directly in the future, but it's not really clear why the Gerrit <-> GitHub KWRobot application asks for R/W on all GitHub repositories I have access to... It would be great if this could be reduced to the
minimal necessary privileges for authentication)</div>
<div><br>
</div>
<div>Isaiah</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 13, 2016 at 8:16 PM, Johnson, Hans J <span dir="ltr">
<<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word;color:rgb(0,0,0);font-size:14px;font-family:Calibri,sans-serif">
<div>
<div>I’m making a patch for this.</div>
<div><br>
</div>
<div>I’ve noticed this today as well.</div>
<div><br>
</div>
<div>mkdir XX;</div>
<div>cd XX;</div>
<div>cmake -DCMAKE_CXX_STANDARD:STRING=11 ../ITK; </div>
<div>make –j23</div>
<div><br>
</div>
<div>Before this patch, there was a build failure.</div>
<div>After this patch it is now building.</div>
<div><br>
</div>
<div>I made modifications to more closely match upstream VXL.</div>
<div><br>
</div>
<div>Gerrit- review at : <a href="http://review.source.kitware.com/#/c/20658" target="_blank">http://review.source.kitware.com/#/c/20658</a>/</div>
<div><br>
</div>
<div>Hans</div>
<div><br>
</div>
</div>
<span>
<div style="font-family:Calibri;font-size:12pt;text-align:left;color:black;BORDER-BOTTOM:medium none;BORDER-LEFT:medium none;PADDING-BOTTOM:0in;PADDING-LEFT:0in;PADDING-RIGHT:0in;BORDER-TOP:#b5c4df 1pt solid;BORDER-RIGHT:medium none;PADDING-TOP:3pt">
<span style="font-weight:bold">From: </span>Insight-developers <<a href="mailto:insight-developers-bounces@itk.org" target="_blank">insight-developers-bounces@itk.org</a>> on behalf of Bradley Lowekamp <<a href="mailto:brad@lowekamp.net" target="_blank">brad@lowekamp.net</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, January 13, 2016 at 6:38 PM<br>
<span style="font-weight:bold">To: </span>Isaiah Norton <<a href="mailto:isaiah.norton@gmail.com" target="_blank">isaiah.norton@gmail.com</a>><br>
<span style="font-weight:bold">Cc: </span>SPL Slicer Devel <<a href="mailto:slicer-devel@bwh.harvard.edu" target="_blank">slicer-devel@bwh.harvard.edu</a>>, Insight Developers <<a href="mailto:insight-developers@itk.org" target="_blank">insight-developers@itk.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [ITK-dev] [slicer-devel] build error in simpleitk<br>
</div>
<div>
<div>
<div><br>
</div>
<div>
<div dir="auto">
<div></div>
<div>Hello,</div>
<div><br>
</div>
<div>The patch looks pretty good. Thank you for contributing.</div>
<div><br>
</div>
<div>Can you please submit the patch to ITK Gerrit for review?</div>
<div><br>
</div>
<div><a href="http://www.itk.org/Wiki/ITK/Git/Develop" target="_blank">http://www.itk.org/Wiki/ITK/Git/Develop</a></div>
<div><br>
</div>
<div>Thanks</div>
<div>Brad</div>
<div><br>
On Jan 13, 2016, at 6:47 PM, Isaiah Norton <<a href="mailto:isaiah.norton@gmail.com" target="_blank">isaiah.norton@gmail.com</a>> wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<div dir="ltr">
<div>(cc: insight-devel)</div>
<div><br>
</div>
<div>We are also seeing this issue, and several SimpleITK dashboards are failing with the same error for the OS X 10.9 (since bumping to ITK 4.9) and 10.10 (since yesterday) dashboards:</div>
<div><a href="https://open.cdash.org/buildSummary.php?buildid=4188623" target="_blank">https://open.cdash.org/buildSummary.php?buildid=4188623</a><br>
</div>
<div><br>
</div>
<div>It looks like this is essentially caused by SimpleITK being compiled with `-std=c++11`, whereas ITK (and VXL) are not. So, there is a mismatch between the configured definition of `VCL_CONSTEXPR` and the `<span style="font-size:12.8px">VCL_STATIC_CONST_INIT_*</span><span style="font-size:12.8px">`
macros.</span><br>
</div>
<div><span style="font-size:12.8px"><br>
</span></div>
<div><span style="font-size:12.8px">For reference, VCL_CONSTEXPR was introduced here:</span></div>
<div><span style="font-size:12.8px"><a href="http://review.source.kitware.com/#/c/20386/" target="_blank">http://review.source.kitware.com/#/c/20386/</a></span><br>
</div>
<div><br>
</div>
<div>A proposed patch [1] is attached.</div>
<div><br>
</div>
<div>Best,</div>
<div>Isaiah</div>
<div><br>
</div>
<div>[1] <a href="https://github.com/ihnorton/ITK/commit/0f748d8c86ffb2369c3a343c0db5ca87b067843e" target="_blank">
https://github.com/ihnorton/ITK/commit/0f748d8c86ffb2369c3a343c0db5ca87b067843e</a><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jan 11, 2016 at 11:21 AM, Steve Pieper <span dir="ltr">
<<a href="mailto:pieper@isomics.com" target="_blank">pieper@isomics.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr">
<p><span>Hi - </span></p>
<p><span>This morning with Xcode 7.2 on mac 10.11.2 I get the build errors pasted below. This was in a fresh build directory. With SimpleITK turned off the build completes and everything works as expected.</span></p>
<p><span>I found an old issue with similar errors [1] but nothing lately. </span></p>
<p><span>-Steve</span></p>
<p><span>[1] <a href="https://issues.itk.org/jira/browse/ITK-2976" target="_blank">
https://issues.itk.org/jira/browse/ITK-2976</a><br>
</span></p>
<p><span><br>
</span></p>
<p><span><br>
</span></p>
<p><br>
</p>
<p><span>In file included from /Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_c_vector.h:26:</span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:388:41:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'zero' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR float zero VCL_STATIC_CONST_INIT_FLOAT_DECL(0.0F);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:390:41:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'one' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR float one VCL_STATIC_CONST_INIT_FLOAT_DECL(1.0F);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:392:41:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'maxval' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR float maxval VCL_STATIC_CONST_INIT_FLOAT_DECL(3.40282346638528860e+38F);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:411:42:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'zero' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR double zero VCL_STATIC_CONST_INIT_FLOAT_DECL(0.0);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:413:42:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'one' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR double one VCL_STATIC_CONST_INIT_FLOAT_DECL(1.0);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:415:42:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'maxval' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR double maxval VCL_STATIC_CONST_INIT_FLOAT_DECL(1.7976931348623157E+308);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:434:47:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'zero' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR long double zero VCL_STATIC_CONST_INIT_FLOAT_DECL(0.0);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:436:47:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'one' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR long double one VCL_STATIC_CONST_INIT_FLOAT_DECL(1.0);</span></p>
<p><span><b> ^</b></span></p>
<p><span><b>/Users/pieper/slicer4/latest/Slicer-superbuild/ITKv4/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:438:47:
</b></span><span><b>error: </b></span><span><b>declaration of constexpr static data member</b></span></p>
<p><span><b> 'maxval' requires an initializer</b></span></p>
<p><span> static VNL_EXPORT VCL_CONSTEXPR long double maxval VCL_STATIC_CONST_INIT_FLOAT_DECL(1.7976931348623157E+308);</span></p>
<p><span><b> ^</b></span></p>
<p><span>9 errors generated.</span></p>
<p><span>make[8]: *** [Code/Explicit/src/CMakeFiles/SimpleITKExplicit.dir/sitkExplicitITKComposeImageFilter.cxx.o] Error 1</span></p>
<p><span>make[7]: *** [Code/Explicit/src/CMakeFiles/SimpleITKExplicit.dir/all] Error 2</span></p>
<p><span>make[6]: *** [all] Error 2</span></p>
<p><span>make[5]: *** [SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2</span></p>
<p><span>make[4]: *** [CMakeFiles/SimpleITK.dir/all] Error 2</span></p>
<p><span>make[3]: *** [all] Error 2</span></p>
<p><span>make[2]: *** [SimpleITK-prefix/src/SimpleITK-stamp/SimpleITK-build] Error 2</span></p>
<p><span>make[1]: *** [CMakeFiles/SimpleITK.dir/all] Error 2</span></p>
<p><span>make: *** [all] Error 2</span></p>
</div>
</div>
<br>
_______________________________________________<br>
slicer-devel mailing list<br>
<a href="mailto:slicer-devel@bwh.harvard.edu" target="_blank">slicer-devel@bwh.harvard.edu</a><br>
<a href="http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel" rel="noreferrer" target="_blank">http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel</a><br>
To unsubscribe: send email to <a href="mailto:slicer-devel-request@bwh.harvard.edu" target="_blank">
slicer-devel-request@bwh.harvard.edu</a> with unsubscribe as the subject<br>
<a href="http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ" rel="noreferrer" target="_blank">http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ</a><br>
<br>
<br>
The information in this e-mail is intended only for the person to whom it is<br>
addressed. If you believe this e-mail was sent to you in error and the e-mail<br>
contains patient information, please contact the Partners Compliance HelpLine at<br>
<a href="http://www.partners.org/complianceline" rel="noreferrer" target="_blank">http://www.partners.org/complianceline</a> . If the e-mail was sent to you in error<br>
but does not contain patient information, please contact the sender and properly<br>
dispose of the e-mail.<br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<blockquote type="cite">
<div><0001-COMP-fix-build-with-std-c-11-when-ITK-VXL-initially-.patch></div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>slicer-devel mailing list</span><br>
<span><a href="mailto:slicer-devel@bwh.harvard.edu" target="_blank">slicer-devel@bwh.harvard.edu</a></span><br>
<span><a href="http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel" target="_blank">http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel</a></span><br>
<span>To unsubscribe: send email to <a href="mailto:slicer-devel-request@bwh.harvard.edu" target="_blank">
slicer-devel-request@bwh.harvard.edu</a> with unsubscribe as the subject</span><br>
<span><a href="http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ" target="_blank">http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ</a></span><br>
<span></span><br>
<span></span><br>
<span>The information in this e-mail is intended only for the person to whom it is</span><br>
<span>addressed. If you believe this e-mail was sent to you in error and the e-mail</span><br>
<span>contains patient information, please contact the Partners Compliance HelpLine at</span><br>
<span><a href="http://www.partners.org/complianceline" target="_blank">http://www.partners.org/complianceline</a> . If the e-mail was sent to you in error</span><br>
<span>but does not contain patient information, please contact the sender and properly</span><br>
<span>dispose of the e-mail.</span><br>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</span><br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div></div></span><div><div class="h5"><br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div></div></div>
</blockquote></div><br></div>