<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Bill,
<div class=""><br class="">
</div>
<div class="">Thank you for fixing the WikiExamples.</div>
<div class=""><br class="">
</div>
<div class="">I would recommend copying the “.gitignore” file from the ITK repository to the ITKWikiExamples repository, and then remove the *.pyc files from the master branch.</div>
<div class=""><br class="">
</div>
<div class="">Hans</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div apple-content-edited="true" class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
========================================================================<br class="">
Hans J. Johnson, Ph.D., Associate Professor <br class="">
Electrical and Computer Engineering (Primary), Biomedical Engineering, Psychiatry <br class="">
<a href="mailto:hans-johnson@uiowa.edu" class="">hans-johnson@uiowa.edu</a> <br class="">
(319) 621 7185 (cell)<br class="">
(319) 384 3538 ECE Phone (Primary)<br class="">
(319) 353 8587 Psychiatry Phone (Secondary)<br class="">
<br class="">
4316 Seamans Center<br class="">
Iowa City, IA 52242</div>
</div>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jul 7, 2015, at 11:08 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" class="">bill.lorensen@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">I agree with Matt... We need to avoid these suprises.<br class="">
<br class="">
Bill<br class="">
<br class="">
On Tue, Jul 7, 2015 at 11:45 AM, Matt McCormick<br class="">
<<a href="mailto:matt.mccormick@kitware.com" class="">matt.mccormick@kitware.com</a>> wrote:<br class="">
<blockquote type="cite" class="">The examples and apps highlight that this will be a headache for<br class="">
pre-existing code. We could ensure a smooth transition by overloading<br class="">
the SetFixedParameters methods with a backwards compatible versions<br class="">
that accept ParametersType. This would prevent build errors. These<br class="">
overloaded methods could also emit a warning that points to a<br class="">
migration guide entry on why and how to upgrade the code.<br class="">
<br class="">
2 cents,<br class="">
Matt<br class="">
<br class="">
On Tue, Jul 7, 2015 at 10:17 AM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com" class="">bill.lorensen@gmail.com</a>> wrote:<br class="">
<blockquote type="cite" class="">Thanks. Works for me.<br class="">
<br class="">
Is this documented in the migration guide or somewhere else?<br class="">
<br class="">
Bill<br class="">
<br class="">
<br class="">
On Tue, Jul 7, 2015 at 9:34 AM, Johnson, Hans J <<a href="mailto:hans-johnson@uiowa.edu" class="">hans-johnson@uiowa.edu</a>> wrote:<br class="">
<blockquote type="cite" class="">Bill,<br class="">
<br class="">
After several T-Con discussions and e-mails, it was determined that there<br class="">
was no way to preserve backwards and forwards compatibility for fixing this<br class="">
bug.<br class="">
<br class="">
Here is the solution that is inplace for ANTs and Slicer (NOTE BRAINSTools,<br class="">
DTIPrep, DTIProcess, DTIReg, UKFTractography, SimpleITK, and many other<br class="">
tools needed no modifications).<br class="">
<br class="">
#if defined(ITK_FIXED_PARAMETERS_ARE_DOUBLE) // After 4.8.1<br class="">
typename BSplineTransformType::FixedParametersValueType<br class="">
transformFixedParamsItk;<br class="">
#else //Pre 4.8.1<br class="">
typename BSplineTransformType::ParametersType transformFixedParamsItk;<br class="">
#endif<br class="">
<br class="">
Hans<br class="">
<br class="">
========================================================================<br class="">
Hans J. Johnson, Ph.D., Associate Professor<br class="">
Electrical and Computer Engineering (Primary), Biomedical Engineering,<br class="">
Psychiatry<br class="">
<a href="mailto:hans-johnson@uiowa.edu" class="">hans-johnson@uiowa.edu</a><br class="">
(319) 621 7185 (cell)<br class="">
(319) 384 3538 ECE Phone (Primary)<br class="">
(319) 353 8587 Psychiatry Phone (Secondary)<br class="">
<br class="">
4316 Seamans Center<br class="">
Iowa City, IA 52242<br class="">
<br class="">
On Jul 7, 2015, at 7:48 AM, Bill Lorensen <bill.lorensen@gmail.com> wrote:<br class="">
<br class="">
Hans,<br class="">
<br class="">
There is a problem with the change. My code will no longer build with<br class="">
older versions of ITK.<br class="">
I get:<br class="">
<br class="">
ITKWikiExamplesNightly/Utilities/FileOutputWindow.cxx:23: error:<br class="">
'FixedParametersType' is not a member of 'main(int,<br class="">
char**)::TransformType'<br class="">
<br class="">
This is not good, unless I'm noising something...<br class="">
<br class="">
On Mon, Jul 6, 2015 at 4:23 PM, Bill Lorensen <bill.lorensen@gmail.com><br class="">
wrote:<br class="">
<br class="">
Hans,<br class="">
<br class="">
That was the problem. Just a surprise for me.<br class="">
<br class="">
Bill<br class="">
<br class="">
<br class="">
On Mon, Jul 6, 2015 at 8:46 AM, Johnson, Hans J <hans-johnson@uiowa.edu><br class="">
wrote:<br class="">
<br class="">
Bill,<br class="">
<br class="">
The problem is almost certainly that the variable “parameters” is of type<br class="">
“ParametersType” rather than “FixedParametersType”.<br class="">
<br class="">
// The ITK_FIXED_PARAMETERS_ARE_DOUBLE is intended<br class="">
// to facilitate transition of ITK for those very<br class="">
// rare cases where multiple versions of ITK<br class="">
// may need to be supported simultaneously.<br class="">
#if defined( ITK_LEGACY_REMOVE )<br class="">
#undef ITK_FIXED_PARAMETERS_ARE_DOUBLE<br class="">
#else<br class="">
#define ITK_FIXED_PARAMETERS_ARE_DOUBLE<br class="">
// #if !defined(ITK_FIXED_PARAMETERS_ARE_DOUBLE)<br class="">
// typedef ParametersValueType FixedParametersValueType;<br class="">
// #endif<br class="">
#endif<br class="">
<br class="">
<br class="">
Hans<br class="">
<br class="">
<br class="">
<br class="">
On Jul 6, 2015, at 6:52 AM, Bill Lorensen <bill.lorensen@gmail.com> wrote:<br class="">
<br class="">
Folks,<br class="">
<br class="">
Something in this commit<br class="">
<br class="">
https://open.cdash.org/viewChanges.php?project=Insight&date=2015-07-04<br class="">
<br class="">
is causing these errors:<br class="">
<br class="">
https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=3887517<br class="">
<br class="">
and<br class="">
<br class="">
https://open.cdash.org/viewBuildError.php?onlydeltap&buildid=3887806<br class="">
<br class="">
Bill<br class="">
--<br class="">
Unpaid intern in BillsBasement at noware dot com<br class="">
_______________________________________________<br class="">
Powered by www.kitware.com<br class="">
<br class="">
Visit other Kitware open-source projects at<br class="">
http://www.kitware.com/opensource/opensource.html<br class="">
<br class="">
Kitware offers ITK Training Courses, for more information visit:<br class="">
http://kitware.com/products/protraining.php<br class="">
<br class="">
Please keep messages on-topic and check the ITK FAQ at:<br class="">
http://www.itk.org/Wiki/ITK_FAQ<br class="">
<br class="">
Follow this link to subscribe/unsubscribe:<br class="">
http://public.kitware.com/mailman/listinfo/insight-developers<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
________________________________<br class="">
Notice: This UI Health Care e-mail (including attachments) is covered by the<br class="">
Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential<br class="">
and may be legally privileged. If you are not the intended recipient, you<br class="">
are hereby notified that any retention, dissemination, distribution, or<br class="">
copying of this communication is strictly prohibited. Please reply to the<br class="">
sender that you have received the message in error, then delete it. Thank<br class="">
you.<br class="">
________________________________<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
--<br class="">
Unpaid intern in BillsBasement at noware dot com<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
--<br class="">
Unpaid intern in BillsBasement at noware dot com<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
________________________________<br class="">
Notice: This UI Health Care e-mail (including attachments) is covered by the<br class="">
Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential<br class="">
and may be legally privileged. If you are not the intended recipient, you<br class="">
are hereby notified that any retention, dissemination, distribution, or<br class="">
copying of this communication is strictly prohibited. Please reply to the<br class="">
sender that you have received the message in error, then delete it. Thank<br class="">
you.<br class="">
________________________________<br class="">
</blockquote>
<br class="">
<br class="">
<br class="">
--<br class="">
Unpaid intern in BillsBasement at noware dot com<br class="">
_______________________________________________<br class="">
Powered by <a href="http://www.kitware.com" class="">www.kitware.com</a><br class="">
<br class="">
Visit other Kitware open-source projects at<br class="">
<a href="http://www.kitware.com/opensource/opensource.html" class="">http://www.kitware.com/opensource/opensource.html</a><br class="">
<br class="">
Kitware offers ITK Training Courses, for more information visit:<br class="">
http://kitware.com/products/protraining.php<br class="">
<br class="">
Please keep messages on-topic and check the ITK FAQ at:<br class="">
http://www.itk.org/Wiki/ITK_FAQ<br class="">
<br class="">
Follow this link to subscribe/unsubscribe:<br class="">
http://public.kitware.com/mailman/listinfo/insight-developers<br class="">
_______________________________________________<br class="">
Community mailing list<br class="">
Community@itk.org<br class="">
http://public.kitware.com/mailman/listinfo/community<br class="">
</blockquote>
</blockquote>
<br class="">
<br class="">
<br class="">
-- <br class="">
Unpaid intern in BillsBasement at noware dot com<br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</body>
</html>