<div dir="ltr">Hi Brad,<div><br></div><div>Yes, that one (and its parent).</div><div><br></div><div>I did in fact pull the patch and compile it without any issues. I ran the related tests too, which passed. But it seemed to me that I couldn't give a "Verify" score alone and had to give a "Code Review" score as well. Matt's reply has made it clearer now. Thanks!</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 4:43 PM, Bradley Lowekamp <span dir="ltr"><<a href="mailto:blowekamp@mail.nih.gov" target="_blank">blowekamp@mail.nih.gov</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Girish,<br>
<br>
I assume you are talking about this patch:<br>
<a href="http://review.source.kitware.com/#/c/16868/" target="_blank">http://review.source.kitware.com/#/c/16868/</a><br>
<br>
Thanks again for contributing the patch which demonstrated the bug you encountered.<br>
<br>
For this particular case I would encourage you to download, checkout, and compile the patch and verify that is resolves the issue you initially encountered. Then report back if it fixes the problem.<br>
<br>
Brad<br>
<div><div class="h5"><br>
On Sep 4, 2014, at 11:29 AM, Girish Mallya Udupi <<a href="mailto:indianzeppelin@gmail.com">indianzeppelin@gmail.com</a>> wrote:<br>
<br>
> Hello,<br>
><br>
> I have a couple of questions about the Gerrit review process -<br>
><br>
> 1) Is the creator of a topic automatically added as a reviewer on subsequent patches in the topic?<br>
><br>
> 2) As a reviewer, if I am unable to understand the changes made to the code (simply because I am not an advanced programmer), should I leave the patch unscored?<br>
><br>
</div></div>> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/insight-developers" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Regards,<br>Girish</div>
</div>