[ITK-dev] [ITK] Recent changes have introduced valgrind defects

Matt McCormick matt.mccormick at kitware.com
Wed Aug 19 12:55:38 EDT 2015


On Wed, Aug 19, 2015 at 11:57 AM, Luc Hermitte <luc.hermitte at c-s.fr> wrote:
>>> Recent changes have caused valgrid defects:
>>> https://open.cdash.org/viewDynamicAnalysis.php?buildid=3962722
>> These are probably related to this change:
>>
>>   http://review.source.kitware.com/#/c/19962/
>>

> The tests on lines 160, 166, and 172 are incorrect. After the SetSize,
> the value x[0] is left uninitialized on purpose. It could be equal to
> ref[0].
> Instead, we should test that x[0] is uninitialized. But I don't know any
> way to do it.

In that case, please remove them.


> I'll comment these lines for my next commit (on C++ rvalue references)
> if it's OK with you.

Please keep the patches divided by subject if possible.


Is there a different issue causing the defect in
itkImageToVectorImageFilterTest?

Thanks,
Matt


More information about the Insight-developers mailing list