[Insight-developers] Clearly something is wrong with ITKv4 multi-threading

Johnson, Hans J hans-johnson at uiowa.edu
Tue Sep 24 09:55:32 EDT 2013


Kent,

I'm at the MICCAI conference and was able to do some diagnosis in the down
 time today.  I believe that I have a patch that DRASTICALLY improves the
performance of the test case while preserving the numerical results.

Old   Code 3414 seconds
Fixed Code   90 seconds  <-- Yes 90 seconds.

It's late here in Japan, so I need to do some more validation and style
cleanup, but I hope to submit a patch tomorrow.

What I need from you today is that you address the comment in the gerrit
patch I pushed over the weekend.  Matt and Brad both had comments on ways
to improve style for consistency.  Once you have a new pull request in
place, I'll rebase my changes on those.

Hans

On 9/24/13 10:49 PM, "Williams, Norman K" <norman-k-williams at uiowa.edu>
wrote:

>This is interesting diagnostic work.
>
>If the problem is threads sharing a smart pointer to a transform, could
>they instead share a plain old const pointer to the transform?  The
>threads aren't all modifying the transform, are they?
>--
>Kent Williams norman-k-williams at uiowa.edu
>
>



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________


More information about the Insight-developers mailing list