[Insight-developers] ITK fails to configure

[Xiaoxiao Liu]

Luis,

That patch you merged was based on the ITK two days ago , in which
 IO-Spatialobject (llittle o) was added to  a module's dependency list
(while adding some testing dependencies)
And an earlier patch merged yesterday changed the module name
IO-Spatialobject (little o)  to IO-SpatialObject (big o), which is causing
the problem.

When you get the patch to your local machine, there should not be any
configuration errors.  When you merge this patch today, it won't show any
conflict neither.
I should have made one patch depending on the other  to avoid this.  I was
trying to make my gerrit patches be as stand-alone as possible.

I guess the best way to prevent from happening again is  to always rebasing
the patch on the latest master and test it before merging.
What do you think?




On Fri, Mar 25, 2011 at 8:48 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Perhaps cmake did not flag it as an error.
>
>
> On Fri, Mar 25, 2011 at 7:50 PM, Luis Ibanez <luis.ibanez at kitware.com>wrote:
>
>> Hi Bill,
>>
>> Thanks a lot for fixing it.
>>
>> I'm trying to understand why this configuration problem
>> didn't appear when I reviewed that patch.
>>
>> I probably messed up something...
>>
>>
>>     Luis
>>
>>
>> --------------------------------
>> On Fri, Mar 25, 2011 at 6:54 PM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>> > I just merged a fix.
>> >
>> > On Fri, Mar 25, 2011 at 6:35 PM, Bill Lorensen <bill.lorensen at gmail.com
>> >
>> > wrote:
>> >>
>> >> This checkin
>> >> http://www.cdash.org/CDash/viewUpdate.php?buildid=920110
>> >> is causing this config problem:
>> >> http://www.cdash.org/CDash/viewConfigure.php?buildid=920110
>> >>
>> >> Please fix before tonight's dashboards.
>> >>
>> >
>> >
>> > _______________________________________________
>> > Powered by www.kitware.com
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Kitware offers ITK Training Courses, for more information visit:
>> > http://kitware.com/products/protraining.html
>> >
>> > Please keep messages on-topic and check the ITK FAQ at:
>> > http://www.itk.org/Wiki/ITK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://www.itk.org/mailman/listinfo/insight-developers
>> >
>> >
>>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>


-- 
---------------------------------------------
*Xiaoxiao Liu*, Ph.D.
R & D Engineer
Kitware Inc <http://www.kitware.com/>.
Clifton Park, NY
Phone: (518) 881-4924  or  (518) 371-3971 x124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110325/14699fa7/attachment.htm>