[Insight-developers] Gerrit changes prior to modularization

Brad King brad.king at kitware.com
Fri Mar 11 10:48:49 EST 2011


Hi Folks,

There are a number of changes under review here:

  http://review.source.kitware.com/p/ITK

that were based on monolithic ITK prior to the modularization.  Due to
the major tree layout re-organization it is unlikely that any of these
will merge cleanly.  While Git's rename detection will help the merge
process apply changes made to existing files in their new location,
there are other problems:

(1) Any changes to CMakeLists.txt files will be broken because all the
old files have been removed.

(2) Any new files added cannot be magically moved into the appropriate
module by "git merge".  New files must be placed in a human-chosen
module, and perhaps discussed on this list to decide which one.

Therefore most of the changes under review will need to be rewritten
based on the modularized tree layout (i.e. started again from master).
I will review each of them and make comments accordingly.

-Brad


More information about the Insight-developers mailing list