[Insight-developers] Change in ITK[master]: COMP: fix warnings about hidden method SetNumberOfThreads

David Doria daviddoria at gmail.com
Sat Jun 11 16:35:47 EDT 2011


On Sat, Jun 11, 2011 at 4:29 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> FYI: I just posted a patch with another 40 files that need changing:
> http://review.source.kitware.com/#change,1857
> As the commit message says:
> "This and related topics illustrate a lesson to be learned: Nothing is
> simple nor inexpensive."
>
> Bill

That is certainly one good lesson. Another one is try not to have a
system that says "everything is ok, go ahead and merge" when that is
not the case! The days of "watch the dashboard" should be over - it
should be almost certain that a patch will not cause problems BEFORE
it is merged. Of course you can't test every possible system
configuration, but these errors seem to be on common systems.

David


More information about the Insight-developers mailing list