[Insight-developers] Languishing Gerrit Top For SystemPNG

[Bill Lorensen]

Mine sets PNG_INCLUDE_DIR not PNG_INCLUDE_DIRS

On Fri, Jun 10, 2011 at 3:15 PM, Williams, Norman K
<norman-k-williams at uiowa.edu> wrote:
> Look at the FindPNG.cmake for your installed CMake on that machine -- does
> it set PNG_INCLUDE_DIRS anywhere? That's what my patch changed.
>
>
> The only way this should work is if png.h lives in your default include
> search path -- /usr/include /usr/local/include etc.  On my main machine
> (OS X) it's in /usr/X11R6/include for some "APPLE THINKS DIFFERENT" reason.
>
>
> On 6/10/11 1:56 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>
>>OK, without your patch, I just built against a libpng 1.2.44. No
>>problems... I did not run into the cmake issue you mentioned.
>>
>>
>>On Fri, Jun 10, 2011 at 2:53 PM, Bill Lorensen <bill.lorensen at gmail.com>
>>wrote:
>>> Kent,
>>>
>>> As long as we're running a tab, I'll try to use the system libpng on
>>> my Fedora 12 system.
>>>
>>> Bill
>>>
>>> On Fri, Jun 10, 2011 at 12:16 PM, Williams, Norman K
>>> <norman-k-williams at uiowa.edu> wrote:
>>>> See: http://review.source.kitware.com/#change,1758
>>>>
>>>>
>>>> This patch does two things:
>>>>
>>>> 1. There's a typo in Modules/ThirdParty/PNG/CMakeLists.txt that means
>>>> USE_SYSTEM_PNG was 100% broken -- PNG_INCLUDE_DIRS is used instead of
>>>> PNG_INCLUDE_DIR, which is what the PNG CMake module defines.
>>>>
>>>> 2. ITK's version is quite old -- there's an API change that needs to be
>>>>   accomodated, and in the latest revision, PNG makes its data
>>>>structures
>>>>   private, and access to structure members goes through access
>>>>functions.
>>>>
>>>> I did this work a week ago and Bill Lorensen was the only person to
>>>>review
>>>> the patch. He pointed out that there's no test added for the patch,
>>>>but I
>>>> don't know how you'd write a test for USE_SYSTEM_<LIB>.
>>>>
>>>> I would like to merge this patch. Can someone else have a look?
>>>>
>>>> The other alternative is to remove USE_SYSTEM_PNG as an option, and
>>>>always
>>>> use the ITK-internal version.
>>>>
>>>>
>>>>
>>>> ________________________________
>>>> Notice: This UI Health Care e-mail (including attachments) is covered
>>>>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>>>confidential and may be legally privileged.  If you are not the
>>>>intended recipient, you are hereby notified that any retention,
>>>>dissemination, distribution, or copying of this communication is
>>>>strictly prohibited.  Please reply to the sender that you have received
>>>>the message in error, then delete it.  Thank you.
>>>> ________________________________
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>
>>>
>
>
>
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
> ________________________________
>