[Insight-developers] imageToImageFilter exception

[Bradley Lowekamp]

Nick,

Bill already has a patch with the filter in question:
http://review.source.kitware.com/#change,2143

That is absolutely correct that overriding the protected method with a null implementation is the way to go. The documentation of the method indicates as much, if this was not clear by the documentation of the method please help us clarify.

One reason to choose overloading the method as opposed to some internal IVAR, is that it will be better self documenting. By overloading the method in your class a providing, a reasonable comment, it should show up in the doxygen letting the advanced users know that it does not need to have the same physical location of the images.

With this being said I much prefer the way Bill did this then I did in the original commit, with the documentation in the header. I should change the other over-ridden VerifyInputInformation methods to follow suit.

Brad

On Jul 20, 2011, at 5:05 PM, Nick Tustison wrote:

> Perfect.   Thanks for letting me know.  
> 
> On Wed, Jul 20, 2011 at 5:03 PM, M Stauffer (V) <mstauff at verizon.net> wrote:
> From what I saw, filters that don't want this verification override it
> with a null method. It's already been done for serveral filters. Or are
> you wanting a class to optionally provide this verification?
> 
> >-----Original Message-----
> >From: insight-developers-bounces at itk.org
> >[mailto:insight-developers-bounces at itk.org] On Behalf Of
> >Nicholas Tustison
> >Sent: Wednesday, July 20, 2011 4:32 PM
> >To: ITK Developers
> >Subject: [Insight-developers] imageToImageFilter exception
> >
> >Hello,
> >
> >I'm aware of the recent verification that input images occupy
> >the same physical
> >space for derivative classes of the ImageToImageFilter.
> >Although I can see
> >where it should be the default behavior, it doesn't seem like
> >it should be a
> >universal requirement for all cases.   Specifically, for the
> >itkHistogramMatchingImageFilter, it seems to me that this physical
> >space requirement is not relevant if all I want to do is make
> >sure that the
> >intensity histograms between two images match.   Is there a
> >way to write
> >an explicit exemption for certain cases, i.e. something in the
> >constructor
> >like
> >
> >this->SetRequiredNumberOfInputs( 2 );
> >this->SetInputVerification( false );
> >
> >Thanks,
> >Nick
> >_______________________________________________
> >Powered by www.kitware.com
> >
> >Visit other Kitware open-source projects at
> >http://www.kitware.com/opensource/opensource.html
> >
> >Kitware offers ITK Training Courses, for more information visit:
> >http://kitware.com/products/protraining.html
> >
> >Please keep messages on-topic and check the ITK FAQ at:
> >http://www.itk.org/Wiki/ITK_FAQ
> >
> >Follow this link to subscribe/unsubscribe:
> >http://www.itk.org/mailman/listinfo/insight-developers
> 
> 
> _______________________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110720/bd218f68/attachment.htm>