[Insight-developers] My first Gerrit review

[Ivan Macia]

Dear all,

I received an invitation from Bradley Lowekamp for a review so I followed
the instructions here:
http://itk.org/Wiki/ITK/Gerrit/ReviewPrimer

After reviewing the code and testing (copied and run the fetch command) I
clicked on the Review button and added some comments and scoring. However, I
don't have any "Verified" section below the "Code Review" section for
scoring as it is displayed here:
http://itk.org/Wiki/ITK/Gerrit/ReviewPrimer#Score_the_change_with_comments

Then, after scoring "Code Review" adding my comment and clicking, my comment
is published but I don't see any indication in the reviewer list that I have
finished the review process (I did this on patch set 3 which is the last one
for this change).

Finally here is some information on how to push to the official repository.
Should this be here in the information for reviewers? Shouldn't this be a
task for the person who created the topic?
http://itk.org/Wiki/ITK/Gerrit/ReviewPrimer#If_the_change_is_ready.2C_push_it_into_the_official_repository

Do I need to do something else in all this process?

Sorry I just started with all this git + gerrit thing and feel a bit lost
(and stupid). Git is complicated enough by itself but adding Gerrit
complicates the process. However, I understand is a very nice feature to
have :) Btw thanks to the people who made the instructions, they are very
complete.

Another suggestion would be to have some kind of "dictionary" of git-gerrit
terms in the wiki. It is easy to get lost with all the terms (specially for
non native English speakers) and sometimes the differences are subtle.

Best regards

Ivan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110130/62662d1b/attachment.htm>