[Insight-developers] module dependency issue

[brian avants]

hi nick

i'm good with it ---- can't think of any reason why not ...

also, the revised MI function is in RegRefCurrent (with a test) so you
should be able to switch in a BSpline transform (currently
displacement field is used) to help your testing of its jacobian etc.

beware though that i found a small probably memory-access or threading
bug that is not yet isolated.  i dont think it's in the metrics.
means that 1 / N runs will behave poorly.

brian




On Mon, Aug 22, 2011 at 8:34 AM, Nicholas Tustison <ntustison at gmail.com> wrote:
> That sounds good to me.  I'll wait and let Brian weigh in on the potential
> change and then I can proceed with a patch.
>
>
> On Aug 22, 2011, at 8:06 AM, Gaëtan Lehmann wrote:
>
>>
>> Hi Nick,
>>
>> I think it would make sense to move all the displacement field transform to a new module, for example ITKDisplacementFieldTransform.
>> That would help to fix the dependency issue with the ITKImageFunction module as well as this new one.
>>
>> Does that sound reasonable to you?
>>
>> Regards,
>>
>> Gaëtan
>>
>>
>> Le 22 août 11 à 13:49, Nicholas Tustison a écrit :
>>
>>> Hi Xiaoxiao,
>>>
>>> Thanks for taking a look at this.  The specific transform class in question
>>> is itkBSplineDisplacementFieldTransform which needs the class
>>> itkBSplineScatteredDataPointSetToImageFilter which resides in
>>> Filtering/ImageGrid/.  So is your suggestion to move the latter class to
>>> Core/Transform/?
>>>
>>> Thanks,
>>> Nick
>>>
>>>
>>> On Aug 21, 2011, at 9:10 PM, Xiaoxiao Liu wrote:
>>>
>>>> Hi Nick,
>>>>
>>>> If the transform class is not only specific to PICSL registration, it probably should be
>>>> a part of the ITKTransform module.
>>>> If so, how many new dependencies needs to be introduced to ITKTransform? And what are they?
>>>> You want to be careful not to introduce circular module dependencies during the process (CMake would warn you
>>>> , but it is better to figure out before doing it).
>>>>
>>>> -Xiaoxiao
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Sun, Aug 21, 2011 at 7:41 PM, Nicholas Tustison <ntustison at gmail.com> wrote:
>>>> Hi,
>>>>
>>>> Part of the PICSL registration refactoring includes the introduction of a
>>>> transform class which has a dependency outside of the Core/Transform
>>>> dependency scope.  What is done in this situation?
>>>>
>>>> Thanks,
>>>> Nick
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://kitware.com/products/protraining.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> ---------------------------------------------
>>>> Xiaoxiao Liu, Ph.D.
>>>> R & D Engineer
>>>> Kitware Inc.
>>>> Clifton Park, NY
>>>> Phone: (518) 881-4924  or  (518) 371-3971 x124
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>> --
>> Gaëtan Lehmann
>> Biologie du Développement et de la Reproduction
>> INRA de Jouy-en-Josas (France)
>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> http://mima2.jouy.inra.fr  http://www.itk.org
>> http://www.bepo.fr
>>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>