[Insight-developers] Bug fix to itkAutoCropLabelMapFilter

[Luis Ibanez]

Hi Navneeth,

This is great.

BTW: Please note that when accessing member variables
that are not simple types (int, float, char...), you must use
the macro:

                itkGetConstReferenceMacro()

instead of

                           itkGetMacro()


This has now been fixed:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/Review/itkAutoCropLabelMapFilter.h?root=Insight&r1=1.3&r2=1.4&sortby=date

and, as Bill pointed out,


Tests must be added for any new feature:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/Review/itkAutoCropLabelMapFilterTest1.cxx?root=Insight&r1=1.7&r2=1.8&sortby=date


Great job !


    Luis


---------------------------------------------------------------
On Fri, Jun 18, 2010 at 1:29 PM, Bill Lorensen <bill.lorensen at gmail.com>wrote:

> Great and congratulations.
>
> You should also consider modifying an existing test to exercise and
> validate the new methos.
>
> Bill
>
> On Fri, Jun 18, 2010 at 11:13 AM, Navneeth Subramanian
> <navneeth.s at gmail.com> wrote:
> > Hello,
> >
> > I just made my first commit to ITK, to fix a request to
> > itkAutoCropLabelMapFilter. Specifically, I've added Get functions to
> access
> > the calculated crop region.
> > See:
> >
> >
> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Review/itkAutoCropLabelMapFilter.txx?sortby=date&root=Insight&view=diff&r1=text&tr1=1.4&r2=text&tr2=1.3&diff_format=h
> >
> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Review/itkAutoCropLabelMapFilter.h?sortby=date&root=Insight&view=diff&r1=text&tr1=1.3&r2=text&tr2=1.2&diff_format=h
> >
> > This is in response to id: 0010513 in mantis.
> >
> > regards,
> > navneeth
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Kitware offers ITK Training Courses, for more information visit:
> > http://kitware.com/products/protraining.html
> >
> > Please keep messages on-topic and check the ITK FAQ at:
> > http://www.itk.org/Wiki/ITK_FAQ
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.itk.org/mailman/listinfo/insight-developers
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100619/11a13830/attachment.htm>