[Insight-developers] [master] Change Ica45be1d: (ITK) ENH: added an API for setting/getting the mask

[Daniel Blezek]

Uh, OK.  To answer my question, yes, this did work.  Gerrit marked the
change as merged and closed it.

Great,
-dan


On 8/27/10 4:17 PM, "Daniel Blezek" <blezek.daniel at mayo.edu> wrote:

> Hi Brad, Marcus,
> 
>   How does one go about doing this for a non-ITK repository?  I'd like to do
> this for the SimpleITK commits.  Do I just push changes into the master?
> 
> Thanks,
> -dan
> 
> 
> On 8/27/10 10:00 AM, "Brad King" <brad.king at kitware.com> wrote:
> 
>> On 08/27/2010 10:48 AM, Daniel Blezek wrote:
>>>   Brad L¹s patches were a mistake.  Gerrit only allows review of a
>>> single commit.  What Brad needed to do was ³squash² the commits into
>>> one, using rebase, or cherry-pick.  Then he should have submitted that
>>> single commit to Gerrit.  Brad King and Marcus Hanwell are looking into
>>> adding a branch-level review to Gerrit with the developers.
>> 
>> Meanwhile I do not think it hurts to push multi-commit topics for review.
>> Gerrit does track that one depends on others and/or is needed by others.
>> Once all the patches in the series have been approved then the whole
>> topic can be merged.
>> 
>>>   So I reviewed your change (recognizing it was exploratory), and marked
>>> it as verified.  I have no idea at all how to push into the main line.
>> 
>> Currently we have not configured Gerrit to merge or push to the main
>> repository.  It still needs to be done with a manual step.  Jim can
>> use the topic stage for this:
>> 
>>   http://www.itk.org/Wiki/ITK/Git#Topic_Stage
>> 
>> Assuming you've added the 'gerrit' and 'stage' remotes to your local
>> repository, run these commands:
>> 
>>  $ git fetch gerrit refs/changes/08/8/1:MaskImageFilterAPI
>>  $ git push stage MaskImageFilterAPI
>>  $ ssh git at itk.org stage ITK merge MaskImageFilterAPI
>> 
>> Marcus and I will look into whether we can get Gerrit to do this step.
>> If we set it up correctly we should be able to make a "Submit" button
>> appear for you (Jim) after the patch is reviewed and approved.  We
>> need to check on how this works with an upstream repository though.
>> 
>>>  We are doing the same in SimpleITK, but are stuck on how Gerrit will
>>> publish the change.  The plumbing has been put in place by Marcus, so
>>> Gerrit has write access to the SimpleITK github repo, but I don¹t know
>>> where the ³Push this to GitHub² button is...
>> 
>> Marcus will have to answer that one.
>> 
>> -Brad

-- 
Daniel Blezek, PhD
Medical Imaging Informatics Innovation Center

P 127 or (77) 8 8886
T 507 538 8886
E blezek.daniel at mayo.edu

Mayo Clinic
200 First St. S.W.
Harwick SL-44
Rochester, MN 55905
mayoclinic.org
"It is more complicated than you think." -- RFC 1925