[Insight-developers] ImageIORegion M-D to N-D conversion issues

[Bill Lorensen]

Remember that once we release it we won't change it.

On Wed, Feb 25, 2009 at 10:46 AM, Bradley Lowekamp
<blowekamp at mail.nih.gov> wrote:
> I made these changes yesterday, including adding the
> ImageIORegion::IsEqualWithRegionDimension method. I think they are right and
> good to go. It was nice because I had it wrong a couple more times and a
> test would fail :)
>
> I would like to get the minIndex maxIndex taken care of. But it is no worse
> then what has been there for a while, who wants to stream with miss matched
> dimensions?
>
> Brad
>
>
> On Feb 25, 2009, at 10:02 AM, Luis Ibanez wrote:
>
>> Bradley Lowekamp wrote:
>>>
>>> On Feb 24, 2009, at 5:36 PM, Luis Ibanez wrote:
>>>>
>>>> Feel free to go ahead an review the code for
>>>> min dimension. It will be great is you write
>>>> it using the methods above, that now have
>>>> bounds checking.
>>>
>>>
>>> Done:
>>>
>>> itkImageFileReaderTest2.cxx Revision: 1.1
>>>
>>> <http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/IO/itkImageFileReaderTest2.cxx?cvsroot=Insight&rev=1.1&view=markup>
>>>
>>> It's actually 2D or 3D to 4D, then 4D to 3D.
>>> For some of the file formats I was interested there was not a
>>> pre-existing 2D file. As long at the format support 4D images this test
>>> can be used.
>>>
>>>>
>> ---------
>>
>> Excellent !
>>
>> Thanks a lot for adding these tests.
>>
>> ---
>>
>> I'll suggest we hold on the external API changes of the ImageIORegion
>> for the day after the release. It is unlikely that we will get it right
>> in the 72 hours that we have left.
>>
>>
>> Would you agree ?
>>
>>
>>   Luis
>>
>>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>