[Insight-developers] KWStyle broken

Mon Feb 9 11:34:23 EST 2009

Hi Luis,

	It is the correct diagnosis for my version of KWStyle that I have. I  
spent too much time on it on Friday manually entering in KWStyle  
command and figuring out what's going on. Changing the -D argument and  
modifying the file showed me that this was the problem.

	In my first e-mail I referred to  ITKFiles.txt. In my second I  
mistakenly referred to Insight/Utilities/KWStyle/ITKOverwrite.txt.

	In my previous e-mail I was trying to get information about how long  
the KWStyle process executed for. I think that is the wrong  
information from the CDash build log.

This is why I conclude the KWStyleCodeTest is broken:

blowek1$ time ctest -V -R KWStyleCodeTest*
UpdateCTestConfiguration  from :/playpen/blowek1/InsightBuild/ 
DartConfiguration.tcl
Parse Config file:/playpen/blowek1/InsightBuild/DartConfiguration.tcl
  Add coverage exclude regular expressions.
Start processing tests
UpdateCTestConfiguration  from :/playpen/blowek1/InsightBuild/ 
DartConfiguration.tcl
Parse Config file:/playpen/blowek1/InsightBuild/DartConfiguration.tcl
Test project /playpen/blowek1/InsightBuild
Constructing a list of tests
Done constructing a list of tests
Changing directory into /playpen/blowek1/InsightBuild
   2/1484 Testing KWStyleCodeTest
Test command: /nfs/Mead/Users/blowek1/local/bin/KWStyle -xml /playpen/ 
blowek1/InsightBuild/Utilities/KWStyle/ITK.kws.xml -v -D /playpen/ 
blowek1/InsightBuild/Utilities/KWStyle/ITKFiles.txt -o /nfs/mead/Users/ 
blowek1/src/Insight/Utilities/KWStyle/ITKOverwrite.txt -vim
Test timeout computed to be: 1500
-- Process completed
    Passed
Changing directory into /playpen/blowek1/InsightBuild/Utilities/vxl/ 
vcl/tests
Changing directory into /playpen/blowek1/InsightBuild/Utilities/vxl/ 
v3p/netlib/tests
Changing directory into /playpen/blowek1/InsightBuild/Utilities/vxl/ 
core/testlib/tests
Changing directory into /playpen/blowek1/InsightBuild/Utilities/vxl/ 
core/vnl/algo/tests
Changing directory into /playpen/blowek1/InsightBuild/Utilities/vxl/ 
core/vnl/tests
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Numerics
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Numerics/Statistics
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Numerics/FEM
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Numerics/NeuralNetworks
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Common
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
BasicFilters
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Algorithms
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/IO
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
SpatialObject
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Patented
Changing directory into /playpen/blowek1/InsightBuild/Testing/Code/ 
Review
Changing directory into /playpen/blowek1/InsightBuild/Examples/Iterators
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
DataRepresentation/Image
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
DataRepresentation/Mesh
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
DataRepresentation/Path
Changing directory into /playpen/blowek1/InsightBuild/Examples/Filtering
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
Registration
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
Segmentation
Changing directory into /playpen/blowek1/InsightBuild/Examples/ 
Statistics
Changing directory into /playpen/blowek1/InsightBuild/Examples/Patented

The following tests passed:
	KWStyleCodeTest

100% tests passed, 0 tests failed out of 1

real	0m0.174s
user	0m0.115s
sys	0m0.048s

Where as the timing for the KWStyleReviewTest is:

real	0m32.119s
user	0m19.274s
sys	0m11.402s

Again it could be my version of KWStyle. I also check out the latest  
CVS on friday when I noticed that it was not working on Friday.

Brad

On Feb 9, 2009, at 11:14 AM, Luis Ibanez wrote:

>
> Hi Brad,
>
> I'm suspecting that this may have been misdiagnosed.
>
> My impression is that the globing actually works when
> the Style check is run from ctest.
>
> That is, when I'm checking style in Code/Common, this
> expression from ITKFiles is actually restricting the
> set of files that get to be checked for Style.
>
> In your email, you say that your file ITKOverwrite.txt
> is the one containing the glob regular expression.
>
> Is that right ?
>
> Shouldn't this expression be in the ITKFiles.txt file ?
>
> The ITKOverwrite.txt file is intended for exceptions
> to the rules.
>
>
> Please let us know,
>
>
>   Thanks
>
>
>      Luis
>
>
>
> ------------------------
> Bradley Lowekamp wrote:
>> Hello all,
>>
>> Did we ever come up with a solution to this problem?
>>
>> I can see it's on the dash board as this is the output of KWStyle:
>>
>> *Build command: *KWStyle
>> *Start Time: *2009-02-08T03:20:54 EST
>> *End Time: *2009-02-08T03:21:06 EST
>>
>> Brad
>>
>>
>> On Feb 4, 2009, at 4:17 PM, Julien Jomier wrote:
>>
>>> It seems that KWSys glob function doesn't recognize the 'itk[A- 
>>> H]*.txx'
>>> glob expression.
>>>
>>> Julien
>>>
>>> Bradley Lowekamp wrote:
>>>
>>>> Bill,
>>>
>>>>
>>>> I have the lastest CVS version of KWStyle and all the tests for it
>>>
>>>> passed. The file Insight/Utilities/KWStyle/ITKOverwrite.txt  
>>>> contains
>>>
>>>> line like the following:
>>>
>>>>
>>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk[A-H]*.txx
>>>
>>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk[A-H]*.cxx
>>>
>>>> ...
>>>
>>>>
>>>> My KWStyle is ignoring this type of globbing line,  when I swap  
>>>> it with:
>>>
>>>>
>>>> /nfs/mead/Users/blowek1/src/Insight/Code/Common/itk*.h
>>>
>>>>
>>>> it works fine. The cmake configuration file pass this file to  
>>>> KWStyle
>>>
>>>> with the -D argument.
>>>
>>>>
>>>> Brad
>>>
>>>>
>>>>
>>>> On Feb 4, 2009, at 4:02 PM, Bill Lorensen wrote:
>>>
>>>>
>>>>> Brad,
>>>
>>>>>
>>>>> Which file gave the problem?
>>>
>>>>>
>>>>> Bill
>>>
>>>>>
>>>>> On Wed, Feb 4, 2009 at 3:41 PM, Bradley Lowekamp
>>>
>>>>> <blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>> wrote:
>>>
>>>>>> Hello all,
>>>
>>>>>> I am not sure why but my KWStyle is not able to process the [A- 
>>>>>> Z] style
>>>
>>>>>> globbing in ITKFiles.txt. The behavior of KWStyle is to ignore  
>>>>>> those
>>>
>>>>>> expressions. So the make targets and the test are not really  
>>>>>> being
>>>
>>>>>> run for
>>>
>>>>>> these targets. Only CVS gave me errors when I tried to check in.
>>>
>>>>>> Brad
>>>
>>>>>>
>> ========================================================
>>
>> Bradley Lowekamp
>>
>> Lockheed Martin Contractor for
>>
>> Office of High Performance Computing and Communications
>>
>> National Library of Medicine
>>
>> blowekamp at mail.nih.gov <mailto:blowekamp at mail.nih.gov>
>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers

========================================================
Bradley Lowekamp
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine
blowekamp at mail.nih.gov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090209/ac52d675/attachment.htm>