[Insight-developers] Changes in ITKConfig.cmake

Sat Apr 5 19:17:56 EDT 2008

Hi Luis,

What makes you think I didn't ran the tests you're talking?
* I have built ITK and built a contribution to the insight journal  
with it on my linux system.
* I have installed ITK and built all my contributions the insight  
journal with it on my linux system.
* I have built ITK, packed and unpacked it, and built all my  
contributions to the insight journal with it on my mac.
* I have checked that the modified variable wasn't used anywhere in  
ITK and Insight Applications.
* Because that code is not mine, and also because we are close to a  
release, I took care to keep the changes as small as possible, and  
warned you (and the developers) about my changes, so they can be  
reviewed.
Maybe I should have also tried to build some others applications, and  
to test the installation on windows also.

I can be wrong, but I don't think that problem come from my changes.
My commit hasn't been the only one between the two builds. The log  
says something about Testing/Code/IO/CMakeLists.txt — perhaps  
something to try with that?

Please let me know if you find the problem, and all my apologies by  
advance if I'm responsible of it.

Gaëtan

Le 5 avr. 08 à 20:33, Luis Ibanez a écrit :
>
> Hi Gaetan,
>
> Your recent changes:
>
> http://public.kitware.com/cgi-bin/viewcvs.cgi/ITKConfig.cmake.in?root=Insight&r1=1.24&r2=1.25
>
> broke the installation process of ITK:
>
> See errors at:
> http://public.kitware.com/CDash/viewBuildError.php?buildid=43566
>
>
> Please compare the builds of zion.kitware  labeled:
>
>
> Linux-g++-4.1-vs-Installed
>
> between 2008-04-02 22:00:00 EDT (before your changes)
>
> and  2008-04-03 22:00:00 EDT (after your changes)
>
>
> We will review this with Brad on Monday and explore a way
> of making sure that the following combinations work:
>
>
> 1) Build ITK and build a project against the build ITK
> 2) Install ITK and build a project against the installed ITK
> 3) Pack ITK, unpack it, and build a project against the unpacked ITK
> 4) Build an Insight Journal project versus the ITK in the IJ server
>
> Please keep in mind that whenever we touch any of the variables
> involved in "ITKConfig.cmake", we should test all the combinations
> above, to make sure that they are still functional.
>
> In my recent changes, I verified (1),(2), and (3), but missed to
> verify (4).
>
>
>    Thanks
>
>
>           Luis
>
>
> -------------------------------------------------------------------------------------------------
> On Thu, Apr 3, 2008 at 11:28 AM, Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr 
> > wrote:
>
> Le 3 avr. 08 à 17:13, Luis Ibanez a écrit :
>
>
> Hi Gaetan,
>
> Did you checked whether this affected the settings
> when ITK is installed ?
>
> e.g. check that
>
>             "make install"
>
> still works after your changes ?
>
>
> Yes, and I have checked that ITK_INCLUDE_DIR was not used elsewhere  
> in ITK and InsightApplications.
>
>
>
> Also,
> could you please elaborate on the details of why
> ITK_INCLUDE_DIR was making the builds of the Insight
> Journal fail.
>
>
> That's because of that code from the IJMacros.txt:
>
>      #most packages define a Package_INCLUDE_DIR variable, so we'll  
> check for
>      #that first
>      IF(${Package}_INCLUDE_DIR)
>        INCLUDE(${${Package}_INCLUDE_DIR})
>        SET(Included TRUE)
>      ELSE(${Package}_INCLUDE_DIR)
>        #VTK and ITK prefer to define a Package_USE_FILE, so we need  
> to look for
>        #that too
>        IF(${Package}_USE_FILE)
>          INCLUDE(${${Package}_USE_FILE})
>          SET(Included TRUE)
>        ENDIF(${Package}_USE_FILE)
>      ENDIF(${Package}_INCLUDE_DIR)
>
> cmake never enter in the second part because ITK_INCLUDE_DIR is  
> defined, and so it doesn't include the ITK's use file.
>
> Gaëtan
>
>
>
>
>
>
>  Please let us know,
>
>
>    Thanks
>
>
>       Luis
>
>
> ---------------------
> Gaëtan Lehmann wrote:
> Hi Luis,
> I've just commited a change in ITKConfig.cmake.in to fix the build  
> of  the contributions to the Insight Journal.
> Defining ITK_INCLUDE_DIR was making them fail. I simply renamed it   
> ITK_MAIN_INCLUDE_DIR.
> You may want to review the changes though.
> Regards,
> Gaëtan
>
> -- 
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.mandriva.org
> http://www.itk.org  http://www.clavier-dvorak.org
>
>

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.mandriva.org
http://www.itk.org  http://www.clavier-dvorak.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20080406/fd62c415/attachment.pgp>