[Insight-developers] New classes names

Alexandre GOUAILLARD hanfei at caltech.edu
Fri Jul 20 18:23:37 EDT 2007


Hi all.

Can you share your comments about the names below for the Euler operators
for QuadEdge Mesh and for the vtk readers / writers ?


On 7/20/07 3:14 PM, "Luis Ibanez" <luis.ibanez at kitware.com> wrote:
> Hi Alex,
> 
>> For the naming convention of the file, I suggest: the following, is it a go?
>> itkQuadEdgeMeshEulerOperator<Name>Function

> The name for the function sounds good to me, but please, post this to
> the developers mailing list so other developers can also contribute
> opinions.

Done.

>> I was wondering why it only supports triangle mesh though. Is there a
>> reason, or I am free to add support for different kind of cells?

> About the itkVTKPolyDataReader, it only supports triangle cells, just
> because we were trying to keep it simple. Please feel free to add more
> cells, *as long as* you add test for the new functionalities, *and*
> make sure that previous tests are still passing. It is very common
> to inadvertently break previous functionalities when you are adding
> new ones.

Ok, I put that low in my todo list then.
> 
>> Note that the files we will commit in Insight Application (under the name
>> QuadEdgeMeshIO if it's fine with you) can read any kind of cell and can be
>> templated over the input type either by polydata or unsrtuctured grid (In
>> which case we only read 2-manifolds cells and drop the others.)

> The QuadEdgeMeshIO class sounds good too. You may want to put it
> under InsightApplications/Auxiliary/vtk.  Please do not create new
> directories, since with CVS is almost impossible to get rid of
> directories should we change our mind about where to put these
> classes.
> 
Ok, no new directories, just put it there.
This code is the one having two potential mem leak reported by valgrind. I
will adress that before commiting.

> 
>         Luis:




More information about the Insight-developers mailing list