[Insight-developers] Re: Recent include file reorg breaks backwardcompatibility

Lorensen, William E (GE, Research) lorensen at crd.ge.com
Tue Oct 3 14:35:45 EDT 2006


Yes, the "never intended for other use" use case. Unfortunately, if you
allow it, they will use it. We have to be very sensitive to this.

Bill
 

-----Original Message-----
From: insight-developers-bounces+lorensen=crd.ge.com at itk.org
[mailto:insight-developers-bounces+lorensen=crd.ge.com at itk.org] On
Behalf Of Brad King
Sent: Tuesday, October 03, 2006 2:23 PM
To: Bill Lorensen
Cc: Andy Cedilnik; Insight-developers; Steve Pieper
Subject: [Insight-developers] Re: Recent include file reorg breaks
backwardcompatibility

Bill Lorensen wrote:
> Done. That works great! See, it's not always hard to maintain backward

> compatibility. Just a little more thinking.

Actually I didn't even try for compatibility.  Those libraries were
never intended for use by outside projects.  From
Insight/Utilities/itkThirdParty.cmake before my recent changes:

# The in-tree third-party libraries are not exported.  We only need #
the include directory inside the tree.  If using a third-party # library
from the system, though, make sure the system include # directory is
consistent inside and outside the tree.

As a result projects that needed the libraries used hacks to get to
them.  I wasn't aware of anyone doing this.  My implementation to export
the libraries for real (a new feature) breaks those hacks.

Fortunately restoring them is easy.

> I'll add includes for the other renamed includes.

Good idea.

Thanks,
-Brad
_______________________________________________
Insight-developers mailing list
Insight-developers at itk.org
http://www.itk.org/mailman/listinfo/insight-developers



More information about the Insight-developers mailing list