[Insight-developers] A few minor consistency issues

[Zachary Pincus]

No problem! I'll test whether switching to operator== fixes the problem.
If so, I'll change BinaryFunctorImageFilter.h too, since that also  
lacks a if-equal test.

Zach

On Jan 12, 2006, at 1:09 PM, Bill Lorensen wrote:

> Zach,
>
> Sorry for the delay. Lots going on this week and lots of developers  
> out of town. Preferably, the Modified time should be honored. This  
> affects pipeline efficiency. I think if operator== is implemented  
> on the functors, it should work. We should probably change the  
> other functor filters also.
>
> Bill
>
> At 03:25 PM 1/12/2006, Zachary Pincus wrote:
>> Having not heard objection to the fix for the issue of
>> itkTernaryFunctorImageFilter::SetFunctor() not compiling properly, I
>> have opened a bug (2714) and I will in short order commit the change
>> proposed below. Let me know if I should do otherwise.
>>
>> Zach
>>
>>
>>> I'll list the issues here, along with the proposed fix. Barring
>>> suggestions to the contrary, I'll file bugs and commit the fixes
>>> here proposed later this week.
>>>
>>> (1) itkTernaryFunctorImageFilter.h
>>> The SetFunctor() method doesn't compile under gcc4, because
>>> operator!= isn't being provided for the functor by the compiler.
>>>
>>> Here's what the method looks like:
>>>     void SetFunctor(const FunctorType& functor)
>>>     {
>>>      if ( m_Functor != functor )
>>>        {
>>>         m_Functor = functor;
>>>         this->Modified();
>>>        }
>>>     }
>>>
>>> The corresponding method in itkBinaryFunctorImageFilter.h is as
>>> follows:
>>>   void SetFunctor(const FunctorType& functor)
>>>   {
>>>     m_Functor = functor;
>>>     this->Modified();
>>>   }
>>>
>>> I propose removing the test in the Ternary case to make it look
>>> like the Binary case. Are there any other suggestions, or would
>>> this be the best approach?
>>
>> _______________________________________________
>> Insight-developers mailing list
>> Insight-developers at itk.org
>> http://www.itk.org/mailman/listinfo/insight-developers
>