[Insight-developers] recent changes generate warning messages with Intel compiler

[Kent Williams]

I noticed Irix/MipsPRO compiler was warning about this as well.   The 
problem is that the argument types don't match, and it surely looks as 
though ImageSource should use the signature

virtual void PushBackInput(const DataObject *input);

Especially since all ImageToImageFilter::PushBackInput does is to call 
this->ProcessObject::PushBackInput().

Simon Warfield wrote:

>
> A recent enhancement to the API described here:
> http://www.itk.org/Testing/Sites/bathurst.bwh.harvard.edu/Linux-x86-debug-icc-9.0/20060210-0100-Nightly/Update.html 
>
>   ENH: New API to push/pop an input onto the input list. For multiple 
> input filters, this allows the application to use an the input list as 
> a stack or queue to a filter. If you have 10 images, you may want to 
> run a filter on images 1, 2, 3, 4. Then run a filter on images 2, 3, 
> 4, 5. Then 3, 4, 5, 6. Etc. The application can do this by poping an 
> input from the front of the input list and push an input onto the 
> back. An example use, is using the TileImageFilter to build a volume 
> from a set of 2D images, then modifying the set of image that are 
> tiled into the volume.
>
> has generated a large number of warning messages with the Intel 
> compiler such as the message below:
>
> http://www.itk.org/Testing/Sites/bathurst.bwh.harvard.edu/Linux-x86-debug-icc-9.0/20060210-0100-Nightly/BuildWarning.html 
>
>
> The author of the changes might want to check to see if the warning is 
> serious or not and possibly modify the code to avoid the warning.
>
>> File: *Code/Common/itkImageToImageFilter.h* Line: *118*CVS 
>> <http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Common/itkImageToImageFilter.h?cvsroot=Insight&annotate=HEAD#118> 
>>
>> Building CXX object 
>> Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/itkFEMSolverCrankNicolson.o
>> Building CXX object 
>> Code/Numerics/FEM/CMakeFiles/ITKFEM.dir/itkFEMGenerateMesh.o
>> Linking CXX static library ../../../bin/libITKFEM.a
>> Linking CXX executable ../../../bin/itkNumericsHeaderTest
>> Scanning dependencies of target itkNumericsTests
>> Building CXX object 
>> Testing/Code/Numerics/CMakeFiles/itkNumericsTests.dir/itkNumericsTests.o
>> */.../Insight/Code/Common/itkImageToImageFilter.h(118): warning 
>> #1125: function "itk::ProcessObject::PushBackInput(const 
>> itk::DataObject *)" is hidden by 
>> "itk::ImageToImageFilter<TInputImage, TOutputImage>::PushBackInput 
>> [with TInputImage=itk::Image<double, 6U>, 
>> TOutputImage=itk::Image<double, 6U>]" -- virtual function override 
>> intended?
>> *    virtual void PushBackInput( const InputImageType *image);
>>                  ^
>>           detected during:
>>             instantiation of class 
>> "itk::ImageToImageFilter<TInputImage, TOutputImage> [with 
>> TInputImage=itk::Image<double, 6U>, TOutputImage=itk::Image<double, 
>> 6U>]" at line 37 of 
>> "/.../Insight/Code/Common/itkDifferenceImageFilter.h"
>>             instantiation of class 
>> "itk::DifferenceImageFilter<TInputImage, TOutputImage> [with 
>> TInputImage=itk::Image<double, 6U>, TOutputImage=itk::Image<double, 
>> 6U>]" at line 250 of "/.../Insight/Code/Common/itkTestMain.h"
>>   
>
>