[Insight-developers] Re: STEP 1: itpack.cxx: moved

[Luis Ibanez]

more hints...


itkFEMItpackSparseMatrix.h
itkFEMLinearSystemWrapperItpack.h
itkFEMSolverCrankNicolson.h

include itpack.h,

itpack.h includes f2c.h

and f2c.h has a lot of nasty exposed code like

> 
> #define abs(x) ((x) >= 0 ? (x) : -(x))
> #define dabs(x) (doublereal)abs(x)
> #define min(a,b) ((a) <= (b) ? (a) : (b))
> #define max(a,b) ((a) >= (b) ? (a) : (b))
> #define dmin(a,b) (doublereal)min(a,b)
> #define dmax(a,b) (doublereal)max(a,b)
> 

....

the f2c.h should only be exposed to the .cxx
files that are wrapping itpack.

... working on it...

Luis



----------------------------------------------
Lorensen, William E (Research) wrote:
> Luis,
> Some strange side effect from someones changes. Any ideas?
> 
> Bill
> 
> -----Original Message-----
> From: Luis Ibanez [mailto:luis . ibanez at kitware . com]
> Sent: Thursday, August 07, 2003 9:21 PM
> To: Brian B Avants
> Cc: tessa; Aljaz Noe; Insight Developers List; gee at rad . upenn . edu;
> jtduda at grasp . cis . upenn . edu
> Subject: Re: [Insight-developers] Re: STEP 1: itpack.cxx: moved 
> 
> 
> Hi Brian,
> 
> Thanks for looking into the details of itpack.cxx.
> 
> The file was moved to
> 
>    Insight/Utilities/vxl/v3p/netlib/
> 
> with its original name:     dsrc2c.c
> 
> Some editing was necessary to avoid conflicts
> with other functions already existing in this
> directory.
> 
> The dsrc2c.f (FORTRAN) file was also commited there.
> Using f2c on this file will not reproduce dsrc2c.c
> (due to the manual editing).  The files in vxl/.../netlib
> have been edited anyways, so there is not need for
> maintaining the one-to-one mapping fortran to C.
> 
> --
> 
> The files in
> 
>    Insight/Code/Numerics/FEM
> 
> and
> 
>    Insight/Testing/Code/Numerics/FEM/
> 
> were modified accordingly.
> 
> The code is compiling in gcc 3.02 and gcc 3.3.
> 
> After the changes, the FEM test are all passing,
> except the test
> 
>     itkFEMCOTriangularElement-Quadratic
> 
> which was already failing in all platforms before
> the changes related to itpack.cxx
> 
> 
> -----------------
> 
> We still have to see how it goes in other platforms,
> 
> Please let me know if you find any problems.
> 
> 
> Thanks
> 
> 
> 
>     Luis
> 
> 
> 
> -------------------------------
> Brian B Avants wrote:
> 
>>Luis -
>>
>>I believe the only issues would involve linking -> changing the cmake
>>files etc.  There's nothing special going on there ... we'd just have to
>>make sure that it's compiled before the FEM stuff and gets linked in where
>>needed.
>>
>>correct me if i'm wrong ...
>>
>>Brian
>>
>>
> 
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk . org
> http://www . itk . org/mailman/listinfo/insight-developers
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk . org
> http://www . itk . org/mailman/listinfo/insight-developers
>