Hi Yair, Patrick,<br><br>You've compiled ITK just fine. This is a bug in igstkToolCalibrationReader.txx . <br><br>The correct way this file should've included zlib is <br> #include "itk_zlib.h" or #include "vtk_zlib.h"
<br>not<br> #include "zlib/zlib.h"<br><br>The problem with including "zlib/zlib.h" is that IGSTK will fail to build <br>
1. against installed ITK/VTK. since they don't install the zlib.h header file in "zlib/zlib.h".<br>2. if ITK and VTK were compiled so as to use system zlib.<br><br>HTH,<br>--<br>karthik<br><br>PS:<br>The header file itk_zlib or vtk_zlib picks the appropriate zlib library based on whether you'd compiled ITK/VTK asking the libraries to pick the system zlib or the zlib provided with the library.
<br><br><br>
<div><span class="gmail_quote">On 1/17/07, <b class="gmail_sendername">Yair Yarom</b> <<a href="mailto:irush@cs.huji.ac.il">irush@cs.huji.ac.il</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>Hi,<br><br>Sorry if I was unclear:<br>Under debian (etch), there is no "zlib/zlib.h" in the standard include paths<br>(or anywhere else for that matter), as included from<br>igstkToolCalibrationReader.txx. there is only /usr/include/zlib.h, so I changed
<br>the include (back?) to '#include "zlib.h"', and it compiles. I guess the<br>location of zlib.h should be checked by the cmake, but I'm not sure (I'm new at<br>this).<br><br>Later on, as described earlier, there is a conflict between
zlib.h and the<br>ITK's zlib.h at InsightToolkit/Utilities/itkzlib/zlib.h. This is due to the<br>fact the ITK's zlib.h is an older version (1.1.4) in comparison to the debian's<br>version (1.2.3). The conflict is since one has an
<br>#ifndef _ZLIB_H<br>and the other has<br>#ifndef ZLIB_H<br>So both are included, causing the duplicate definitions. But I guess this is an<br>ITK bug (or me not knowing how to compile ITK).<br><br><br>Regards,<br> Yair.
<br><br><br><br>Luis Ibanez <<a href="mailto:luis.ibanez@kitware.com">luis.ibanez@kitware.com</a>> writes:<br><br>> Hi Yair,<br>><br>> 1) Thanks for pointing out the shift on the<br>> numbering of serial port symbols.
<br>><br>> This has been entered as bug:<br>><br>> <a href="http://public.kitware.com/Bug/bug.php?op=show&bugid=4314&pos=0">http://public.kitware.com/Bug/bug.php?op=show&bugid=4314&pos=0</a>
<br>><br>> and a fix for the CMakeLists.txt file has been<br>> committed in CVS:<br>><br>> <a href="http://public.kitware.com/cgi-bin/viewcvs.cgi/CMakeLists.txt?root=IGSTK&r1=1.23&r2=1.24">http://public.kitware.com/cgi-bin/viewcvs.cgi/CMakeLists.txt?root=IGSTK&r1=1.23&r2=1.24
</a><br>><br>><br>><br>> 2) You seem to be using an old version of IGSTK.<br>> The Include for "zlib/zlib.h" was added to<br>> the igstkToolCallibrationReader.txx on June 7th<br>> 2006.
<br>><br>> <a href="http://public.kitware.com/cgi-bin/viewcvs.cgi/Source/igstkToolCalibrationReader.txx?annotate=1.3&root=IGSTK">http://public.kitware.com/cgi-bin/viewcvs.cgi/Source/igstkToolCalibrationReader.txx?annotate=1.3&root=IGSTK
</a><br>><br>><br>> Please use an updated version of IGSTK.<br>><br>><br>> Please let us know if you find any other problems,<br>><br>><br>><br>> Regards,<br>><br>><br>> Luis<br>
><br>><br>><br>> ---------------------------<br>> Yair Yarom wrote:<br>>> Hi,<br>>> I have several compilation errors for the cvs version on linux (debian):<br>>> 1. In the CMakeLists.txt, the "high" ports numbering is wrong (no port 4 and
<br>>> extra port 8), at around line 161, instead of:<br>>> SET(IGSTK_SERIAL_PORT_5 "/dev/ttyS4" CACHE STRING<br>>> SET(IGSTK_SERIAL_PORT_6 "/dev/ttyS5" CACHE STRING<br>>> SET(IGSTK_SERIAL_PORT_7 "/dev/ttyS6" CACHE STRING
<br>>> SET(IGSTK_SERIAL_PORT_8 "/dev/ttyS7" CACHE STRING<br>>> it should be (I think):<br>>> SET(IGSTK_SERIAL_PORT_4 "/dev/ttyS4" CACHE STRING<br>>> SET(IGSTK_SERIAL_PORT_5 "/dev/ttyS5" CACHE STRING
<br>>> SET(IGSTK_SERIAL_PORT_6 "/dev/ttyS6" CACHE STRING<br>>> SET(IGSTK_SERIAL_PORT_7 "/dev/ttyS7" CACHE STRING<br>>> 2. In igstkToolCalibrationReader.txx, there is no "zlib/zlib.h" to include,
<br>>> there is only "zlib.h". But this fix possibly causes error 3:<br>>> 3. When building with testing, I get the error:<br>>> [ 46%] Built target IGSTK<br>>> [ 46%] Building CXX object Testing/CMakeFiles/igstkStateMachineExportTest.dir/igstkStateMachineExportTest.o
<br>>> /usr/include/zlib.h:82: error: redefinition of 'struct z_stream_s'<br>>> /usr/local/include/InsightToolkit/Utilities/itkzlib/zlib.h:68: error: previous definition of 'struct z_stream_s'<br>>> /usr/include/zlib.h:101: error: invalid type in declaration before ';' token
<br>>> /usr/include/zlib.h:101: error: conflicting declaration 'typedef int z_stream'<br>>> /usr/local/include/InsightToolkit/Utilities/itkzlib/zlib.h:87: error: 'z_stream' has a previous declaration as 'typedef struct z_stream_s z_stream'
<br>>> /usr/include/zlib.h:1114: error: declaration of C function 'int itk_zlib_gzwrite(void*, const void*, unsigned int)' conflicts with<br>>> /usr/local/include/InsightToolkit/Utilities/itkzlib/zlib.h:704: error: previous declaration 'int itk_zlib_gzwrite(void*, void*, unsigned int)' here
<br>>> /usr/include/zlib.h:1350: error: redefinition of 'struct internal_state'<br>>> /usr/local/include/InsightToolkit/Utilities/itkzlib/zlib.h:882: error: previous definition of 'struct internal_state'<br>>> make[2]: *** [Testing/CMakeFiles/igstkStateMachineExportTest.dir/igstkStateMachineExportTest.o] Error 1
<br>>> make[1]: *** [Testing/CMakeFiles/igstkStateMachineExportTest.dir/all] Error 2<br>>> make: *** [all] Error 2<br>>> Without the testings, it builds fine.<br>>> Thanks,<br>>> Yair.<br>
>> _______________________________________________<br>>> IGSTK-Users mailing list<br>>> <a href="mailto:IGSTK-Users@public.kitware.com">IGSTK-Users@public.kitware.com</a><br>>> <a href="http://public.kitware.com/cgi-bin/mailman/listinfo/igstk-users">
http://public.kitware.com/cgi-bin/mailman/listinfo/igstk-users</a><br>>><br>_______________________________________________<br>IGSTK-Users mailing list<br><a href="mailto:IGSTK-Users@public.kitware.com">IGSTK-Users@public.kitware.com
</a><br><a href="http://public.kitware.com/cgi-bin/mailman/listinfo/igstk-users">http://public.kitware.com/cgi-bin/mailman/listinfo/igstk-users</a><br></blockquote></div><br>