<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 1, 2015 at 10:00 AM, Jonathan Beezley <span dir="ltr"><<a href="mailto:jonathan.beezley@kitware.com" target="_blank">jonathan.beezley@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">If we are producing both anyway, it doesn't make sense to not minify geo.min.js. That is just confusing. We could provide a development option that causes the examples to use the non-minified version though.</div></blockquote><div> </div><div>Sure, that will be better if thats not too much work. +1</div><div><br></div><div>- Aashish <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 9:54 AM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure, but what happens is that examples (or tests), one of these two, uses geo.min.js and then we are debugging its an extra step to change then to use geo.js. I am wondering if we we provide debug-js option, then we won't mangle geo.min.js as well? Just a thought. <span><font color="#888888"><div><br></div><div>- aashish</div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 9:51 AM, Jonathan Beezley <span dir="ltr"><<a href="mailto:jonathan.beezley@kitware.com" target="_blank">jonathan.beezley@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">We already generate both minified and non-minified.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 9:50 AM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Jon, <div><br></div><div>Should we add this option to geojs as well? </div><div><br></div><div>- aashish</div><div><div><div><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Zach Mullen</b> <span dir="ltr"><<a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a>></span><br>Date: Wed, Jul 1, 2015 at 9:48 AM<br>Subject: [girder] Add a grunt option for disabling uglify mangling (#881)<br>To: girder/girder <<a href="mailto:girder@noreply.github.com" target="_blank">girder@noreply.github.com</a>><br><br><br>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href="https://github.com/girder/girder/pull/881" target="_blank">https://github.com/girder/girder/pull/881</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add a grunt option for disabling uglify mangling</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/girder/girder/pull/881/files#diff-0" target="_blank">Gruntfile.js</a>
(27)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/girder/girder/pull/881/files#diff-1" target="_blank">docs/development.rst</a>
(5)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href="https://github.com/girder/girder/pull/881.patch" target="_blank">https://github.com/girder/girder/pull/881.patch</a></li>
<li><a href="https://github.com/girder/girder/pull/881.diff" target="_blank">https://github.com/girder/girder/pull/881.diff</a></li>
</ul>
<p style="font-size:small;color:#666">—<br>Reply to this email directly or <a href="https://github.com/girder/girder/pull/881" target="_blank">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AAI8X-UEuVYARBY-UpoWCS4iocD-ap4lks5oY-clgaJpZM4FP2ug.gif" width="1"></p>
<div>
<div>
</div>
</div>
</div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr"><font face="trebuchet ms, sans-serif"><i>| Aashish Chaudhary <br>| Technical Leader <br>| Kitware Inc. <br></i></font><div><i><font face="trebuchet ms, sans-serif">| </font><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></i></div></div></div>
</font></span></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><font face="trebuchet ms, sans-serif"><i>| Aashish Chaudhary <br>| Technical Leader <br>| Kitware Inc. <br></i></font><div><i><font face="trebuchet ms, sans-serif">| </font><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></i></div></div></div>
</div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><font face="trebuchet ms, sans-serif"><i>| Aashish Chaudhary <br>| Technical Leader <br>| Kitware Inc. <br></i></font><div><i><font face="trebuchet ms, sans-serif">| </font><a href="http://www.kitware.com/company/team/chaudhary.html" target="_blank">http://www.kitware.com/company/team/chaudhary.html</a></i></div></div></div>
</div></div>