<div dir="ltr"><div><div>Hi Miklos, <br><br>Thanks for your contribution. Just tried your changes and it also fixes the problem within Slicer. Would be awesome to integrate it.<br><br>If possible, could you consider adding a more descriptive commit message explaining which problem the commit is fixing. Referencing the issue using something like "See #409" would also be great.<br>
<br></div>Thanks<br></div>Jc<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Nov 17, 2013 at 1:55 PM, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Miklos,<div><br><div>This is great news ! </div></div><div>The patch looks good to me. Did you try it on windows, linux and mac ?</div>
<div><br></div><div>Before merging, let's make sure Slicer still works with that change.</div>
<div>I'm on vacation this week so it will be a challenge for me to run those tests, Jc, do you have time to try it ?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Julien.</div><div><br></div></font></span></div>
<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Nov 16, 2013 at 7:12 AM, Miklos Espak <span dir="ltr"><<a href="mailto:espakm@gmail.com" target="_blank">espakm@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I found a simple solution. Could you please review and merge?<br><br><a href="https://github.com/commontk/CTK/pull/410" target="_blank">https://github.com/commontk/CTK/pull/410</a><br><br></div><div>
<div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On 16 November 2013 11:08, Miklos Espak <span dir="ltr"><<a href="mailto:espakm@gmail.com" target="_blank">espakm@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">If I change the window flag from Qt::ToolTip to Qt::PopUp then the widget gets the keyboard focus, but then the panel cannot be pinned.<br><br>
</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On 15 November 2013 22:52, Julien Finet <span dir="ltr"><<a href="mailto:julien.finet@kitware.com" target="_blank">julien.finet@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Miklos,<div><br></div><div>I've noticed that odd behavior but I haven't found the time to investigate much further than what you already did. </div>
<div>My gut feeling is that it can't get focus because the popup window is not "active" (only 1 window can be active at a time ?).</div>
<div>You might have to play with activateWindow() or something like that.</div><div><br></div><div>Hth,</div><div>Julien.</div><div><br></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>
On Fri, Nov 15, 2013 at 12:28 PM, Miklos Espak <span dir="ltr"><<a href="mailto:espakm@gmail.com" target="_blank">espakm@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div><div><div><div><div><div><div>Hi,<br><br></div>I have a drop down control panel with some slider widgets on it.<br>
<br></div>If I click into the spinbox, it should get the keyboard focus and the cursor should start blinking, but it does not. I can select the number by mouse, but cannot type anything into it.<br>
<br></div>If I place the control panel on an ordinary QWidget, all works fine.<br><br></div>I added an event filter to the line edit of the spin box to see if it gets the mouse pressed event. It does. But it does not get the FocusIn event. If I put the control panel an a QWidget, then the ctkDoubleSpinBox gets the FocusIn event.<br>
<br></div>Has anybody tried to use a ctkDoubleSpinBox or similar on a ctkPopUpWidget?<br><br></div>Any idea, why there the no FocusIn event is not emitted / received if the spinbox is on a popup widget, even if the mouse press event definitely arrives to the line edit?<br>
<br></div>Cheers,<br>Miklos<br><br></div>
<br></div></div>_______________________________________________<br>
Ctk-developers mailing list<br>
<a href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>+1 919 869 8849<br>
</div>